diff options
| author | Danilo M. <danix@danix.xyz> | 2026-10-19 10:08:37 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-10-19 10:08:37 +0200 |
| commit | 6ccdad992e7a62e92f3a67c3e370646f787aefd9 (patch) | |
| tree | 0e0a4405d0b6930d290ec68a10387da74f569690 /notifications | |
| parent | d9c9c30865330b24349438e4e20579fd76dafbd5 (diff) | |
| download | quickshell-6ccdad992e7a62e92f3a67c3e370646f787aefd9.tar.gz quickshell-6ccdad992e7a62e92f3a67c3e370646f787aefd9.zip | |
notifications: write gsettings only when the theme changed
From the final review. Every save ran gsettings set, so saving a timeout
on a first run, with no soundTheme in the file, silently reset a system
theme set elsewhere to freedesktop; the page now writes it only when the
draft's theme differs from the file's, and flags any other mismatch as
before. An exit code outside 0-3, a save killed mid-run, now reads as an
error rather than a partial success. The player's comment no longer
claims the balloon's expiry check, which it does not need.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Diffstat (limited to 'notifications')
| -rw-r--r-- | notifications/Balloons.qml | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/notifications/Balloons.qml b/notifications/Balloons.qml index 1b3cce8..abeb13a 100644 --- a/notifications/Balloons.qml +++ b/notifications/Balloons.qml @@ -40,7 +40,8 @@ Scope { // A sound per new or replaced notification (replace keeps the id and // changes created), played only when its balloon would show now: the - // same drawer, snooze, mute and DND checks as NotificationBalloon. The + // drawer, snooze, mute and DND checks NotificationBalloon makes (not its + // expiry, which a just-arrived entry cannot have passed). The // first read after a start only records what is there, so a restart is // silent. seen is rebuilt from the queue each time, so it never grows. property var seen: ({}) |
