From 6ccdad992e7a62e92f3a67c3e370646f787aefd9 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Mon, 19 Oct 2026 10:08:37 +0200 Subject: notifications: write gsettings only when the theme changed From the final review. Every save ran gsettings set, so saving a timeout on a first run, with no soundTheme in the file, silently reset a system theme set elsewhere to freedesktop; the page now writes it only when the draft's theme differs from the file's, and flags any other mismatch as before. An exit code outside 0-3, a save killed mid-run, now reads as an error rather than a partial success. The player's comment no longer claims the balloon's expiry check, which it does not need. Co-Authored-By: Claude Opus 5.5 --- notifications/Balloons.qml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'notifications') diff --git a/notifications/Balloons.qml b/notifications/Balloons.qml index 1b3cce8..abeb13a 100644 --- a/notifications/Balloons.qml +++ b/notifications/Balloons.qml @@ -40,7 +40,8 @@ Scope { // A sound per new or replaced notification (replace keeps the id and // changes created), played only when its balloon would show now: the - // same drawer, snooze, mute and DND checks as NotificationBalloon. The + // drawer, snooze, mute and DND checks NotificationBalloon makes (not its + // expiry, which a just-arrived entry cannot have passed). The // first read after a start only records what is there, so a restart is // silent. seen is rebuilt from the queue each time, so it never grows. property var seen: ({}) -- cgit v1.2.3