aboutsummaryrefslogtreecommitdiffstats
path: root/desktop/modules/updates/updatesctl
diff options
context:
space:
mode:
authorDanilo M. <danix@danix.xyz>2026-10-15 12:16:48 +0200
committerDanilo M. <danix@danix.xyz>2026-10-15 12:16:48 +0200
commit0fdd992b1fd0c24e6f7ab5630575904926d91137 (patch)
tree914cf60ce8521622feeeff33cd1838a4252a9e33 /desktop/modules/updates/updatesctl
parent5d6e95de016c8769dc13bb0f31a9e6b72b46bcd7 (diff)
downloadquickshell-0fdd992b1fd0c24e6f7ab5630575904926d91137.tar.gz
quickshell-0fdd992b1fd0c24e6f7ab5630575904926d91137.zip
fix(updates): drop a redundant clause, test the mirror blacklist
The awaiting-build branch also required the build to be older than upstream, which cannot fail there: a build newer than installed was already taken as an upgrade, so the build is at most the installed version, which is behind upstream whenever a row is emitted. Removing it left every test passing, which is how it was found. The blacklisted testing/ entry sat after the main one in the fixture, so setdefault kept the main one and the mirror-side blacklist was never exercised; it now comes first, and dropping the check fails the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Diffstat (limited to 'desktop/modules/updates/updatesctl')
-rwxr-xr-xdesktop/modules/updates/updatesctl2
1 files changed, 1 insertions, 1 deletions
diff --git a/desktop/modules/updates/updatesctl b/desktop/modules/updates/updatesctl
index 835f3d0..ee843c2 100755
--- a/desktop/modules/updates/updatesctl
+++ b/desktop/modules/updates/updatesctl
@@ -246,7 +246,7 @@ def tracked(installed, errors):
if i and b and vercmp(b, i) > 0:
out["upgrade"].append(row(name, label, i, b))
- elif i and r and vercmp(r, up) >= 0 and (not b or vercmp(b, up) < 0):
+ elif i and r and vercmp(r, up) >= 0:
if vercmp(i, up) < 0:
out["build"].append(row(name, label, b or i, up))
elif i or (r and label != "SBo"):