From 0fdd992b1fd0c24e6f7ab5630575904926d91137 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Thu, 15 Oct 2026 12:16:48 +0200 Subject: fix(updates): drop a redundant clause, test the mirror blacklist The awaiting-build branch also required the build to be older than upstream, which cannot fail there: a build newer than installed was already taken as an upgrade, so the build is at most the installed version, which is behind upstream whenever a row is emitted. Removing it left every test passing, which is how it was found. The blacklisted testing/ entry sat after the main one in the fixture, so setdefault kept the main one and the mirror-side blacklist was never exercised; it now comes first, and dropping the check fails the test. Co-Authored-By: Claude Opus 5.5 --- desktop/modules/updates/updatesctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'desktop/modules/updates/updatesctl') diff --git a/desktop/modules/updates/updatesctl b/desktop/modules/updates/updatesctl index 835f3d0..ee843c2 100755 --- a/desktop/modules/updates/updatesctl +++ b/desktop/modules/updates/updatesctl @@ -246,7 +246,7 @@ def tracked(installed, errors): if i and b and vercmp(b, i) > 0: out["upgrade"].append(row(name, label, i, b)) - elif i and r and vercmp(r, up) >= 0 and (not b or vercmp(b, up) < 0): + elif i and r and vercmp(r, up) >= 0: if vercmp(i, up) < 0: out["build"].append(row(name, label, b or i, up)) elif i or (r and label != "SBo"): -- cgit v1.2.3