aboutsummaryrefslogtreecommitdiffstats
path: root/tests/test_querycompleter.cpp
blob: 6cf96511e9af3da7ec52640785f2638ef6321963 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
/*
 * qtmaildir - a Qt6 mail client for notmuch-indexed Maildirs
 * Copyright (C) 2026 Danilo M. <danix@danix.xyz>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 as
 * published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

#include <QtTest>
#include <QTemporaryDir>

#include <QLineEdit>
#include <QImage>
#include <QListView>
#include <QPixmap>

#include "config.h"
#include "querycompleter.h"

class TestQueryCompleter : public QObject
{
    Q_OBJECT

private slots:
    void emptyTextCompletesPrefix();
    void bareWordCompletesPrefix();
    void wordAfterOperatorCompletesPrefix();
    void prefixReplaceSpanCoversTheWord();
    void colonSwitchesToValue();
    void valueReplaceSpanExcludesThePrefix();
    void prefixIsLowercased();
    void emptyValueAfterColonStillCompletes();
    void insideQuotesCompletesNothing();
    void afterClosedQuotesCompletesAgain();
    void rangeUpperBoundCompletes();
    void rangeLowerBoundCompletes();
    void bareValueAllowsRelativeEntries();
    void rangeSuppressesRelativeEntries();
    void prefixVocabularyCoversNotmuchKeywords();
    void dateVocabularySeparatesRelativeEntries();
    void tagAndIsShareTheTagModel();
    void pathOffersAccountMaildirsBothForms();
    void folderOffersNothing();
    void mimetypeAppendsConfiguredEntries();
    void rangeContextDropsRelativeDates();
    void acceptReplacesOnlyThePrefixToken();
    void acceptReplacesOnlyTheValueAfterThePrefix();
    void acceptReplacesOnlyTheEditedRangeBound();
    void acceptReplacesTheWholeBoundWhenCompletingMidWord();

    // The tests above call acceptCompletion() directly and so never touch the
    // widget. These drive the path a user actually hits.
    void typingOpensThePopupOnALaterToken();
    void tabAcceptsTheHighlightedCompletion();
    void tabIsIgnoredWhileThePopupIsHidden();
    void returnIsIgnoredWhileThePopupIsHidden();
    void focusOpensThePopupOnlyWhenConfigured();

    // Delivered to the widget the window system actually gives the key to,
    // rather than straight to the line edit. While the popup is up that is the
    // popup, which has grabbed the keyboard, and a filter on the line edit
    // never runs. Sending to the edit hides exactly the bug the user reports.
    void tabAcceptsWhenTheKeyGoesToTheGrabbingPopup();
    void returnAcceptsWhenTheKeyGoesToTheGrabbingPopup();
    void acceptingAPrefixReopensThePopupForValues();
    void acceptingAValueDoesNotReopenAnEmptyPopup();
    void keysFallThroughWhileThePopupIsHidden();

    // The application filter re-entrancy bug: sendEvent() re-runs application
    // event filters, so forwarding a key to the popup from inside the filter
    // hands it straight back and the recursion only ends in a stack overflow.
    void arrowNavigationDoesNotRecurse();
    void returnRunsTheQueryOnceCompletionIsDone();
    void returnRunsTheQueryAfterAMouseAccept();
    void returnRunsTheQueryWhenThePopupMatchesNothing();
    void theDescriptionSurvivesAModestPopupWidth();
};

// Copied from tests/test_config.cpp rather than shared, so the two test files
// stay independent.
static QString writeIni(const QTemporaryDir &dir, const QString &body)
{
    const QString path = dir.filePath(QStringLiteral("qtmaildir.conf"));
    QFile f(path);
    f.open(QIODevice::WriteOnly | QIODevice::Text);
    f.write(body.toUtf8());
    f.close();
    return path;
}

void TestQueryCompleter::emptyTextCompletesPrefix()
{
    const CompletionContext ctx = completionContext(QString(), 0);
    QCOMPARE(ctx.kind, CompletionContext::Prefix);
    QCOMPARE(ctx.stem, QString());
}

void TestQueryCompleter::bareWordCompletesPrefix()
{
    const CompletionContext ctx = completionContext(QStringLiteral("su"), 2);
    QCOMPARE(ctx.kind, CompletionContext::Prefix);
    QCOMPARE(ctx.stem, QStringLiteral("su"));
}

void TestQueryCompleter::wordAfterOperatorCompletesPrefix()
{
    // The token boundary is whitespace, not the start of the line.
    const QString text = QStringLiteral("tag:inbox and su");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.kind, CompletionContext::Prefix);
    QCOMPARE(ctx.stem, QStringLiteral("su"));
}

void TestQueryCompleter::prefixReplaceSpanCoversTheWord()
{
    const QString text = QStringLiteral("tag:inbox and su");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.replaceFrom, 14);
    QCOMPARE(ctx.replaceLength, 2);
}

void TestQueryCompleter::colonSwitchesToValue()
{
    const QString text = QStringLiteral("tag:sho");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.kind, CompletionContext::Value);
    QCOMPARE(ctx.prefix, QStringLiteral("tag"));
    QCOMPARE(ctx.stem, QStringLiteral("sho"));
}

void TestQueryCompleter::valueReplaceSpanExcludesThePrefix()
{
    // Accepting must overwrite "sho" only, never "tag:".
    const QString text = QStringLiteral("tag:sho");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.replaceFrom, 4);
    QCOMPARE(ctx.replaceLength, 3);
}

void TestQueryCompleter::prefixIsLowercased()
{
    const QString text = QStringLiteral("TAG:sho");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.prefix, QStringLiteral("tag"));
}

void TestQueryCompleter::emptyValueAfterColonStillCompletes()
{
    // "tag:" with the cursor at the end offers every tag.
    const QString text = QStringLiteral("tag:");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.kind, CompletionContext::Value);
    QCOMPARE(ctx.prefix, QStringLiteral("tag"));
    QCOMPARE(ctx.stem, QString());
    QCOMPARE(ctx.replaceFrom, 4);
    QCOMPARE(ctx.replaceLength, 0);
}

void TestQueryCompleter::insideQuotesCompletesNothing()
{
    // subject:"foo bar| is a literal, not a keyword position.
    const QString text = QStringLiteral("subject:\"foo bar");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.kind, CompletionContext::None);
}

void TestQueryCompleter::afterClosedQuotesCompletesAgain()
{
    const QString text = QStringLiteral("subject:\"foo bar\" and ta");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.kind, CompletionContext::Prefix);
    QCOMPARE(ctx.stem, QStringLiteral("ta"));
}

void TestQueryCompleter::rangeUpperBoundCompletes()
{
    const QString text = QStringLiteral("date:today..yes");
    const CompletionContext ctx = completionContext(text, text.size());
    QCOMPARE(ctx.kind, CompletionContext::Value);
    QCOMPARE(ctx.prefix, QStringLiteral("date"));
    QCOMPARE(ctx.stem, QStringLiteral("yes"));
    // Overwrites "yes" only: "date:today.." must survive.
    QCOMPARE(ctx.replaceFrom, 12);
    QCOMPARE(ctx.replaceLength, 3);
}

void TestQueryCompleter::rangeLowerBoundCompletes()
{
    // Cursor sits at offset 8, mid-way through the lower bound rather than at
    // its end. End-of-bound would not discriminate: there the whole-bound span
    // and the typed-so-far span happen to be the same length.
    const QString text = QStringLiteral("date:lastweek..today");
    const CompletionContext ctx = completionContext(text, 8);
    QCOMPARE(ctx.kind, CompletionContext::Value);
    QCOMPARE(ctx.stem, QStringLiteral("las"));
    QCOMPARE(ctx.replaceFrom, 5);
    // Covers the whole lower bound, so accepting leaves no "tweek" tail.
    QCOMPARE(ctx.replaceLength, 8);
    QVERIFY(!ctx.allowRangeEntries);
}

void TestQueryCompleter::bareValueAllowsRelativeEntries()
{
    const QString text = QStringLiteral("date:1w");
    const CompletionContext ctx = completionContext(text, text.size());
    QVERIFY(ctx.allowRangeEntries);
}

void TestQueryCompleter::rangeSuppressesRelativeEntries()
{
    // "1week.." offered here would produce date:1week....today.
    const QString text = QStringLiteral("date:1w..today");
    const CompletionContext ctx = completionContext(text, 7);
    QVERIFY(!ctx.allowRangeEntries);
}

void TestQueryCompleter::prefixVocabularyCoversNotmuchKeywords()
{
    const QList<CompletionEntry> entries = prefixVocabulary();

    QStringList values;
    for (const CompletionEntry &entry : entries)
        values.append(entry.value);

    QVERIFY(values.contains(QStringLiteral("tag:")));
    QVERIFY(values.contains(QStringLiteral("date:")));
    QVERIFY(values.contains(QStringLiteral("and")));

    // Every entry carries a description; a blank column teaches nothing.
    for (const CompletionEntry &entry : entries)
        QVERIFY(!entry.description.isEmpty());
}

void TestQueryCompleter::dateVocabularySeparatesRelativeEntries()
{
    const QList<CompletionEntry> entries = dateVocabulary();

    bool sawSymbolic = false;
    bool sawRelative = false;
    for (const CompletionEntry &entry : entries) {
        if (entry.value == QStringLiteral("today"))
            sawSymbolic = true;
        if (entry.value.contains(QStringLiteral("..")))
            sawRelative = true;
    }
    QVERIFY(sawSymbolic);
    QVERIFY(sawRelative);
}

void TestQueryCompleter::tagAndIsShareTheTagModel()
{
    Config config;
    QueryCompleter completer(nullptr, config);
    completer.setTags({ QStringLiteral("inbox"), QStringLiteral("shopping/amazon") });

    const QStringList forTag = completer.candidatesFor(
        completionContext(QStringLiteral("tag:"), 4));
    const QStringList forIs = completer.candidatesFor(
        completionContext(QStringLiteral("is:"), 3));

    QVERIFY(forTag.contains(QStringLiteral("shopping/amazon")));
    QCOMPARE(forTag, forIs);
}

void TestQueryCompleter::pathOffersAccountMaildirsBothForms()
{
    QTemporaryDir dir;
    Config config;
    config.load(writeIni(dir, QStringLiteral(
        "[account.work]\n"
        "maildir = work\n"
        "address = you@example.org\n")));

    QueryCompleter completer(nullptr, config);
    const QStringList candidates = completer.candidatesFor(
        completionContext(QStringLiteral("path:"), 5));

    QVERIFY(candidates.contains(QStringLiteral("work")));
    // The recursive form is what scopedQuery() itself builds and is not
    // guessable, so it is offered directly.
    QVERIFY(candidates.contains(QStringLiteral("work/**")));
}

void TestQueryCompleter::folderOffersNothing()
{
    // folder: matches a Maildir folder name, not a path, and its values are
    // not enumerable from config. Prefix-only, like from: and to:.
    Config config;
    QueryCompleter completer(nullptr, config);
    const QStringList candidates = completer.candidatesFor(
        completionContext(QStringLiteral("folder:"), 7));
    QVERIFY(candidates.isEmpty());
}

void TestQueryCompleter::mimetypeAppendsConfiguredEntries()
{
    QTemporaryDir dir;
    Config config;
    config.load(writeIni(dir, QStringLiteral(
        "[completion]\n"
        "extra_mimetypes = application/epub+zip|EPUB book\n")));

    QueryCompleter completer(nullptr, config);
    const QStringList candidates = completer.candidatesFor(
        completionContext(QStringLiteral("mimetype:"), 9));

    QVERIFY(candidates.contains(QStringLiteral("application/epub+zip")));
    QVERIFY(candidates.contains(QStringLiteral("application/pdf")));
}

void TestQueryCompleter::rangeContextDropsRelativeDates()
{
    Config config;
    QueryCompleter completer(nullptr, config);

    const QStringList bare = completer.candidatesFor(
        completionContext(QStringLiteral("date:"), 5));
    QVERIFY(bare.contains(QStringLiteral("1week..")));

    const QString ranged = QStringLiteral("date:today..");
    const QStringList inRange = completer.candidatesFor(
        completionContext(ranged, ranged.size()));
    QVERIFY(inRange.contains(QStringLiteral("yesterday")));
    QVERIFY(!inRange.contains(QStringLiteral("1week..")));
}

// The accept path is driven directly rather than through synthetic key
// events: whether a key needs Shift is a keyboard-layout property, so
// QTest::keyClick could never decide whether this logic is right.
static QString acceptInto(const QString &text, int cursor, const QString &value)
{
    Config config;
    QLineEdit edit;
    QueryCompleter completer(&edit, config);

    edit.setText(text);
    edit.setCursorPosition(cursor);
    completer.updateContext();
    completer.acceptCompletion(value);

    return edit.text();
}

void TestQueryCompleter::acceptReplacesOnlyThePrefixToken()
{
    // The neighbouring token must survive untouched.
    QCOMPARE(acceptInto(QStringLiteral("tag:inbox su"), 12,
                        QStringLiteral("subject:")),
             QStringLiteral("tag:inbox subject:"));
}

void TestQueryCompleter::acceptReplacesOnlyTheValueAfterThePrefix()
{
    // QCompleter's own insertion would overwrite "date:tod" whole, because
    // that is the token it matched on. Only "tod" may be replaced.
    QCOMPARE(acceptInto(QStringLiteral("date:tod"), 8, QStringLiteral("today")),
             QStringLiteral("date:today"));
}

void TestQueryCompleter::acceptReplacesOnlyTheEditedRangeBound()
{
    const QString text = QStringLiteral("date:yesterday..to");
    QCOMPARE(acceptInto(text, text.size(), QStringLiteral("today")),
             QStringLiteral("date:yesterday..today"));
}

void TestQueryCompleter::acceptReplacesTheWholeBoundWhenCompletingMidWord()
{
    // Caret sits after "yest" but the bound runs to the "..", so accepting
    // must leave no "erday" tail behind.
    QCOMPARE(acceptInto(QStringLiteral("date:yesterday..today"), 9,
                        QStringLiteral("this_week")),
             QStringLiteral("date:this_week..today"));
}

// The popup is owned by the QCompleter, which is not reachable from the line
// edit now that setCompleter is deliberately not used. It is the only list
// view these tests create, so find it that way.
static QListView *findPopup()
{
    const auto widgets = QApplication::allWidgets();
    for (QWidget *w : widgets) {
        if (auto *view = qobject_cast<QListView *>(w))
            return view;
    }
    return nullptr;
}

void TestQueryCompleter::typingOpensThePopupOnALaterToken()
{
    // The regression: QLineEdit::setCompleter reset the completion prefix to
    // the widget's whole text on every keystroke, so nothing matched and the
    // popup stopped appearing after the first token.
    Config config;
    QLineEdit edit;
    edit.show();
    QueryCompleter completer(&edit, config);

    QTest::keyClicks(&edit, QStringLiteral("tag:unread date:last"));

    QListView *popup = findPopup();
    QVERIFY(popup);
    QVERIFY(popup->isVisible());

    QStringList offered;
    for (int row = 0; row < popup->model()->rowCount(); ++row)
        offered << popup->model()->index(row, 0).data().toString();
    QCOMPARE(offered, QStringList({ QStringLiteral("last_week"),
                                    QStringLiteral("last_month") }));
}

void TestQueryCompleter::tabAcceptsTheHighlightedCompletion()
{
    // The user's exact scenario. Tab used to fall through to focus navigation,
    // leaving the query half-typed.
    Config config;
    QLineEdit edit;
    edit.show();
    QueryCompleter completer(&edit, config);

    QTest::keyClicks(&edit, QStringLiteral("tag:unread date:last"));
    QVERIFY(findPopup() && findPopup()->isVisible());

    QKeyEvent tab(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier,
                  QStringLiteral("\t"));
    QApplication::sendEvent(&edit, &tab);

    // Consumed, so focus does not move to the next widget.
    QVERIFY(tab.isAccepted());
    // Only the token being completed is replaced, not the whole line.
    QCOMPARE(edit.text(), QStringLiteral("tag:unread date:last_week"));
    QVERIFY(!findPopup()->isVisible());
}

void TestQueryCompleter::tabIsIgnoredWhileThePopupIsHidden()
{
    // Every key must fall through when the popup is closed, or the query bar
    // stops behaving like a line edit.
    Config config;
    QLineEdit edit;
    edit.show();
    QueryCompleter completer(&edit, config);

    edit.setText(QStringLiteral("tag:unread"));
    if (QListView *popup = findPopup())
        popup->hide();

    QKeyEvent tab(QEvent::KeyPress, Qt::Key_Tab, Qt::NoModifier,
                  QStringLiteral("\t"));
    tab.ignore();
    QApplication::sendEvent(&edit, &tab);

    QCOMPARE(edit.text(), QStringLiteral("tag:unread"));
}

void TestQueryCompleter::returnIsIgnoredWhileThePopupIsHidden()
{
    // Enter accepts a completion only while the popup is up. With it closed it
    // must still reach returnPressed, which is what runs the query.
    Config config;
    QLineEdit edit;
    edit.show();
    QueryCompleter completer(&edit, config);

    edit.setText(QStringLiteral("tag:unread"));
    if (QListView *popup = findPopup())
        popup->hide();

    bool ran = false;
    connect(&edit, &QLineEdit::returnPressed, &edit, [&ran]() { ran = true; });

    QKeyEvent ret(QEvent::KeyPress, Qt::Key_Return, Qt::NoModifier);
    QApplication::sendEvent(&edit, &ret);

    QVERIFY(ran);
    QCOMPARE(edit.text(), QStringLiteral("tag:unread"));
}

void TestQueryCompleter::focusOpensThePopupOnlyWhenConfigured()
{
    // The event filter is now installed unconditionally, so the
    // completion_on_focus check moved inside it. Both settings still behave.
    QTemporaryDir dir;

    {
        Config off;
        off.load(writeIni(dir, QStringLiteral("[general]\n"
                                              "completion_on_focus=false\n")));
        QLineEdit edit;
        edit.show();
        QueryCompleter completer(&edit, off);
        edit.setFocus();
        QVERIFY(!findPopup() || !findPopup()->isVisible());
    }

    {
        Config on;
        on.load(writeIni(dir, QStringLiteral("[general]\n"
                                             "completion_on_focus=true\n")));
        QVERIFY(on.completionOnFocus());
        QLineEdit edit;
        edit.show();
        QueryCompleter completer(&edit, on);
        QFocusEvent focusIn(QEvent::FocusIn);
        QApplication::sendEvent(&edit, &focusIn);
        QVERIFY(findPopup());
        QVERIFY(findPopup()->isVisible());
    }
}

// The widget the window system would hand the next key to. While the popup is
// up it has grabbed the keyboard, so that is the popup and NOT the line edit,
// which has by then lost focus entirely. Routing test keys through here is what
// makes these tests reproduce the user's experience instead of a synthetic one.
static QWidget *keyboardTarget(QLineEdit *edit)
{
    if (QWidget *popup = QApplication::activePopupWidget())
        return popup;
    return edit;
}

void TestQueryCompleter::tabAcceptsWhenTheKeyGoesToTheGrabbingPopup()
{
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);

    QTest::keyClicks(&edit, QStringLiteral("t"));
    QVERIFY(findPopup() && findPopup()->isVisible());

    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Tab);

    QCOMPARE(edit.text(), QStringLiteral("tag:"));
}

void TestQueryCompleter::returnAcceptsWhenTheKeyGoesToTheGrabbingPopup()
{
    // Return must be consumed too, or it reaches the thread list and opens a
    // thread, which is what the user sees.
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);

    bool ran = false;
    connect(&edit, &QLineEdit::returnPressed, &edit, [&ran]() { ran = true; });

    QTest::keyClicks(&edit, QStringLiteral("t"));
    QVERIFY(findPopup() && findPopup()->isVisible());

    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Return);

    QCOMPARE(edit.text(), QStringLiteral("tag:"));
    QVERIFY(!ran);
}

void TestQueryCompleter::acceptingAPrefixReopensThePopupForValues()
{
    // The user's third complaint: after taking "tag:" the caret sits where a
    // tag value goes, so the values must be offered without a second Ctrl+Space.
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);
    completer.setTags({ QStringLiteral("unread"), QStringLiteral("inbox") });

    QTest::keyClicks(&edit, QStringLiteral("t"));
    QVERIFY(findPopup() && findPopup()->isVisible());

    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Tab);
    QCOMPARE(edit.text(), QStringLiteral("tag:"));

    QListView *popup = findPopup();
    QVERIFY(popup);
    QVERIFY(popup->isVisible());
    QStringList offered;
    for (int row = 0; row < popup->model()->rowCount(); ++row)
        offered << popup->model()->index(row, 0).data().toString();
    QCOMPARE(offered, QStringList({ QStringLiteral("unread"),
                                    QStringLiteral("inbox") }));

    // And the chain completes: typing into the reopened popup and accepting
    // yields the finished term.
    QTest::keyClicks(&edit, QStringLiteral("un"));
    QVERIFY(findPopup() && findPopup()->isVisible());
    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Tab);
    QCOMPARE(edit.text(), QStringLiteral("tag:unread"));
}

void TestQueryCompleter::acceptingAValueDoesNotReopenAnEmptyPopup()
{
    // "tag:unread" is complete. Reopening here would put an empty list under
    // the caret and swallow the next Return.
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);
    completer.setTags({ QStringLiteral("unread") });

    QTest::keyClicks(&edit, QStringLiteral("tag:un"));
    QVERIFY(findPopup() && findPopup()->isVisible());

    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Tab);

    QCOMPARE(edit.text(), QStringLiteral("tag:unread"));
    QVERIFY(!findPopup() || !findPopup()->isVisible());
}

void TestQueryCompleter::keysFallThroughWhileThePopupIsHidden()
{
    // The filter is application-wide, so proving it does nothing with the popup
    // down is what keeps it from breaking the rest of the application.
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);

    if (QListView *popup = findPopup())
        popup->hide();

    QLineEdit other;
    other.show();
    QVERIFY(QTest::qWaitForWindowExposed(&other));
    other.setFocus();

    bool ran = false;
    connect(&other, &QLineEdit::returnPressed, &other, [&ran]() { ran = true; });

    QTest::keyClicks(&other, QStringLiteral("hello"));
    QTest::keyClick(&other, Qt::Key_Return);

    QCOMPARE(other.text(), QStringLiteral("hello"));
    QVERIFY(ran);
}

void TestQueryCompleter::arrowNavigationDoesNotRecurse()
{
    // QCoreApplication::sendEvent re-runs application-level event filters, so a
    // filter that forwards the key it just claimed to another widget is handed
    // the same key back. With the popup still visible the guard still passes and
    // it forwards again: unbounded recursion, and the process dies on the stack
    // rather than on any assertion. Reaching the end of this test is the check.
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);

    QTest::keyClicks(&edit, QStringLiteral("t"));
    QVERIFY(findPopup() && findPopup()->isVisible());

    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Down);
    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Down);

    // And navigation actually moved, so the fix is not "swallow the key".
    QListView *popup = findPopup();
    QVERIFY(popup);
    QVERIFY(popup->currentIndex().isValid());
    QCOMPARE(popup->currentIndex().row(), 1);
}

void TestQueryCompleter::returnRunsTheQueryOnceCompletionIsDone()
{
    // The second half of the user's report: with the query finished, Return has
    // to reach returnPressed and run it. A popup left visible over a completed
    // term swallows Return forever, and the query can never be run from the
    // keyboard at all.
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);
    completer.setTags({ QStringLiteral("unread"), QStringLiteral("inbox") });

    bool ran = false;
    connect(&edit, &QLineEdit::returnPressed, &edit, [&ran]() { ran = true; });

    // Drive the whole chain the way the user does: prefix, accept, value, accept.
    QTest::keyClicks(&edit, QStringLiteral("t"));
    QVERIFY(findPopup() && findPopup()->isVisible());
    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Tab);
    QCOMPARE(edit.text(), QStringLiteral("tag:"));

    QTest::keyClicks(&edit, QStringLiteral("un"));
    QVERIFY(findPopup() && findPopup()->isVisible());
    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Tab);
    QCOMPARE(edit.text(), QStringLiteral("tag:unread"));

    // The query is complete. Return must now run it, not be eaten.
    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Return);
    QVERIFY(ran);
}

void TestQueryCompleter::returnRunsTheQueryAfterAMouseAccept()
{
    // The user builds the whole query with the mouse, which never goes through
    // the key filter, and then Return does not run it. Clicking a row is what
    // QCompleter reports as activated(), so drive that and then press Return
    // exactly as the user does.
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);
    completer.setTags({ QStringLiteral("unread"), QStringLiteral("inbox") });

    bool ran = false;
    connect(&edit, &QLineEdit::returnPressed, &edit, [&ran]() { ran = true; });

    QTest::keyClicks(&edit, QStringLiteral("t"));
    QListView *popup = findPopup();
    QVERIFY(popup && popup->isVisible());

    // Click the "tag:" row.
    const QModelIndex prefixRow = popup->model()->index(0, 0);
    QVERIFY(prefixRow.isValid());
    popup->setCurrentIndex(prefixRow);
    QTest::mouseClick(popup->viewport(), Qt::LeftButton, Qt::NoModifier,
                      popup->visualRect(prefixRow).center());
    QCOMPARE(edit.text(), QStringLiteral("tag:"));

    // Then click a tag value in the popup the accept chained open.
    popup = findPopup();
    QVERIFY(popup && popup->isVisible());
    const QModelIndex valueRow = popup->model()->index(0, 0);
    QVERIFY(valueRow.isValid());
    popup->setCurrentIndex(valueRow);
    QTest::mouseClick(popup->viewport(), Qt::LeftButton, Qt::NoModifier,
                      popup->visualRect(valueRow).center());
    QCOMPARE(edit.text(), QStringLiteral("tag:unread"));

    // The query is complete and built entirely with the mouse. Return runs it.
    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Return);
    QVERIFY(ran);
}

void TestQueryCompleter::returnRunsTheQueryWhenThePopupMatchesNothing()
{
    // A query the user finished by hand. The bar is mid-token, so the popup is
    // still up, but nothing in it matches what was typed. Return must run the
    // query: there is no completion to accept, and accepting the first row of
    // an unrelated list would rewrite the query the user just wrote.
    Config config;
    QLineEdit edit;
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);
    completer.setTags({ QStringLiteral("unread"), QStringLiteral("inbox") });

    bool ran = false;
    connect(&edit, &QLineEdit::returnPressed, &edit, [&ran]() { ran = true; });

    // "zzz" matches no tag, so the popup has nothing to offer for it.
    QTest::keyClicks(&edit, QStringLiteral("tag:zzz"));

    QTest::keyClick(keyboardTarget(&edit), Qt::Key_Return);

    QCOMPARE(edit.text(), QStringLiteral("tag:zzz"));
    QVERIFY(ran);
}

void TestQueryCompleter::theDescriptionSurvivesAModestPopupWidth()
{
    // The delegate lends the description whatever the value does not need, up
    // to 65% of the row. Under the previous even split the longest built-in
    // description needed a ~650px popup to survive; it now needs ~500px, which
    // is the difference between the column working at an ordinary window size
    // and being decorative.
    //
    // 550px is chosen to sit inside that band: the current rule paints the text
    // in full there, an even split cannot. A width outside the band would pass
    // against both rules and prove nothing.
    //
    // The delegate is private to the .cpp, so this renders the real popup and
    // reads the pixels back rather than reaching for the class: whether the text
    // is legible on screen is a painting question, not an arithmetic one.
    Config config;
    QLineEdit edit;
    edit.resize(550, edit.sizeHint().height());
    edit.show();
    QVERIFY(QTest::qWaitForWindowExposed(&edit));
    edit.setFocus();
    QueryCompleter completer(&edit, config);

    QTest::keyClicks(&edit, QStringLiteral("path"));
    QListView *popup = findPopup();
    QVERIFY(popup && popup->isVisible());
    QVERIFY(QTest::qWaitForWindowExposed(popup));

    // "path:" carries the longest built-in description, so it is the row that
    // fails first if the column is starved.
    const QModelIndex row = popup->model()->index(0, 0);
    QVERIFY(row.isValid());
    QCOMPARE(row.data(Qt::DisplayRole).toString(), QStringLiteral("path:"));

    const QRect rect = popup->visualRect(row);
    QVERIFY(rect.isValid());
    QPixmap shot = popup->viewport()->grab(rect);
    QVERIFY(!shot.isNull());
    const QImage image = shot.toImage();

    // Measure how much of the row carries ink, then compare that against the
    // width the description needs when it is NOT elided.
    //
    // "Something was drawn" is too weak a check: the previous even-split rule
    // also drew the description, just cut down to an ellipsis, so a blank-or-not
    // test passes against the very code this replaces. What distinguishes the
    // two is whether the full text fits, which is a width comparison.
    const QRgb background = image.pixel(image.width() - 2, image.height() / 2);
    int rightmostInk = -1;
    int leftmostInkAfterValue = image.width();
    for (int x = 0; x < image.width(); ++x) {
        for (int y = 0; y < image.height(); ++y) {
            if (image.pixel(x, y) != background) {
                rightmostInk = qMax(rightmostInk, x);
                break;
            }
        }
    }
    QVERIFY2(rightmostInk >= 0, "the row rendered entirely blank");

    // The description is right-aligned, so the ink running to the right edge is
    // the description itself. Walk left from there over the contiguous run to
    // find how wide it was actually painted.
    int x = rightmostInk;
    int gapRun = 0;
    while (x > 0 && gapRun < 8) {
        bool column = false;
        for (int y = 0; y < image.height(); ++y) {
            if (image.pixel(x, y) != background) {
                column = true;
                break;
            }
        }
        gapRun = column ? 0 : gapRun + 1;
        if (column)
            leftmostInkAfterValue = x;
        --x;
    }

    const QFontMetrics metrics(popup->font());
    const QString description = popup->model()->index(0, 1).data().toString();
    QCOMPARE(description, QStringLiteral("directory below the Maildir root"));
    const int painted = rightmostInk - leftmostInkAfterValue;
    const int needed = metrics.horizontalAdvance(description);

    // Allow a little slack for antialiasing at the glyph edges.
    QVERIFY2(painted >= needed - 4,
             qPrintable(QStringLiteral("description elided: painted %1px of the "
                                       "%2px it needs")
                            .arg(painted).arg(needed)));
}

QTEST_MAIN(TestQueryCompleter)
#include "test_querycompleter.moc"