1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
|
#include <QtTest>
#include "htmlbuilder.h"
class TestHtmlBuilder : public QObject
{
Q_OBJECT
private slots:
void escapesPlainText();
void preservesHtmlBodyWhenHtmlRequested();
void marksQuotedLines();
void plainTextScriptTagIsNeutralised();
void buildsThreadWithAllMessages();
void collapsedMessageShowsStubOnly();
void threadNamespacesCidUrls();
// Adversarial additions.
void namespacesUnquotedCidAttribute();
void namespacesCaseInsensitiveAttributeName();
void namespacesCidInBackgroundAttribute();
void namespacesCidInInlineStyleUrl();
void namespacesCidInStyleBlock();
void namespacesMultipleCidRefsOnOneLine();
void namespacesWhitespaceAroundEquals();
};
void TestHtmlBuilder::escapesPlainText()
{
ParsedMessage msg;
msg.ok = true;
msg.plainBody = QStringLiteral("a < b & c > d");
const QString html = HtmlBuilder::build(msg, HtmlBuilder::ForcePlain);
QVERIFY(html.contains(QStringLiteral("a < b & c > d")));
}
void TestHtmlBuilder::preservesHtmlBodyWhenHtmlRequested()
{
ParsedMessage msg;
msg.ok = true;
msg.htmlBody = QStringLiteral("<p>hello</p>");
const QString html = HtmlBuilder::build(msg, HtmlBuilder::PreferHtml);
QVERIFY(html.contains(QStringLiteral("<p>hello</p>")));
}
void TestHtmlBuilder::marksQuotedLines()
{
ParsedMessage msg;
msg.ok = true;
msg.plainBody = QStringLiteral("reply\n> quoted\nend");
const QString html = HtmlBuilder::build(msg, HtmlBuilder::ForcePlain);
QVERIFY(html.contains(QStringLiteral("class=\"quote\"")));
}
void TestHtmlBuilder::plainTextScriptTagIsNeutralised()
{
ParsedMessage msg;
msg.ok = true;
msg.plainBody = QStringLiteral("<script>alert(1)</script>");
const QString html = HtmlBuilder::build(msg, HtmlBuilder::ForcePlain);
// Escaped, not embedded. (JavaScript is also disabled at the profile level,
// so this is the second of two independent defences.)
QVERIFY(!html.contains(QStringLiteral("<script>")));
QVERIFY(html.contains(QStringLiteral("<script>")));
}
void TestHtmlBuilder::buildsThreadWithAllMessages()
{
ThreadRenderItem first;
first.message.ok = true;
first.message.subject = QStringLiteral("First");
first.message.from = QStringLiteral("Alice");
first.message.plainBody = QStringLiteral("first body");
first.expanded = true;
ThreadRenderItem second;
second.message.ok = true;
second.message.subject = QStringLiteral("Second");
second.message.from = QStringLiteral("Bob");
second.message.plainBody = QStringLiteral("second body");
second.expanded = true;
const QString html =
HtmlBuilder::buildThread({ first, second }, HtmlBuilder::ForcePlain);
QVERIFY(html.contains(QStringLiteral("first body")));
QVERIFY(html.contains(QStringLiteral("second body")));
// Each message is its own section, so per-message CSS and anchors work.
QCOMPARE(html.count(QStringLiteral("class=\"message\"")), 2);
}
void TestHtmlBuilder::collapsedMessageShowsStubOnly()
{
ThreadRenderItem item;
item.message.ok = true;
item.message.from = QStringLiteral("Carol");
item.message.subject = QStringLiteral("Old news");
item.message.plainBody = QStringLiteral("secret body text");
item.expanded = false;
const QString html =
HtmlBuilder::buildThread({ item }, HtmlBuilder::ForcePlain);
// Unmatched messages collapse to a one-line stub; the body is not emitted.
QVERIFY(html.contains(QStringLiteral("Carol")));
QVERIFY(!html.contains(QStringLiteral("secret body text")));
QVERIFY(html.contains(QStringLiteral("class=\"stub\"")));
}
void TestHtmlBuilder::threadNamespacesCidUrls()
{
// Two messages in one document may both reference cid:logo@x. Without
// namespacing, the second would show the first's image.
ThreadRenderItem first;
first.message.ok = true;
first.message.htmlBody =
QStringLiteral("<img src=\"cid:logo@example.org\">");
first.expanded = true;
first.cidPrefix = QStringLiteral("m0");
ThreadRenderItem second;
second.message.ok = true;
second.message.htmlBody =
QStringLiteral("<img src=\"cid:logo@example.org\">");
second.expanded = true;
second.cidPrefix = QStringLiteral("m1");
const QString html =
HtmlBuilder::buildThread({ first, second }, HtmlBuilder::PreferHtml);
QVERIFY(html.contains(QStringLiteral("cid:m0!logo@example.org")));
QVERIFY(html.contains(QStringLiteral("cid:m1!logo@example.org")));
// The bare form must not survive, or it would resolve ambiguously.
QVERIFY(!html.contains(QStringLiteral("\"cid:logo@example.org\"")));
}
void TestHtmlBuilder::namespacesUnquotedCidAttribute()
{
// <img src=cid:logo@example.org> is valid HTML. An unquoted reference
// that survives un-namespaced would resolve against the WRONG message's
// parts map (or none), so it must be rewritten too.
const QString html = HtmlBuilder::namespaceCids(
QStringLiteral("<img src=cid:logo@example.org>"), QStringLiteral("m0"));
QVERIFY(html.contains(QStringLiteral("cid:m0!logo@example.org")));
QVERIFY(!html.contains(QStringLiteral("src=cid:logo@example.org")));
}
void TestHtmlBuilder::namespacesCaseInsensitiveAttributeName()
{
const QString html = HtmlBuilder::namespaceCids(
QStringLiteral("<img SRC = \"cid:logo@example.org\">"), QStringLiteral("m0"));
QVERIFY(html.contains(QStringLiteral("cid:m0!logo@example.org")));
}
void TestHtmlBuilder::namespacesCidInBackgroundAttribute()
{
// HTML email frequently sets background images via the background=
// attribute on <table>/<td>/<body>.
const QString html = HtmlBuilder::namespaceCids(
QStringLiteral("<table background=\"cid:bg@example.org\">"),
QStringLiteral("m0"));
QVERIFY(html.contains(QStringLiteral("cid:m0!bg@example.org")));
}
void TestHtmlBuilder::namespacesCidInInlineStyleUrl()
{
const QString html = HtmlBuilder::namespaceCids(
QStringLiteral("<div style=\"background-image:url(cid:bg@example.org)\">"),
QStringLiteral("m0"));
QVERIFY(html.contains(QStringLiteral("cid:m0!bg@example.org")));
}
void TestHtmlBuilder::namespacesCidInStyleBlock()
{
const QString html = HtmlBuilder::namespaceCids(
QStringLiteral("<style>.logo{background:url('cid:bg@example.org')}</style>"),
QStringLiteral("m0"));
QVERIFY(html.contains(QStringLiteral("cid:m0!bg@example.org")));
}
void TestHtmlBuilder::namespacesMultipleCidRefsOnOneLine()
{
// Guards against a greedy [^"']+ eating past the first closing quote.
const QString html = HtmlBuilder::namespaceCids(
QStringLiteral("<img src=\"cid:a@x\"><img src=\"cid:b@x\">"),
QStringLiteral("m0"));
QVERIFY(html.contains(QStringLiteral("cid:m0!a@x")));
QVERIFY(html.contains(QStringLiteral("cid:m0!b@x")));
// A greedy [^"']+ would eat past the first closing quote and swallow the
// second tag's markup into the first cid value; guard against that by
// requiring the first tag to close immediately after its own value.
QVERIFY(html.contains(QStringLiteral("cid:m0!a@x\"><img")));
}
void TestHtmlBuilder::namespacesWhitespaceAroundEquals()
{
const QString html = HtmlBuilder::namespaceCids(
QStringLiteral("<img src\n = \n\"cid:logo@example.org\">"),
QStringLiteral("m0"));
QVERIFY(html.contains(QStringLiteral("cid:m0!logo@example.org")));
}
QTEST_MAIN(TestHtmlBuilder)
#include "test_htmlbuilder.moc"
|
