aboutsummaryrefslogtreecommitdiffstats
path: root/src/savequerydialog.h
diff options
context:
space:
mode:
authorDanilo M. <danix@danix.xyz>2026-08-17 13:49:08 +0200
committerDanilo M. <danix@danix.xyz>2026-08-17 13:49:08 +0200
commit435a41c8476a4e94f28ad7730351498465194454 (patch)
tree0acd8c175caa24a021c57f701394680e21c4e3dd /src/savequerydialog.h
parentabf56abd167109f50e0ddb06e1baf92192174cd7 (diff)
downloadqtmaildir-435a41c8476a4e94f28ad7730351498465194454.tar.gz
qtmaildir-435a41c8476a4e94f28ad7730351498465194454.zip
fix(ui): drop the browser's own actions from the message pane menu
The pane's context menu started from QWebEngineView::createStandardContextMenu() and kept it whole, so it offered Back, Forward, Reload and Save page. None of them can apply: every message is rendered with setHtml() from memory, so there is no history to go back to and nothing to reload, and the request interceptor blocks everything by default. They were inert as well as meaningless. removeBrowserActions() matches on the QAction pointer returned by page->action(), never on the entry's text, which is translated: a text match would work in English and fail in every other locale, which is a defect no test written in English would catch. Removing entries also strands separators at the edges or doubles them up, which reads as a menu that lost something, so the filter sweeps them; Qt offers nothing for this. View source is deliberately NOT filtered. It was removed with the other four at first, which was an overreach: the user asked for four and view-source has a real document and a real use. Chromium's own entry cannot work here either, since it navigates to view-source:<url> and MessagePage refuses that, so backlog item 113 implements it as our own plain-text dialog. The test builds a menu by hand, which is right for testing the filter and proves nothing about what Chromium's real menu contains. That limit is stated at the test, and is why it does not assert on SelectAll: the real menu has never offered it, verified by hand against a build with this filter reverted (backlog item 117). Backlog item 100.
Diffstat (limited to 'src/savequerydialog.h')
0 files changed, 0 insertions, 0 deletions