aboutsummaryrefslogtreecommitdiffstats
path: root/src/querycompleter.h
diff options
context:
space:
mode:
authorDanilo M. <danix@danix.xyz>2026-08-04 20:05:01 +0200
committerDanilo M. <danix@danix.xyz>2026-08-04 20:05:01 +0200
commit8485283bbc30c886e28722516dc6f0b11c3bf82d (patch)
tree1caf649b37b8ac693991f4bdf6d12247f9a0eefa /src/querycompleter.h
parentbd1b907ba22464bb869bcc10cc9327ed74c44791 (diff)
downloadqtmaildir-8485283bbc30c886e28722516dc6f0b11c3bf82d.tar.gz
qtmaildir-8485283bbc30c886e28722516dc6f0b11c3bf82d.zip
fix(sync): count unsynced edits as net state, not as writes
Item 28, reported by the user: open a thread, let the automatic mark-read remove `unread`, then press Ctrl+U to put it back. The indicator read "2 unsynced change(s)" with the mail store exactly where it started. The counter incremented per confirmed write and never decremented, so any add-then-remove of the same tag inflated it. Mark-read is simply the path that fires without being asked, which is why it surfaced there. The user's call was net state: an edit and its inverse are zero outstanding changes, because what the indicator answers is whether quitting now would strand work. A QHash keyed "<messageId>\n<tag>" replaces the int, and a pair that reverts is erased rather than stored with the new direction, so the map cannot grow without bound across a long session of tagging and untagging. Keyed per (message, tag) rather than per message: removing `unread` and adding `flagged` on one message are independent changes and must not cancel each other. A change carrying no message ids cannot be netted against anything and is counted separately, since dropping it would understate the indicator, which is the direction that costs work. Both properties item 18 established still hold: a successful sync clears everything, a failed one clears nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'src/querycompleter.h')
0 files changed, 0 insertions, 0 deletions