diff options
| author | Danilo M. <danix@danix.xyz> | 2026-08-13 16:21:42 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-08-13 16:21:42 +0200 |
| commit | 0422205803c8f6980a447fdaa1dc270a486970cd (patch) | |
| tree | af9d8b005ad5ffae91860dfdadf727ce578fb60f /src/nmraii.h | |
| parent | 3b771d03f2df572de29af3156817de3cb7ef6bef (diff) | |
| download | qtmaildir-0422205803c8f6980a447fdaa1dc270a486970cd.tar.gz qtmaildir-0422205803c8f6980a447fdaa1dc270a486970cd.zip | |
fix(rules): save the window size on Cancel and Save, not only on X
The geometry was saved from closeEvent, and neither dialog button sends
one: Cancel calls reject(), Save calls accept(), and only the window
manager's X button produces a QCloseEvent. So the size and the column
widths were kept for the one route out of three that a user almost never
takes, and a resize followed by Cancel came back forgotten.
The save moves to a done(int) override, which both buttons funnel
through and which QWidget::close() also reaches.
The test that covered this passed against the bug because it asserted
with close(). It now drives all three routes rather than trusting one to
stand for the others, and shows the dialog before the close leg:
close() on a widget that was never visible returns early without
reaching done(), so that assertion would otherwise prove nothing.
Both traps recorded in CLAUDE.md, since neither is specific to this
dialog.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'src/nmraii.h')
0 files changed, 0 insertions, 0 deletions
