diff options
| author | Danilo M. <danix@danix.xyz> | 2026-08-20 18:26:37 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-08-20 18:26:37 +0200 |
| commit | d492192b7a9f682dac4a530a5a68ed74f006ddc2 (patch) | |
| tree | 8d344940e39bcf5c366957f1089c43f8f6e8269e /src/markdownrenderer.h | |
| parent | 8fc28de18f903e4bc9d9777589edc819ed9ea996 (diff) | |
| download | qtmaildir-d492192b7a9f682dac4a530a5a68ed74f006ddc2.tar.gz qtmaildir-d492192b7a9f682dac4a530a5a68ed74f006ddc2.zip | |
fix(compose): correct the header's attribution and harden three tests, item 123
The header still credited CMARK_OPT_SAFE after the .cpp comment and the test
were corrected, which left the wrong mechanism named in the file
MessageBuilder's author will actually read.
Three test weaknesses, each measured rather than assumed. The accented-text
test survived a SYMMETRIC latin-1 mutation, since the round trip cancels for
codepoints under U+0100, so it now carries a character latin-1 cannot
represent. The tasklist test asserted on the bare word "checked", which
ordinary prose would satisfy, and now asserts the attribute. And the
extension registration is wrapped in a function-local static: cmark-gfm's
registry has no once-guard, and this project has a worker thread, so the
first call racing itself would tear the registry rather than crash cleanly.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015muoUo2GdxmBDSp5vjYcbE
Diffstat (limited to 'src/markdownrenderer.h')
| -rw-r--r-- | src/markdownrenderer.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/markdownrenderer.h b/src/markdownrenderer.h index 80c52bf..6373fd9 100644 --- a/src/markdownrenderer.h +++ b/src/markdownrenderer.h @@ -32,7 +32,9 @@ namespace MarkdownRenderer { /// /// Three extensions are enabled (autolink, strikethrough, tasklist) and /// tables are deliberately not. Raw HTML in the input is suppressed by -/// CMARK_OPT_SAFE. +/// cmark-gfm's safe mode, which is the DEFAULT in 0.29 and is not the +/// CMARK_OPT_SAFE flag (a no-op); see markdownrenderer.cpp for the +/// measurement. The requirement is that CMARK_OPT_UNSAFE is never set. QString toHtml(const QString &markdown); } // namespace MarkdownRenderer |
