refactor(ui): extract the busy indicator into a widget, item 134

The status bar's sync bar was a bare QProgressBar configured inline in
MainWindow, and item 123's send popup needs the same thing again. It also
needs the half MainWindow does not use: the popup drains a determinate bar
through its cancellable countdown and switches THE SAME widget to
indeterminate when send_command starts and the duration stops being
knowable. Building that inline a second time is what this removes.

BusyIndicator carries both modes. setBusy() resets the range as well as the
visibility, so the switch out of the countdown cannot leave the bar drawing
its last fraction, and setProgress() treats a total of zero as busy rather
than passing it through: setRange(0, 0) IS the indeterminate range, so a
zero total would otherwise hand the caller an animating bar while it
believed it had drawn an empty one.

Only the bar is extracted, not the status label the backlog row mentions
beside it. m_statusLabel has 34 uses across MainWindow for transient
messages, selection counts and sync phases; it belongs to the window rather
than to the indicator, and the send popup owns its own phase text.

The hidden-on-construction test needs a shown parent, which cost a mutation
to find. Measured against a standalone Qt program: a parentless widget
reports isVisible() false and isHidden() true whether or not hide() was ever
called, so both obvious assertions passed against a constructor with the
hide() deleted. What differs is WA_WState_ExplicitShowHide, and the
behaviour it produces appears only once a parent is shown, which is how the
status bar holds this widget.

All five mutations checked and killed: the zero-total guard, the range reset
in setBusy(), the value clamp, the show() in setProgress() and the hide() in
the constructor.

1 files changed, 53 insertions, 0 deletions

diff --git a/src/busyindicator.h b/src/busyindicator.h
new file mode 100644
index 0000000..14ad6ee
--- /dev/null
+++ b/src/busyindicator.h
@@ -0,0 +1,53 @@
+/*
+ * qtmaildir - a Qt6 mail client for notmuch-indexed Maildirs
+ * Copyright (C) 2026 Danilo M. <danix@danix.xyz>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#pragma once
+
+#include <QProgressBar>
+
+// A progress bar that carries both of the modes this application needs, so the
+// two places that show one do not each configure a bare QProgressBar. The
+// status bar's sync indicator is indeterminate, because mbsync reports no
+// percentage; the composer's send popup drains a determinate bar through its
+// undo countdown and then switches THE SAME widget to indeterminate when the
+// command starts. That switch is why one class exists rather than two.
+//
+// Deliberately no label. MainWindow's status text is m_statusLabel, which is
+// the window's and carries far more than this widget's state, and the send
+// popup's phase text belongs to the popup. A label here would be a third
+// owner of status text.
+class BusyIndicator : public QProgressBar
+{
+    Q_OBJECT
+
+public:
+    explicit BusyIndicator(QWidget *parent = nullptr);
+
+    // Indeterminate: an animating bar meaning "working, duration unknown".
+    // setRange(0, 0) is what Qt reads as indeterminate, and a bar left in that
+    // range shows no fraction however many times setValue() is called.
+    void setBusy(bool busy);
+
+    // Determinate: a real fraction. Passing a total of 0 or less would be a
+    // silent request for the indeterminate range, so it is treated as busy
+    // instead of quietly drawing an empty bar forever.
+    void setProgress(int value, int total);
+
+    bool isBusy() const;
+    bool isDeterminate() const;
+};