aboutsummaryrefslogtreecommitdiffstats
path: root/docs/superpowers
diff options
context:
space:
mode:
authorDanilo M. <danix@danix.xyz>2026-11-16 12:29:13 +0100
committerDanilo M. <danix@danix.xyz>2026-11-16 12:29:13 +0100
commitafa1fb3d58679e27e3cd7484ac049bd7ca71de59 (patch)
tree2e1033ebc45c68c0b3c5db445ba4765ba458839c /docs/superpowers
parente63ed319283f2d7a2e5b6a44ace98e76a77da68c (diff)
downloadqtmaildir-afa1fb3d58679e27e3cd7484ac049bd7ca71de59.tar.gz
qtmaildir-afa1fb3d58679e27e3cd7484ac049bd7ca71de59.zip
docs: file item 215, three actions lost their theme icons
mail-archive, edit-undelete and mail-inbox exist in no installed theme any more, so Archive, Restore and the Inbox filter show as text and three test_mainwindow cases fail on master with no code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Diffstat (limited to 'docs/superpowers')
-rw-r--r--docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md30
1 files changed, 30 insertions, 0 deletions
diff --git a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md
index 262f0c5..cc74be9 100644
--- a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md
+++ b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md
@@ -152,6 +152,7 @@ taking that too literally.
| 212 | A rule edit reaches only new mail; applying it to the backlog is a hand-typed `notmuch tag` | workflow | M | open, designed: `specs/2026-10-31-rule-apply-and-archive-design.md` Part A. Apply saves, counts what would change, confirms with the count (a new documented exception to the no-confirmation rule), writes through `applyTags` for exact undo |
| 213 | A rule removing `inbox` is skipped whole by the hook, so promo mail arrives untagged | defect | S-M | open, designed: same spec, Part B. Optional per-rule `allow_archive`, both readers, no version bump; `unread` stays refused; the dialog warns about rules the hook will skip |
| 214 | A rule can tag mail spam but cannot move it to the spam or trash folder | workflow | M | **done** 2026-11-16, unreleased, on `rule-move`. Spec: `specs/2026-11-16-rule-move-design.md`. The nesting assumption held: `notmuch new --no-hooks` runs inside `post-new`. Review fixes: a bad `move` is kept raw rather than dropped (the rule-id lesson), a nested account without the role resolves to itself, and `_quote` doubles quotes (it never matched an id holding one, on the carve-out path too). Section in the closed file. Original note: Optional `move` field, `spam` or `trash` (an account role, never a folder name), both readers, no version bump; the hook moves on arrival, strips `inbox`, keeps `unread`; Apply (212) inherits it later. First task: verify `notmuch new` can run inside `post-new` |
+| 215 | Archive, Restore and the Inbox filter lost their icons, and three icon tests fail | defect | S | open, 2026-11-16, found by the full suite while building 214. The icon names (`mail-archive`, `edit-undelete`, `mail-inbox`) exist in no installed theme: not candy-icons, and not breeze-dark, breeze, Adwaita or hicolor, which it inherits. Breeze was last updated 2026-11-05/11. Needs fallback names, the second slot `kThemeIcons` already has; the tests also read the DESKTOP theme, so the suite's result depends on the machine |
| 73 | This backlog is past four thousand lines | maintenance | S | **done** 2026-08-13; 5056 lines to 578, closed sections moved to `2026-08-03-post-0.1.0-usability-closed.md` |
| 74 | "Searching..." keeps claiming a query is running while rows are already arriving | feedback | XS | **done** 2026-08-15, unreleased. The status-bar half only: the bar now counts threads per batch. The cold-cache delay itself was measured in 2026-08-11 and is not fixable here |
| 75 | The tagging rules window forgets its size and its column widths | persistence | S | **done** 2026-08-13, shipped in 0.17.0. The window-kind question is left open, see the closed-items file |
@@ -1734,3 +1735,32 @@ applied without the removal. The rules dialog says nothing about it.
**Constraints.** A rule-format change: both readers, both suites, and the hand
round trip under "Changing the rule format". The hook runs every ten minutes
on real mail.
+
+## 215. Archive, Restore and the Inbox filter lost their icons
+
+**Observed (2026-11-16, while building 214).** Three `test_mainwindow` cases
+fail on master: `everyActionCarriesAnIcon` ("archive, restore have no icon"),
+`noTwoActionsShareAnIcon` (39 of 41 actions had an icon), and
+`everyBuiltinFilterButtonCarriesAnIconAndItsText` ("filter 'inbox' was given no
+themed icon name"). In the running application the same three show as text
+only.
+
+**Cause.** Verified on this machine, not assumed. `kThemeIcons` in
+`mainwindow.cpp` asks for `mail-archive` and `edit-undelete` with no fallback
+name, and the filter-button table asks for `mail-inbox`. qt6ct sets the theme
+to candy-icons, which inherits breeze-dark, Adwaita and hicolor; none of those
+four, nor breeze, carries any of the three names. Breeze's directories were
+last updated on 2026-11-05 and 2026-11-11, which fits the tests having passed
+before.
+
+**Approach.** Give each a fallback that the installed themes DO carry, through
+the second name `kThemeIcons` already supports (the filter table needs the same
+pair shape). Check each candidate with `find -L` across the theme and its
+`Inherits=` chain, not from memory, and keep the no-duplicate-icons rule.
+
+**Constraints.** The tests read the desktop's real theme (qt6ct under
+`QT_QPA_PLATFORMTHEME`), so whether they pass depends on the machine's icon
+packages, which is how a system update broke them with no code change. Item 199
+(ship our own icon set) would remove that dependency for the panes, but the
+chrome deliberately stays on the system theme, so this item stands on its own.
+