path: root/tests/test_remote.py

# sb-builder - self-checks for the remote helper
# Copyright (C) 2026 Danilo M. <danix@danix.xyz>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License version 2 as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with this program; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

"""Run: python3 -m unittest discover -s tests"""

import contextlib
import fcntl
import functools
import hashlib
import http.server
import importlib.machinery
import importlib.util
import io
import json
import os
import shutil
import sqlite3
import sys
import tempfile
import threading
import time
import unittest
from unittest import mock

SCRIPT = os.path.join(os.path.dirname(os.path.abspath(__file__)), "..", "remote", "sbb-remote")
_loader = importlib.machinery.SourceFileLoader("sbb_remote", SCRIPT)
sbb = importlib.util.module_from_spec(importlib.util.spec_from_loader("sbb_remote", _loader))
_loader.exec_module(sbb)


class Base(unittest.TestCase):
    def setUp(self):
        self.tmp = tempfile.mkdtemp()
        self.addCleanup(shutil.rmtree, self.tmp)
        conf = os.path.join(self.tmp, "config.toml")
        with open(conf, "w") as f:
            f.write(f'state_dir = "{self.tmp}"\n'
                    f'repo_dir = "{self.tmp}/repo"\n'
                    f'slackrepo_db = "{self.tmp}/slackrepo.sqlite3"\n'
                    f'hintdir = "{self.tmp}/hints"\n'
                    f'genreprc = "{self.tmp}/genreprc"\n')
        patcher = mock.patch.dict(os.environ, {"SBB_CONFIG": conf})
        patcher.start()
        self.addCleanup(patcher.stop)
        self.cfg = sbb.load_config()
        os.makedirs(os.path.join(self.tmp, "jobs"))

    def make_job(self, argv, **meta):
        jid = "20260101-000000-test"
        d = os.path.join(self.tmp, "jobs", jid)
        os.mkdir(d)
        sbb.write_meta(d, {"id": jid, "kind": "test", "args": [], "argv": argv,
                           "status": "starting", "created": time.time(), **meta})
        open(os.path.join(d, "log"), "wb").close()
        return jid, d

    def make_pkg(self, path, info="", hint=None, desc=None):
        d = os.path.join(self.cfg["repo_dir"], path)
        pkg = os.path.basename(path)
        os.makedirs(d, exist_ok=True)
        open(os.path.join(d, pkg + ".SlackBuild"), "w").close()
        with open(os.path.join(d, pkg + ".info"), "w") as f:
            f.write(info)
        if desc:
            with open(os.path.join(d, "slack-desc"), "w") as f:
                f.write(f"{pkg}: {pkg} ({desc})\n{pkg}:\n")
        if hint is not None:
            os.makedirs(self.cfg["hintdir"], exist_ok=True)
            with open(os.path.join(self.cfg["hintdir"], pkg + ".hint"), "w") as f:
                f.write(hint)

    def fake_bin(self, name, script):
        bindir = os.path.join(self.tmp, "bin")
        os.makedirs(bindir, exist_ok=True)
        path = os.path.join(bindir, name)
        with open(path, "w") as f:
            f.write("#!/bin/sh\n" + script)
        os.chmod(path, 0o755)
        if bindir not in os.environ["PATH"]:
            patcher = mock.patch.dict(os.environ, {"PATH": bindir + os.pathsep + os.environ["PATH"]})
            patcher.start()
            self.addCleanup(patcher.stop)
        return path

    def hold_lock(self):
        f = open(os.path.join(self.tmp, "lock"), "a")
        fcntl.flock(f, fcntl.LOCK_EX)
        self.addCleanup(f.close)

    def run_main(self, *argv):
        out = io.StringIO()
        with contextlib.redirect_stdout(out):
            rc = sbb.main(list(argv))
        return rc, json.loads(out.getvalue())

    def wait_status(self, d, statuses):
        for _ in range(100):
            if sbb.read_meta(d)["status"] in statuses:
                break
            time.sleep(0.05)
        return sbb.read_meta(d)


class ConfigTest(Base):
    def write(self, text):
        p = os.path.join(self.tmp, "c.toml")
        with open(p, "w") as f:
            f.write(text)
        return p

    def test_missing_file_gives_defaults(self):
        self.assertEqual(sbb.load_config(os.path.join(self.tmp, "nope.toml")), sbb.DEFAULTS)

    def test_override(self):
        self.assertEqual(sbb.load_config(self.write('overlays = ["a"]\n'))["overlays"], ["a"])

    def test_example_matches_defaults(self):
        example = os.path.join(os.path.dirname(SCRIPT), "config.example.toml")
        self.assertEqual(sbb.load_config(example), sbb.DEFAULTS)

    def test_unknown_key(self):
        with self.assertRaisesRegex(sbb.Error, "bogus: unknown key"):
            sbb.load_config(self.write("bogus = 1\n"))

    def test_manifests(self):
        self.assertEqual(sbb.load_config(self.write("[manifests]\nx = \"u{VERSION}\"\n"))["manifests"],
                         {"x": "u{VERSION}"})
        with self.assertRaisesRegex(sbb.Error, "manifests: expected strings"):
            sbb.load_config(self.write("[manifests]\nx = 1\n"))

    def test_wrong_type(self):
        with self.assertRaisesRegex(sbb.Error, "state_dir: expected str"):
            sbb.load_config(self.write("state_dir = 1\n"))


class KindsTest(Base):
    def test_sbpull_argv(self):
        self.assertEqual(sbb.KINDS["sbpull"](self.cfg, ["personal", "--no"]),
                         (["bash", "-c", '. "$1" && sbpull "$2" "$3"', "_",
                           self.cfg["sbpull_script"], "personal", "--no"], {}))

    def test_sbshadow_argv(self):
        self.assertEqual(sbb.KINDS["sbshadow"](self.cfg, ["--yes"]), (["sbshadow", "--yes"], {}))

    def test_slackrepo_argv(self):
        self.make_pkg("misc/nuclei")
        self.make_pkg("personal/foo")
        kind = sbb.KINDS["slackrepo"]
        self.assertEqual(kind(self.cfg, ["update", "--preview", "nuclei", "foo", "nuclei"]),
                         (["slackrepo", "--repo=SBo-danix", "update", "--preview", "nuclei", "foo"], {}))
        self.assertEqual(kind(self.cfg, ["build", "--no-publish", "foo"]),
                         (["slackrepo", "--repo=SBo-danix", "build", "foo"], {"SBB_PUBLISH": "n"}))
        self.assertEqual(kind(self.cfg, ["update"]), (["slackrepo", "--repo=SBo-danix", "update"], {}))

    def test_slackrepo_rejects(self):
        self.make_pkg("misc/nuclei")
        for args in (["install", "nuclei"], ["build"], ["remove"], ["build", "nope"],
                     ["build", "../etc"], ["build", "--force", "nuclei"]):
            with self.subTest(args=args), self.assertRaises(sbb.Error):
                sbb.KINDS["slackrepo"](self.cfg, args)

    def test_publish(self):
        self.assertEqual(sbb.KINDS["publish"](self.cfg, []), (["sb-publish"], {}))
        with self.assertRaises(sbb.Error):
            sbb.KINDS["publish"](self.cfg, ["x"])

    def test_rejects_bad_args(self):
        for kind, args in (("sbpull", ["evil", "--no"]), ("sbpull", ["personal"]),
                           ("sbpull", ["personal", "--force"]), ("sbshadow", []),
                           ("sbshadow", ["--yes", "--no"])):
            with self.subTest(kind=kind, args=args), self.assertRaises(sbb.Error):
                sbb.KINDS[kind](self.cfg, args)

    def test_unknown_kind(self):
        with self.assertRaisesRegex(sbb.Error, "unknown kind"):
            sbb.cmd_job_start(self.cfg, "rm", "-rf", "/")


FLATPAK_INFO = ('PRGNAM="flatpak"\nVERSION="1.16.0"\nHOMEPAGE="https://flatpak.org/"\n'
                'DOWNLOAD="https://example.org/flatpak-1.16.0.tar.xz"\n'
                'MD5SUM="bdf866646fb312a341f84669f625488b"\n'
                'DOWNLOAD_x86_64=""\nMD5SUM_x86_64=""\n'
                'REQUIRES="bubblewrap ostree"\nMAINTAINER="Some One"\nEMAIL="one@example.org"\n')


class HintTextTest(unittest.TestCase):
    def test_swap_forms(self):
        text = ('VERSION="1.2.00"\nDOWNLOAD="https://example.org/build_1200/x-1.2.00.tar.gz"\n'
                'MD5SUM="00001200aa"\nDELREQUIRES="lib1200"\n')
        self.assertEqual(sbb.swap_version(text, "1.2.00", "1.2.15"),
                         'VERSION="1.2.15"\nDOWNLOAD="https://example.org/build_1215/x-1.2.15.tar.gz"\n'
                         'MD5SUM="00001200aa"\nDELREQUIRES="lib1200"\n')

    def test_swap_underscore_as_dash(self):
        text = 'VERSION="2026_07_07"\nDOWNLOAD="https://example.org/2026-07-07.tgz"\n'
        self.assertEqual(sbb.swap_version(text, "2026_07_07", "2026_08_01"),
                         'VERSION="2026_08_01"\nDOWNLOAD="https://example.org/2026-08-01.tgz"\n')

    def test_md5_values_untouched(self):
        text = 'VERSION="4215"\nMD5SUM="aa4215bb \\\n    cc4215dd"\nMD5SUM_x86_64="4215"\n'
        self.assertEqual(sbb.swap_version(text, "4215", "4216"),
                         'VERSION="4216"\nMD5SUM="aa4215bb \\\n    cc4215dd"\nMD5SUM_x86_64="4215"\n')

    def test_tokens_set_drop(self):
        text = 'A="x \\\n    y"\nB=plain\nDOWNLOAD_x86_64=""\n'
        self.assertEqual(sbb.hint_tokens(text, "A"), ["x", "y"])
        self.assertEqual(sbb.hint_tokens(text, "B"), ["plain"])
        self.assertEqual(sbb.hint_tokens(text, "C"), [])
        self.assertEqual(sbb.hint_set(text, "B", "1 2"), 'A="x \\\n    y"\nB="1 2"\nDOWNLOAD_x86_64=""\n')
        self.assertEqual(sbb.hint_set("Z=1", "B", "2"), 'Z=1\nB="2"\n')
        self.assertEqual(sbb.hint_drop(text, r"(?:A|DOWNLOAD\w*)"), "B=plain\n")

    def test_new_hint(self):
        self.assertEqual(sbb.new_hint(FLATPAK_INFO),
                         'VERSION="1.16.0"\nDOWNLOAD="https://example.org/flatpak-1.16.0.tar.xz"\n'
                         'MD5SUM="bdf866646fb312a341f84669f625488b"\n'
                         'DOWNLOAD_x86_64=""\nMD5SUM_x86_64=""\n'
                         '#REQUIRES="bubblewrap ostree"\nARCH="x86_64"\n')
        with self.assertRaisesRegex(sbb.Error, "no VERSION"):
            sbb.new_hint('PRGNAM="x"\n')


class Served:
    """Files of a temp dir over http on localhost, for md5 downloads."""

    def __init__(self, test, files):
        root = os.path.join(test.tmp, "www")
        os.makedirs(root)
        for name, data in files.items():
            with open(os.path.join(root, name), "wb") as f:
                f.write(data)
        handler = functools.partial(http.server.SimpleHTTPRequestHandler, directory=root)
        handler.log_message = lambda *a: None
        self.server = http.server.ThreadingHTTPServer(("127.0.0.1", 0), handler)
        threading.Thread(target=self.server.serve_forever, daemon=True).start()
        test.addCleanup(self.server.server_close)
        test.addCleanup(self.server.shutdown)
        self.url = f"http://127.0.0.1:{self.server.server_port}"


def md5(data):
    return hashlib.md5(data).hexdigest()


class ApplyVersionTest(Base):
    def setUp(self):
        super().setUp()
        self.www = Served(self, {"x-2.0.tgz": b"two", "dep.tgz": b"dep"})
        self.log = []

    def apply(self, text, new, no_dl=False, info=""):
        return sbb.apply_version(text, info, new, no_dl, self.log.append)

    def test_download_refreshes_first_md5_only(self):
        u = self.www.url
        text = (f'VERSION="1.0"\nDOWNLOAD="{u}/x-1.0.tgz \\\n    {u}/dep.tgz"\n'
                'MD5SUM="old1 \\\n    keep2"\nDOWNLOAD_x86_64=""\nMD5SUM_x86_64=""\nARCH="x86_64"\n')
        self.assertEqual(self.apply(text, "2.0"),
                         f'VERSION="2.0"\nDOWNLOAD="{u}/x-2.0.tgz \\\n    {u}/dep.tgz"\n'
                         f'MD5SUM="{md5(b"two")} \\\n    keep2"\nDOWNLOAD_x86_64=""\nMD5SUM_x86_64=""\n'
                         'ARCH="x86_64"\n')
        self.assertEqual(self.log, [f"downloading {u}/x-2.0.tgz"])

    def test_arch_pair_and_unsupported(self):
        u = self.www.url
        text = (f'VERSION="1.0"\nDOWNLOAD="UNSUPPORTED"\nMD5SUM=""\n'
                f'DOWNLOAD_x86_64="{u}/x-1.0.tgz"\nMD5SUM_x86_64="old"\n')
        self.assertIn(f'MD5SUM_x86_64="{md5(b"two")}"', self.apply(text, "2.0"))
        self.assertIn('DOWNLOAD="UNSUPPORTED"\nMD5SUM=""\n', self.apply(text, "2.0"))

    def test_unpinned_hint_pins_from_info(self):
        u = self.www.url
        info = (f'PRGNAM="x"\nVERSION="1.0"\nDOWNLOAD="{u}/x-1.0.tgz"\nMD5SUM="old"\n'
                'DOWNLOAD_x86_64=""\nMD5SUM_x86_64=""\nREQUIRES="a"\n')
        self.assertEqual(self.apply('DELREQUIRES="rust-opt"\n', "2.0", info=info),
                         f'VERSION="2.0"\nDOWNLOAD="{u}/x-2.0.tgz"\nMD5SUM="{md5(b"two")}"\n'
                         'DOWNLOAD_x86_64=""\nMD5SUM_x86_64=""\nARCH="x86_64"\nDELREQUIRES="rust-opt"\n')
        self.assertEqual(self.apply('DELREQUIRES="rust-opt"\n', "2.0", no_dl=True, info=info),
                         'VERSION="2.0"\nARCH="x86_64"\nDELREQUIRES="rust-opt"\nDOWNLOAD="no"\n')

    def test_no_dl(self):
        text = ('VERSION="1.0"\nDOWNLOAD="https://example.org/x-1.0.tgz \\\n    https://example.org/d"\n'
                'MD5SUM="a \\\n    b"\nDOWNLOAD_x86_64="https://example.org/y"\nMD5SUM_x86_64="c"\n'
                'ARCH="x86_64"\n')
        self.assertEqual(self.apply(text, "2.0", no_dl=True),
                         'VERSION="2.0"\nARCH="x86_64"\nDOWNLOAD="no"\n')
        self.assertEqual(self.log, [])

    def test_no_version_no_download(self):
        self.assertEqual(self.apply('VERSION="1.0"\nDOWNLOAD="x"\nMD5SUM="m"\n', None),
                         'VERSION="1.0"\nDOWNLOAD="x"\nMD5SUM="m"\n')

    def test_download_failure_raises(self):
        with self.assertRaises(OSError):
            self.apply(f'VERSION="1.0"\nDOWNLOAD="{self.www.url}/x-1.0.tgz"\nMD5SUM="m"\n', "3.0")


GH = "https://github.com"
# neovim 0.12.4: hint URLs (SBo shapes) and their deps.txt counterparts
NVIM_HINT = [f"{GH}/neovim/neovim/archive/v0.12.4/neovim-0.12.4.tar.gz",
             f"{GH}/luajit/LuaJIT/archive/fbb36bb/LuaJIT-fbb36bb6bfa88716a47c58bcf9ce9f2ef752abac.tar.gz",
             f"{GH}/luvit/luv/releases/download/1.52.1-0/luv-1.52.1-0.tar.gz",
             f"{GH}/lunarmodules/lua-compat-5.3/archive/v0.13/lua-compat-5.3-0.13.tar.gz",
             f"{GH}/tree-sitter/tree-sitter/archive/v0.26.7/tree-sitter-0.26.7.tar.gz",
             "https://www.inf.puc-rio.br/~roberto/lpeg/lpeg-1.1.0.tar.gz",
             f"{GH}/JuliaStrings/utf8proc/archive/v2.11.3/utf8proc-2.11.3.tar.gz"]
NVIM_DEPS = [f"{GH}/luajit/luajit/archive/fbb36bb6bfa88716a47c58bcf9ce9f2ef752abac.tar.gz",
             f"{GH}/luvit/luv/archive/1.52.1-0.tar.gz",
             f"{GH}/lunarmodules/lua-compat-5.3/archive/v0.13.tar.gz",
             f"{GH}/tree-sitter/tree-sitter-c/archive/v0.24.1.tar.gz",
             f"{GH}/tree-sitter/tree-sitter/archive/v0.26.7.tar.gz",
             f"{GH}/neovim/deps/raw/d495ee6f79e7962a53ad79670cb92488abe0b9b4/opt/lpeg-1.1.0.tar.gz",
             f"{GH}/juliastrings/utf8proc/archive/v2.11.3.tar.gz"]


class BundledDepsTest(Base):
    def test_hint_and_manifest_shapes_match_with_equal_versions(self):
        for url in NVIM_HINT[1:]:
            m = sbb._match(url, NVIM_DEPS)
            with self.subTest(url=url):
                self.assertIsNotNone(m)
                self.assertEqual(sbb._url_version(url), sbb._url_version(m))
        self.assertIsNone(sbb._match(NVIM_HINT[0], NVIM_DEPS))
        self.assertEqual([sbb._url_version(u) for u in NVIM_HINT[2:4]], ["1.52.1_0", "0.13"])
        self.assertEqual(sbb._dep_name(NVIM_HINT[5]), "lpeg")

    def test_reconcile(self):
        hint = 'DOWNLOAD="' + " \\\n    ".join(NVIM_HINT[:3] + [f"{GH}/a/gone/archive/v1/gone-1.tar.gz"]) + '"\n'
        deps = "\n".join(f"X_URL {u}\nX_SHA256 ab" for u in NVIM_DEPS).replace("1.52.1-0", "1.53.0-0")
        log = []
        out = sbb.reconcile(hint, deps, log.append)
        self.assertEqual(sbb.hint_tokens(out, "DOWNLOAD"),
                         NVIM_HINT[:2] + [f"{GH}/luvit/luv/archive/1.53.0-0.tar.gz",
                                          f"{GH}/a/gone/archive/v1/gone-1.tar.gz"])
        self.assertEqual(log, ["luv 1.52.1_0 -> 1.53.0_0", "gone no manifest match, left as is",
                               "manifest has 5 deps not in the hint"])
        self.assertIs(sbb.reconcile(hint, deps.replace("1.53.0-0", "1.52.1-0"), log.append), hint)
        with self.assertRaisesRegex(sbb.Error, "no URLs"):
            sbb.reconcile(hint, "moved\n", log.append)

    def test_apply_version_follows_manifest(self):
        www = Served(self, {"x-2.0.tgz": b"two", "dep-0.6.tgz": b"dep11", "keep-3.tgz": b"keep"})
        u, log = www.url, []
        with open(os.path.join(self.tmp, "www", "deps-2.0.txt"), "w") as f:
            f.write(f"DEP_URL {u}/dep-0.6.tgz\nKEEP_URL {u}/keep-3.tgz\n")
        text = (f'VERSION="1.0"\nDOWNLOAD="{u}/x-1.0.tgz \\\n    {u}/dep-0.5.tgz \\\n    {u}/keep-3.tgz"\n'
                'MD5SUM="a \\\n    b \\\n    c"\n')
        out = sbb.apply_version(text, "", "2.0", False, log.append, u + "/deps-{VERSION}.txt")
        self.assertEqual(out, f'VERSION="2.0"\nDOWNLOAD="{u}/x-2.0.tgz \\\n    {u}/dep-0.6.tgz \\\n'
                              f'    {u}/keep-3.tgz"\nMD5SUM="{md5(b"two")} \\\n    {md5(b"dep11")} \\\n    c"\n')
        self.assertEqual(log, [f"manifest {u}/deps-2.0.txt", "dep 0.5 -> 0.6",
                               f"downloading {u}/x-2.0.tgz", f"downloading {u}/dep-0.6.tgz"])
        with self.assertRaises(OSError):  # no deps list at 3.0: the package fails, hint untouched
            sbb.apply_version(text, "", "3.0", False, log.append, u + "/deps-{VERSION}.txt")

    def test_changed_continuation_url_gets_its_md5(self):
        www = Served(self, {"f-2.0.tgz": b"two", "f-2.0-vendor.tgz": b"vendor"})
        u, log = www.url, []
        text = f'VERSION="1.0"\nDOWNLOAD="{u}/f-1.0.tgz \\\n    {u}/f-1.0-vendor.tgz"\nMD5SUM="a \\\n    b"\n'
        self.assertIn(f'MD5SUM="{md5(b"two")} \\\n    {md5(b"vendor")}"',
                      sbb.apply_version(text, "", "2.0", False, log.append))
        self.assertEqual(log, [f"downloading {u}/f-2.0.tgz", f"downloading {u}/f-2.0-vendor.tgz"])


class HintJobsTest(Base):
    def setUp(self):
        super().setUp()
        self.www = Served(self, {"x-2.0.tgz": b"two"})
        self.info = (f'PRGNAM="x"\nVERSION="1.0"\nDOWNLOAD="{self.www.url}/x-1.0.tgz"\nMD5SUM="old"\n'
                     'DOWNLOAD_x86_64=""\nMD5SUM_x86_64=""\nREQUIRES="rust-opt a"\n')
        self.hint = os.path.join(self.cfg["hintdir"], "x.hint")

    def read(self, path):
        with open(path) as f:
            return f.read()

    def run_hint(self, *args):
        out = io.StringIO()
        with contextlib.redirect_stdout(out):
            try:
                sbb.cmd_hint(self.cfg, *args)
                rc = 0
            except sbb.Error:
                rc = 1
        lines = out.getvalue().splitlines()
        self.assertTrue(lines[-1].startswith("SBB-RESULT "))
        return rc, json.loads(lines[-1].split(" ", 1)[1]), lines

    def test_kinds_argv(self):
        self.make_pkg("misc/x", self.info)
        me = [sys.executable, os.path.abspath(sbb.__file__), "_hint"]
        self.assertEqual(sbb.KINDS["hint-update"](self.cfg, ["x=2.0", "--no-dl"]),
                         (me + ["hint-update", "x=2.0", "--no-dl"], {}))
        self.make_pkg("misc/y", self.info)
        self.assertEqual(sbb.KINDS["hint-new"](self.cfg, ["x", "y"]), (me + ["hint-new", "x", "y"], {}))
        self.assertFalse(sbb.signs("hint-update", ["x=2.0"]))

    def test_kinds_reject(self):
        self.make_pkg("misc/x", self.info)
        self.make_pkg("misc/neovim", self.info)
        self.make_pkg("misc/shadowed", self.info)
        os.makedirs(os.path.join(self.cfg["repo_dir"], "misc/shadowed"), exist_ok=True)
        with open(os.path.join(self.cfg["repo_dir"], "misc/shadowed/shadowed.hint"), "w") as f:
            f.write("")
        for kind, args, why in (("hint-update", [], "at least one"),
                                ("hint-update", ["x"], "pkg=version"),
                                ("hint-update", ["x=1;rm"], "bad version"),
                                ("hint-update", ["x=" + "1" * 65], "bad version"),
                                ("hint-update", ["nope=1"], "no such package"),
                                ("hint-update", ["x=1", "x=2"], "twice"),
                                ("hint-update", ["x=1", "--force"], "unknown option"),
                                ("hint-update", ["shadowed=1"], "not managed"),
                                ("hint-new", [], "hint-new <pkg>"),
                                ("hint-new", ["x", "2.0"], "no such package: 2.0"),  # no version any more
                                ("hint-new", ["x", "x"], "twice")):
            with self.subTest(kind=kind, args=args), self.assertRaisesRegex(sbb.Error, why):
                sbb.KINDS[kind](self.cfg, args)
        self.make_pkg("misc/y", self.info, hint="")
        with self.assertRaisesRegex(sbb.Error, "y: hint exists"):
            sbb.KINDS["hint-new"](self.cfg, ["x", "y"])  # one with a hint refuses the whole job

    def test_update_backs_up_and_reports(self):
        self.make_pkg("misc/x", self.info, hint='DELREQUIRES="rust-opt"\n')
        self.make_pkg("misc/y", self.info.replace("x-1.0", "y-1.0"), hint='VERSION="1.0"\n'
                      f'DOWNLOAD="{self.www.url}/y-1.0.tgz"\nMD5SUM="old"\n')
        rc, result, lines = self.run_hint("hint-update", "y=2.0", "x=2.0")
        self.assertEqual(rc, 1)
        self.assertEqual(result["ok"], ["x"])
        self.assertEqual([p for p, _why in result["failed"]], ["y"])
        self.assertIn("x: downloading", "\n".join(lines))
        self.assertIn(md5(b"two"), self.read(self.hint))
        self.assertEqual(self.read(self.hint + ".bak"), 'DELREQUIRES="rust-opt"\n')
        y = os.path.join(self.cfg["hintdir"], "y.hint")
        self.assertIn('MD5SUM="old"', self.read(y))  # failed: left as it was
        self.assertFalse(os.path.exists(y + ".bak"))

    def test_update_without_hint_creates_one(self):
        self.make_pkg("misc/x", self.info)
        os.makedirs(self.cfg["hintdir"])
        with open(self.hint + ".bak", "w") as f:
            f.write("stale")
        rc, result, _ = self.run_hint("hint-update", "x=2.0", "--no-dl")
        self.assertEqual((rc, result), (0, {"ok": ["x"], "failed": []}))
        self.assertEqual(self.read(self.hint), 'VERSION="2.0"\n#REQUIRES="rust-opt a"\nARCH="x86_64"\n'
                                               'DOWNLOAD="no"\n')
        self.assertFalse(os.path.exists(self.hint + ".bak"))  # revert = delete

    def test_new(self):
        self.make_pkg("misc/x", self.info)
        self.make_pkg("misc/y", self.info)
        rc, result, _ = self.run_hint("hint-new", "x", "y")
        self.assertEqual((rc, result), (0, {"ok": ["x", "y"], "failed": []}))
        self.assertIn('#REQUIRES="rust-opt a"', self.read(self.hint))
        self.assertIn('MD5SUM="old"', self.read(self.hint))  # no version given: no download

    def test_diff_revert_delete(self):
        self.make_pkg("misc/x", self.info, hint="A=1\n")
        self.assertEqual(sbb.cmd_hint_diff(self.cfg, "x"), {"bak": None, "current": "A=1\n"})
        self.assertEqual(sbb.cmd_hint_delete(self.cfg, "x"), {"ok": True})
        self.assertEqual(sbb.cmd_hint_diff(self.cfg, "x"), {"bak": "A=1\n", "current": None})
        with self.assertRaisesRegex(sbb.Error, "no hint"):
            sbb.cmd_hint_delete(self.cfg, "x")
        self.assertEqual(sbb.cmd_hint_revert(self.cfg, "x"), {"ok": True})
        self.assertEqual(self.read(self.hint), "A=1\n")
        self.assertFalse(os.path.exists(self.hint + ".bak"))
        self.assertEqual(sbb.cmd_hint_revert(self.cfg, "x"), {"ok": True})  # no .bak: revert a new hint
        self.assertFalse(os.path.exists(self.hint))
        with self.assertRaisesRegex(sbb.Error, "nothing to revert"):
            sbb.cmd_hint_revert(self.cfg, "x")
        with self.assertRaisesRegex(sbb.Error, "no backup"):
            sbb.cmd_hint_diff(self.cfg, "x")
        with self.assertRaisesRegex(sbb.Error, "no such package"):
            sbb.cmd_hint_diff(self.cfg, "../x")

    def test_job_result(self):
        jid, d = self.make_job(["true"])
        with open(os.path.join(d, "log"), "w") as f:
            f.write('x: downloading u\nSBB-RESULT {"ok": ["x"], "failed": []}\n{"error": "1 failed"}\n')
        self.assertEqual(sbb.cmd_job_result(self.cfg, jid), {"ok": ["x"], "failed": []})
        jid2 = "20260101-000001-test"
        os.mkdir(os.path.join(self.tmp, "jobs", jid2))
        open(os.path.join(self.tmp, "jobs", jid2, "log"), "w").close()
        with self.assertRaisesRegex(sbb.Error, "no result"):
            sbb.cmd_job_result(self.cfg, jid2)

    def test_end_to_end(self):
        self.make_pkg("misc/x", self.info, hint='VERSION="1.0"\nDOWNLOAD="u"\nMD5SUM="m"\n')
        rc, data = self.run_main("job-start", "hint-update", "x=2.0", "--no-dl")
        d = os.path.join(self.tmp, "jobs", data["id"])
        self.assertEqual(self.wait_status(d, ("ok", "failed", "lost"))["status"], "ok")
        self.assertEqual(self.run_main("job-result", data["id"]), (0, {"ok": ["x"], "failed": []}))
        self.assertEqual(self.read(self.hint), 'VERSION="2.0"\nDOWNLOAD="no"\n')


class PhantomTest(Base):
    def setUp(self):
        super().setUp()
        self.cfg["phantom_deps_file"] = os.path.join(self.tmp, "phantom-deps")
        with open(self.cfg["phantom_deps_file"], "w") as f:
            f.write("# deps needed on stable but not on -current\nrust-opt\n")
        self.make_pkg("desktop/marco", 'VERSION="1"\nREQUIRES="zenity libfoo"\n')
        self.make_pkg("games/steam", 'VERSION="1"\nREQUIRES="zenity"\n',
                      hint='DELREQUIRES="rust-opt"\n')
        self.make_pkg("libs/libfoo", 'VERSION="1"\nREQUIRES="%README% rust-opt"\n')

    def read(self, path):
        with open(path) as f:
            return f.read()

    def test_list_and_suggestions(self):
        self.assertEqual(sbb.cmd_phantom_list(self.cfg), {
            "deps": ["rust-opt"],
            "suggestions": [{"name": "zenity", "needed_by": ["marco", "steam"]}]})
        os.remove(self.cfg["phantom_deps_file"])
        self.assertEqual(sbb.cmd_phantom_list(self.cfg)["deps"], [])  # missing file: empty list

    def test_add_remove_keep_comments(self):
        self.assertEqual(sbb.cmd_phantom_add(self.cfg, "zenity", "rust-opt", "zenity"),
                         {"deps": ["rust-opt", "zenity"]})
        self.assertEqual(sbb.cmd_phantom_list(self.cfg)["suggestions"], [])
        self.assertEqual(sbb.cmd_phantom_remove(self.cfg, "rust-opt"), {"deps": ["zenity"]})
        self.assertEqual(self.read(self.cfg["phantom_deps_file"]),
                         "# deps needed on stable but not on -current\nzenity\n")
        for bad in ([], ["../x"], ["a b"]):
            with self.subTest(bad=bad), self.assertRaises(sbb.Error):
                sbb.cmd_phantom_add(self.cfg, *bad)

    def test_fix_current(self):
        sbb.cmd_phantom_add(self.cfg, "zenity")
        out = io.StringIO()
        with contextlib.redirect_stdout(out):
            sbb.cmd_fix_current_now(self.cfg)
        lines = out.getvalue().splitlines()
        self.assertEqual(json.loads(lines[-1].split(" ", 1)[1]),
                         {"ok": ["libfoo", "marco", "steam"], "failed": []})
        hints = self.cfg["hintdir"]
        self.assertEqual(self.read(os.path.join(hints, "marco.hint")), 'DELREQUIRES="zenity"\n')
        self.assertFalse(os.path.exists(os.path.join(hints, "marco.hint.bak")))  # new: revert deletes
        self.assertEqual(self.read(os.path.join(hints, "steam.hint")), 'DELREQUIRES="rust-opt zenity"\n')
        self.assertEqual(self.read(os.path.join(hints, "steam.hint.bak")), 'DELREQUIRES="rust-opt"\n')
        self.assertIn("marco: DELREQUIRES zenity", lines)
        out = io.StringIO()
        with contextlib.redirect_stdout(out):
            sbb.cmd_fix_current_now(self.cfg)  # second run: nothing to do, no .bak churn
        self.assertIn('{"ok": [], "failed": []}', out.getvalue())
        self.assertEqual(self.read(os.path.join(hints, "steam.hint.bak")), 'DELREQUIRES="rust-opt"\n')

    def test_merge_delrequires(self):
        self.assertEqual(sbb.merge_delrequires('DELREQUIRES="a"\n', ["b", "a"]), 'DELREQUIRES="a b"\n')
        self.assertIsNone(sbb.merge_delrequires('DELREQUIRES="a b"\n', ["b"]))
        self.assertEqual(sbb.merge_delrequires("", ["b", "b"]), 'DELREQUIRES="b"\n')

    def test_job_kind(self):
        me = [sys.executable, os.path.abspath(sbb.__file__), "_hint"]
        self.assertEqual(sbb.KINDS["fix-current"](self.cfg, []), (me + ["fix-current"], {}))
        with self.assertRaisesRegex(sbb.Error, "no arguments"):
            sbb.KINDS["fix-current"](self.cfg, ["x"])


class MainTest(Base):
    def test_unknown_command(self):
        rc, data = self.run_main("nope")
        self.assertEqual(rc, 1)
        self.assertIn("usage", data["error"])

    def test_version(self):
        self.assertEqual(self.run_main("version"),
                         (0, {"version": sbb.VERSION, "overlays": ["personal", "pentesting"]}))


class InventoryTest(Base):
    def test_rows(self):
        self.make_pkg("misc/nuclei", 'VERSION="3.11.0"\nMAINTAINER="Some One"\n'
                      'REQUIRES="go \\\n  git"\n', desc="Fast scanner")
        self.make_pkg("personal/foo", 'VERSION="1.0"\n',
                      hint='VERSION="1.1"  # bumped\nDELREQUIRES="a b"\nOPTIONS="X=$(uname -m)"\n')
        os.makedirs(os.path.join(self.cfg["repo_dir"], "misc", "notapkg"))
        db = sqlite3.connect(self.cfg["slackrepo_db"])
        db.executescript("""
            create table buildresults (itemid text primary key, time text, result text);
            create table revisions (itemid text, dep text, deplist text, version text,
                built text, rev text, os text, hintcksum text, primary key (itemid, dep));
            insert into buildresults values ('misc/nuclei', '5', 'ok'), ('nuclei', '1', 'bad');
            insert into revisions values ('misc/nuclei', '/', '/', '3.11.0', '1788978222', 'r', 'o', '/');
        """)
        db.close()
        inv = sbb.cmd_inventory(self.cfg)
        rows = [dict(zip(inv["columns"], r)) for r in inv["rows"]]
        self.assertEqual([r["path"] for r in rows], ["misc/nuclei", "personal/foo"])
        nuclei, foo = rows
        self.assertEqual((nuclei["version"], nuclei["built_version"], nuclei["built_time"],
                          nuclei["result"], nuclei["maintainer"], nuclei["requires"],
                          nuclei["summary"], nuclei["hint_path"]),
                         ("3.11.0", "3.11.0", 1788978222, "ok", "Some One", ["go", "git"],
                          "Fast scanner", None))
        self.assertEqual((foo["version"], foo["info_version"], foo["hint_version"], foo["result"]),
                         ("1.1", "1.0", "1.1", None))
        self.assertEqual(foo["hints"]["DELREQUIRES"], "a b")
        self.assertEqual(foo["hints"]["OPTIONS"], {"value": '"X=$(uname -m)"', "shell": True})
        json.dumps(inv)

    def test_hint_search_order(self):
        self.make_pkg("misc/foo")
        sub = os.path.join(self.cfg["hintdir"], "misc", "foo")
        os.makedirs(sub)
        with open(os.path.join(sub, "foo.hint"), "w") as f:
            f.write('VERSION="2"\n')
        self.assertEqual(sbb.find_hint(self.cfg, "misc/foo"), os.path.join(sub, "foo.hint"))
        with open(os.path.join(self.cfg["hintdir"], "foo.hint"), "w") as f:
            f.write('VERSION="3"\n')
        self.assertEqual(sbb.find_hint(self.cfg, "misc/foo"),
                         os.path.join(self.cfg["hintdir"], "foo.hint"))
        in_repo = os.path.join(self.cfg["repo_dir"], "misc", "foo", "foo.hint")
        open(in_repo, "w").close()
        self.assertEqual(sbb.find_hint(self.cfg, "misc/foo"), in_repo)

    def test_missing_db(self):
        self.make_pkg("misc/foo", 'VERSION="1"\n')
        row = sbb.cmd_inventory(self.cfg)["rows"][0]
        self.assertEqual(row[4:7], [None, None, None])


class GpgTest(Base):
    def setup_key(self, cached):
        with open(self.cfg["genreprc"], "w") as f:
            f.write('REPOSOWNERGPG="ABCD1234"\nUSE_GPGAGENT=1\n')
        self.fake_bin("gpg", 'case "$*" in\n'
                      '  *--list-secret-keys*) printf "sec:u:255:22:K:1::::::scESC:\\n'
                      'grp:::::::::GRIPSIGN:\\nssb:u:255:18:S:1::::::e:\\ngrp:::::::::GRIPENC:\\n" ;;\n'
                      f'  *-bas*) [ -f "{self.tmp}/good" ] ;;\n'
                      'esac\n')
        flag = "1" if cached else "-"
        self.fake_bin("gpg-connect-agent", f'echo "S KEYINFO GRIPSIGN D - - {flag} P - - -"; echo OK\n')

    def test_status(self):
        self.assertEqual(sbb.cmd_gpg_status(self.cfg), {"unlocked": None, "key": None})
        self.setup_key(cached=False)
        self.assertEqual(sbb.cmd_gpg_status(self.cfg), {"unlocked": False, "key": "ABCD1234"})
        self.setup_key(cached=True)
        self.assertEqual(sbb.cmd_gpg_status(self.cfg)["unlocked"], True)

    def test_locked_refuses_real_run_only(self):
        self.setup_key(cached=False)
        self.make_pkg("misc/foo")
        with self.assertRaisesRegex(sbb.Error, "signing key locked"):
            sbb.cmd_job_start(self.cfg, "slackrepo", "build", "foo")
        self.fake_bin("slackrepo", "exit 0\n")
        self.assertIn("id", sbb.cmd_job_start(self.cfg, "slackrepo", "build", "--preview", "foo"))

    def test_unlock(self):
        self.setup_key(cached=False)
        log = os.path.join(self.tmp, "preset.log")
        preset = self.fake_bin("preset", f'echo "$* $(cat)" >> {log}\n')
        with mock.patch.object(sbb, "PRESET", preset):
            with self.assertRaisesRegex(sbb.Error, "bad passphrase"):
                sbb.cmd_gpg_unlock(self.cfg, stdin=io.BytesIO(b"wrong\n"))
            open(os.path.join(self.tmp, "good"), "w").close()
            self.assertEqual(sbb.cmd_gpg_unlock(self.cfg, stdin=io.BytesIO(b"right\n")),
                             {"unlocked": True})
        with open(log) as f:
            self.assertEqual(f.read().splitlines(),
                             ["--preset GRIPSIGN wrong", "--forget GRIPSIGN ", "--preset GRIPSIGN right"])


class JobsTest(Base):
    def log(self, d):
        with open(os.path.join(d, "log"), "rb") as f:
            return f.read()

    def test_run_ok(self):
        jid, d = self.make_job(["sh", "-c", "echo hello"])
        sbb.cmd_run(self.cfg, jid)
        m = sbb.read_meta(d)
        self.assertEqual((m["status"], m["exit"]), ("ok", 0))
        self.assertEqual(self.log(d), b"hello\n")

    def test_run_failed(self):
        jid, d = self.make_job(["sh", "-c", "exit 3"])
        sbb.cmd_run(self.cfg, jid)
        m = sbb.read_meta(d)
        self.assertEqual((m["status"], m["exit"]), ("failed", 3))

    def test_run_missing_program(self):
        jid, d = self.make_job(["/nonexistent/prog"])
        sbb.cmd_run(self.cfg, jid)
        self.assertEqual(sbb.read_meta(d)["status"], "failed")
        self.assertIn(b"sbb-remote:", self.log(d))

    def test_kill(self):
        jid, d = self.make_job(["sleep", "30"])
        t = threading.Thread(target=sbb.cmd_run, args=(self.cfg, jid))
        t.start()
        self.wait_status(d, ("running",))
        self.assertEqual(sbb.cmd_job_kill(self.cfg, jid), {"ok": True})
        t.join(5)
        self.assertEqual(sbb.read_meta(d)["status"], "killed")

    def test_kill_not_running(self):
        jid, _ = self.make_job(["true"], status="ok")
        with self.assertRaisesRegex(sbb.Error, "not running"):
            sbb.cmd_job_kill(self.cfg, jid)

    def test_busy(self):
        self.hold_lock()
        jid, d = self.make_job(["true"])
        sbb.cmd_run(self.cfg, jid)
        self.assertEqual(sbb.read_meta(d)["status"], "busy")

    def test_lost_when_lock_free(self):
        self.make_job(["true"], status="running", pid=1)
        self.assertEqual(sbb.cmd_jobs(self.cfg)["jobs"][0]["status"], "lost")

    def test_running_kept_while_lock_held(self):
        self.hold_lock()
        self.make_job(["true"], status="running", pid=1)
        self.assertEqual(sbb.cmd_jobs(self.cfg)["jobs"][0]["status"], "running")

    def test_starting_grace(self):
        _, d = self.make_job(["true"])
        self.assertEqual(sbb.cmd_jobs(self.cfg)["jobs"][0]["status"], "starting")
        sbb.write_meta(d, dict(sbb.read_meta(d), created=time.time() - 60))
        self.assertEqual(sbb.cmd_jobs(self.cfg)["jobs"][0]["status"], "lost")

    def test_follow_from_offset(self):
        jid, d = self.make_job(["true"], status="ok")
        with open(os.path.join(d, "log"), "wb") as f:
            f.write(b"hello world")
        out = io.BytesIO()
        sbb.cmd_job_follow(self.cfg, jid, "6", out=out)
        self.assertEqual(out.getvalue(), b"world")

    def test_bad_job_id(self):
        with self.assertRaisesRegex(sbb.Error, "bad job id"):
            sbb.cmd_job_follow(self.cfg, "../../etc", "0")

    def fake_sbshadow(self):
        bindir = os.path.join(self.tmp, "bin")
        os.mkdir(bindir)
        fake = os.path.join(bindir, "sbshadow")
        with open(fake, "w") as f:
            f.write('#!/bin/sh\necho "shadow:   cat/$1"\n')
        os.chmod(fake, 0o755)
        patcher = mock.patch.dict(os.environ, {"PATH": bindir + os.pathsep + os.environ["PATH"]})
        patcher.start()
        self.addCleanup(patcher.stop)

    def test_env_reaches_child(self):
        jid, d = self.make_job(["sh", "-c", 'echo "publish=$SBB_PUBLISH"'], env={"SBB_PUBLISH": "n"})
        sbb.cmd_run(self.cfg, jid)
        self.assertEqual(self.log(d), b"publish=n\n")

    def test_start_end_to_end(self):
        self.fake_sbshadow()
        rc, data = self.run_main("job-start", "sbshadow", "--no")
        self.assertEqual(rc, 0)
        d = os.path.join(self.tmp, "jobs", data["id"])
        self.assertEqual(self.wait_status(d, ("ok", "failed", "lost"))["status"], "ok")
        self.assertEqual(self.log(d), b"shadow:   cat/--no\n")

    def test_start_busy(self):
        self.fake_sbshadow()
        self.hold_lock()
        jid, _ = self.make_job(["true"], status="running", pid=1)
        self.assertEqual(self.run_main("job-start", "sbshadow", "--no"), (0, {"busy": jid}))
        self.assertEqual(os.listdir(os.path.join(self.tmp, "jobs")), [jid])


class StatsTest(Base):
    def test_orphans(self):
        self.make_pkg("net/a", 'MAINTAINER="orphaned - no maintainer"\nEMAIL="NOEMAIL"\n')
        self.make_pkg("net/b", 'MAINTAINER="Someone"\n')
        self.make_pkg("personal/c", 'PRGNAM="c"\nMAINTAINER="orphaned - no maintainer"\n')
        self.assertEqual(sbb._orphans(self.cfg), 2)

    def test_missing_sources_are_null(self):
        s = sbb.cmd_stats(self.cfg)
        self.assertIsNotNone(s["load"])
        self.assertEqual(set(s["disk"]), {"total", "free"})
        self.assertIn("slackpkg", s)
        self.assertIsNone(s["packages"])
        self.assertIsNone(s["orphans"])
        self.assertIsNone(s["slackrepo"])
        self.assertEqual(s["sync"], {"personal": None, "pentesting": None})
        json.dumps(s)

    def test_vm_figures(self):
        meminfo = os.path.join(self.tmp, "meminfo")
        with open(meminfo, "w") as f:
            f.write("MemTotal:       16000 kB\nMemFree:  9000 kB\nMemAvailable:   12000 kB\n")
        self.assertEqual(sbb._meminfo(meminfo), {"total": 16000 * 1024, "available": 12000 * 1024})
        with mock.patch.object(sbb, "_cpu_times", side_effect=[(100, 1000), (150, 1100)]), \
                mock.patch.object(sbb.time, "sleep"):
            self.assertEqual(sbb._cpu(), 50.0)
        stat = os.path.join(self.tmp, "stat")
        with open(stat, "w") as f:
            f.write("cpu  10 0 10 70 10 0 0 0 0 0\ncpu0 1 2 3 4\n")
        self.assertEqual(sbb._cpu_times(stat), (20, 100))  # idle + iowait count as not busy

    def test_slackpkg_times(self):
        last = os.path.join(self.tmp, "LASTUPDATE")
        with open(last, "w") as f:
            f.write("1791760212\n")
        pkgs = os.path.join(self.tmp, "packages")
        os.mkdir(pkgs)
        for name, t in (("a-1-x86_64-1", 1000), ("b-2-x86_64-1", 3000)):
            open(os.path.join(pkgs, name), "w").close()
            os.utime(os.path.join(pkgs, name), (t, t))
        self.assertEqual(sbb._slackpkg(last, pkgs), {"update": 1791760212, "upgrade": 3000})
        self.assertEqual(sbb._slackpkg("/nonexistent", "/nonexistent"), {"update": None, "upgrade": None})

    def test_counts(self):
        r = self.cfg["repo_dir"]
        for p in ("cat/foo", "cat/bar", "personal/foo", "personal/baz", "pentesting/nmap"):
            os.makedirs(os.path.join(r, p))
            open(os.path.join(r, p, os.path.basename(p) + ".SlackBuild"), "w").close()
        os.makedirs(os.path.join(r, "cat", "notapkg"))

        def fake_git(cfg, *args):
            if args[0] == "ls-tree":
                return "cat/foo/foo.SlackBuild\ncat/foo/README\ncat/old/old.SlackBuild\n"
            return "1792351223\n"

        with mock.patch.object(sbb, "_git", fake_git):
            s = sbb.cmd_stats(self.cfg)
        self.assertEqual(s["packages"], {"total": 5, "personal": 2, "pentesting": 1, "shadowed": 1})
        self.assertEqual(s["sync"]["personal"], 1792351223)

    def test_slackrepo(self):
        db = sqlite3.connect(self.cfg["slackrepo_db"])
        db.executescript("""
            create table buildresults (itemid text primary key, time text, result text);
            create table revisions (itemid text, dep text, deplist text, version text,
                built text, rev text, os text, hintcksum text, primary key (itemid, dep));
            insert into buildresults values ('cat/a', '1', 'ok'), ('cat/b', '1', 'ok'),
                ('cat/c', '1', 'failed'), ('ghost', '1', 'bad'), ('c-1.0-x86_64-1_x', '1', 'bad');
            insert into revisions values ('cat/a', '/', '/', '1', '1', 'r', 'o', '/'),
                                         ('cat/a', 'dep', '/', '1', '1', 'r', 'o', '/');
        """)
        db.close()
        # legacy keys without a category/ match no package and are not counted
        self.assertEqual(sbb.cmd_stats(self.cfg)["slackrepo"],
                         {"results": {"ok": 2, "failed": 1}, "built": 1})


class ResultsTest(Base):
    def setUp(self):
        super().setUp()
        logdir = os.path.join(self.tmp, "logs")
        self.cfg["slackrepo_logdir"] = logdir
        db = sqlite3.connect(self.cfg["slackrepo_db"])
        db.executescript("""
            create table buildresults (itemid text primary key, time text, result text);
            create table revisions (itemid text, dep text, deplist text, version text,
                built text, rev text, os text, hintcksum text, primary key (itemid, dep));
            insert into buildresults values ('cat/a', '100', 'ok'), ('cat/c', '300', 'failed'),
                                            ('ghost', '200', 'bad');
            insert into revisions values ('cat/a', '/', '/', '1.0', '100', 'r', 'o', '/');
        """)
        db.close()
        os.makedirs(os.path.join(logdir, "cat", "c"))
        with open(os.path.join(logdir, "cat", "c", "build.log"), "w") as f:
            f.write("x" * 100 + "\nERROR: make failed\n")
        with open(os.path.join(logdir, "cat", "c", "resource.log"), "w") as f:
            f.write("peak memory 3308M\n")

    def test_rows(self):
        self.assertEqual(sbb.cmd_results(self.cfg), {"rows": [
            ["cat/c", "failed", 300, None, True],
            ["cat/a", "ok", 100, "1.0", False]]})

    def test_build_log_tail(self):
        with mock.patch.object(sbb, "LOG_TAIL", 20):
            log = sbb.cmd_build_log(self.cfg, "cat/c")
        self.assertEqual(log["build"], "\nERROR: make failed\n"[-20:])
        self.assertTrue(log["truncated"])
        self.assertEqual(log["resource"], "peak memory 3308M\n")
        self.assertEqual(log["name"], "build.log")
        self.assertIsInstance(log["mtime"], int)

    def test_newest_command_log_wins(self):
        # slackrepo keeps one log per command: the last attempt may be an update
        d = os.path.join(self.cfg["slackrepo_logdir"], "cat", "c")
        os.utime(os.path.join(d, "build.log"), (1000, 1000))
        with open(os.path.join(d, "update.log"), "w") as f:
            f.write("ERROR: Download failed\n")
        with open(os.path.join(d, "config.log"), "w") as f:
            f.write("autotools noise\n")
        log = sbb.cmd_build_log(self.cfg, "cat/c")
        self.assertEqual((log["name"], log["build"]), ("update.log", "ERROR: Download failed\n"))

    def test_build_log_rejects(self):
        for bad in ("../etc/passwd", "cat/../../x", "cat", "cat/a", "/etc/x"):
            with self.subTest(bad=bad), self.assertRaises(sbb.Error):
                sbb.cmd_build_log(self.cfg, bad)


if __name__ == "__main__":
    unittest.main()