diff options
| author | Danilo M. <danix@danix.xyz> | 2026-09-14 19:31:00 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-09-14 19:31:00 +0200 |
| commit | 7304e3dd96f0bae4d63ccf3d4fa4f176b760a81f (patch) | |
| tree | e4094588b4122f7443a0c1a8f3724619fee994a9 /desktop/modules/kdeconnect/KdeConnectPage.qml | |
| parent | 32f88e68dfa9489ef09408b3dd34180b76357750 (diff) | |
| download | quickshell-7304e3dd96f0bae4d63ccf3d4fa4f176b760a81f.tar.gz quickshell-7304e3dd96f0bae4d63ccf3d4fa4f176b760a81f.zip | |
fix(desktop): name the kdeconnect injected property kc, not mod
The tile, page and row each took a required property named mod while the
module object's id is also mod. In a Component scope the id resolves to
the property's own unset self, so every page.mod read was undefined and
the device list never rendered. Only a runtime TypeError showed it; the
smoke check was clean because the drawer was closed.
kc matches the net and bt convention and cannot collide with the id.
Diffstat (limited to 'desktop/modules/kdeconnect/KdeConnectPage.qml')
| -rw-r--r-- | desktop/modules/kdeconnect/KdeConnectPage.qml | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/desktop/modules/kdeconnect/KdeConnectPage.qml b/desktop/modules/kdeconnect/KdeConnectPage.qml index ba2c8e3..89df597 100644 --- a/desktop/modules/kdeconnect/KdeConnectPage.qml +++ b/desktop/modules/kdeconnect/KdeConnectPage.qml @@ -15,7 +15,7 @@ import "../.." Column { id: page - required property var mod + required property var kc spacing: 14 @@ -25,15 +25,15 @@ Column { Button { text: "Refresh" - onClicked: page.mod.discover() + onClicked: page.kc.discover() } } Text { width: page.width - visible: page.mod.error !== "" + visible: page.kc.error !== "" wrapMode: Text.Wrap - text: page.mod.error + text: page.kc.error font { family: Theme.fontFamily; pixelSize: Theme.fontSize - 3 } color: Theme.red } @@ -41,7 +41,7 @@ Column { // Incoming pairing requests. The property persists while the drawer is // closed, so a request raised then is still here when it opens. Repeater { - model: page.mod.requests + model: page.kc.requests Rectangle { required property var modelData @@ -61,7 +61,7 @@ Column { Text { width: parent.width elide: Text.ElideRight - text: page.mod.deviceName(modelData) + " wants to pair" + text: page.kc.deviceName(modelData) + " wants to pair" font { family: Theme.fontFamily; pixelSize: Theme.fontSize - 2; bold: true } color: Theme.text } @@ -71,13 +71,13 @@ Column { Button { text: "Accept" - onClicked: page.mod.accept(modelData) + onClicked: page.kc.accept(modelData) } Button { text: "Reject" danger: true - onClicked: page.mod.reject(modelData) + onClicked: page.kc.reject(modelData) } } } @@ -86,18 +86,18 @@ Column { Text { width: page.width - visible: page.mod.paired.length > 0 + visible: page.kc.paired.length > 0 text: "Paired" font { family: Theme.fontFamily; pixelSize: Theme.fontSize - 2; bold: true } color: Theme.subtext } Repeater { - model: page.mod.paired + model: page.kc.paired KdeConnectRow { required property var modelData - mod: page.mod + kc: page.kc device: modelData width: page.width } @@ -105,18 +105,18 @@ Column { Text { width: page.width - visible: page.mod.unpaired.length > 0 + visible: page.kc.unpaired.length > 0 text: "Available" font { family: Theme.fontFamily; pixelSize: Theme.fontSize - 2; bold: true } color: Theme.subtext } Repeater { - model: page.mod.unpaired + model: page.kc.unpaired KdeConnectRow { required property var modelData - mod: page.mod + kc: page.kc device: modelData width: page.width } |
