diff options
| author | Danilo M. <danix@danix.xyz> | 2026-10-24 09:32:29 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-10-24 09:32:29 +0200 |
| commit | c889501587db1d6ddf9440c002a1efc37444e1ca (patch) | |
| tree | 1c8b7d9b5c1e03f35c2bc98bb4351173ce005176 | |
| parent | da9faa9db8fbf813d815d30fc8d590a034704ead (diff) | |
| download | quickshell-c889501587db1d6ddf9440c002a1efc37444e1ca.tar.gz quickshell-c889501587db1d6ddf9440c002a1efc37444e1ca.zip | |
ipc: show() is open(), the CLI could never reach it
qs ipc has a show subcommand, and its parser takes the word wherever it
appears: `qs -p <dir> ipc call companion show` printed the target list
and exited 0 instead of calling the function. The companion, window
switcher and keybind reminder each had a show() no command line could
call. The binds use toggle and are unaffected. open() matches the
drawer's own.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| -rw-r--r-- | AGENTS.md | 5 | ||||
| -rw-r--r-- | desktop/companion/Companion.qml | 2 | ||||
| -rw-r--r-- | keybinds/shell.qml | 2 | ||||
| -rw-r--r-- | window-switcher/shell.qml | 2 |
4 files changed, 8 insertions, 3 deletions
@@ -546,6 +546,11 @@ back. `qs -p <dir>` runs one directly. `qs -p <dir> ipc call <target> <fn>` reaches a running one, which is how `SUPER+v` opens the VM drawer. +An `IpcHandler` function named after a `qs ipc` subcommand (`show`, `call`, +`wait`, `listen`, `prop`) cannot be called from the CLI: `ipc call companion +show` runs `ipc show` instead, prints the target list and exits 0. Three +handlers had a `show()` nobody could reach; they are `open()` now. + ## Conventions - GPLv2 only, with the header notice in every source file. diff --git a/desktop/companion/Companion.qml b/desktop/companion/Companion.qml index aa0505d..e2d91a9 100644 --- a/desktop/companion/Companion.qml +++ b/desktop/companion/Companion.qml @@ -459,7 +459,7 @@ PanelWindow { IpcHandler { target: "companion" function toggle() { Prefs.setCompanion(!Prefs.companion); } - function show() { Prefs.setCompanion(true); } + function open() { Prefs.setCompanion(true); } function hide() { Prefs.setCompanion(false); } } diff --git a/keybinds/shell.qml b/keybinds/shell.qml index 7c34bfd..3a24384 100644 --- a/keybinds/shell.qml +++ b/keybinds/shell.qml @@ -20,7 +20,7 @@ ShellRoot { IpcHandler { target: "keybinds" function toggle() { keybinds.toggle(); } - function show() { keybinds.open = true; } + function open() { keybinds.open = true; } function close() { keybinds.close(); } } } diff --git a/window-switcher/shell.qml b/window-switcher/shell.qml index 0ebe553..fbd7a79 100644 --- a/window-switcher/shell.qml +++ b/window-switcher/shell.qml @@ -25,7 +25,7 @@ ShellRoot { IpcHandler { target: "switcher" function toggle() { switcher.toggle(); } - function show() { switcher.open = true; } + function open() { switcher.open = true; } function close() { switcher.close(); } } } |