aboutsummaryrefslogtreecommitdiffstats
path: root/docs/superpowers/specs/2026-06-26-mkwheels-gh-source-mode-design.md
blob: f2b6a7aa70113a7cfa4a237469685f696f261d64 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
# mkwheels — GitHub source mode

Date: 2026-06-26
Status: approved

## Problem

mkwheels currently vendors a single PyPI package and its dependency tree into
a reproducible, pinned wheels tarball. Some packages are not on PyPI. NetExec
(the motivating case) ships only from GitHub source and pulls in four git
dependencies (impacket, certipy-ad, oscrypto, pynfsclient). The existing
PyPI-only interface cannot vendor it.

We want a second mode that takes a GitHub repo + version, downloads the tagged
source, and lets pip resolve the full dependency tree (PyPI + git deps) into
the same reproducible wheels tarball.

## CLI

Mode selector first, all options as explicit flags, no positionals. This is a
breaking change to the current positional interface; acceptable because the
only consumer (the netexec SlackBuild) is not yet written.

```
mkwheels --pypi --name PKG --ver VER [--epoch N]
mkwheels --gh   --repo OWNER/REPO --ver VER [--name PKG] [--tag TAG] [--epoch N]
```

### Normalization

- `--ver` and `--tag` each strip a single leading `v` if present.
- The normalized version is what appears in the output filename, always
  without a leading `v`: `<name>-wheels-<version>.tar.gz`.

### `--gh` defaults

- `--name`  → repo basename, lowercased (e.g. `Pennyw0rth/NetExec``netexec`).
- `--tag`   → the normalized `--ver`.
- `--epoch` → auto-derived from the GitHub release `published_at` (below).

## `--gh` flow

1. **Resolve the release / ref and epoch.**
   GET `https://api.github.com/repos/<owner/repo>/releases/tags/<tag>`.
   On 404, retry with `v<tag>`. Use whichever resolves; remember the real ref
   string (`<tag>` or `v<tag>`). Take `published_at` from the response and
   convert to epoch — unless `--epoch` was given, which wins.
   - NetExec example: tag normalizes to `1.5.1`; `releases/tags/1.5.1` 404s,
     `releases/tags/v1.5.1` resolves; ref is `v1.5.1`.

2. **Download and unpack the source.**
   Fetch `https://github.com/<owner/repo>/archive/refs/tags/<ref>.tar.gz`,
   unpack into the throwaway workdir.

3. **Resolve the tree with pip.**
   `pip download <unpacked-source-dir> --dest "$wheels"`. pip reads the
   project's metadata, resolves PyPI deps, and clones+builds the git deps into
   wheels. This is the only step that differs from PyPI mode.

4. **Emit outputs (shared with `--pypi`).**
   Generate the pinned, hashed `requirements.txt` from the wheels dir, pack the
   normalized reproducible tarball, print epoch + md5. Identical to the current
   path.

## `--pypi` flow

Unchanged behavior from the current tool: resolve `<name>==<ver>` via
`pip download`, auto-derive epoch from PyPI `upload_time_iso_8601` when
`--epoch` is omitted. Only the surface changes: gated behind the `--pypi`
selector and switched from positionals to `--name` / `--ver` / `--epoch`.

## Shared internals

The requirements.txt generation and the reproducible tar packing already
operate on a populated wheels directory regardless of how it was filled. Both
modes converge on that directory; no duplication of the packaging logic.

`requirements.txt` remains an audit record (pinned + hashed), not the install
input — the SlackBuild installs from the wheels via `--no-index --find-links`.

## Selftest

Keep the existing `--pypi` reproducibility check (two builds at a fixed epoch
must be byte-identical). Add a `--gh` reproducibility check against a small,
pure-Python, GitHub-tagged package so the run stays fast. Two builds at a fixed
epoch must be byte-identical.

## Out of scope

- Caching git clones between runs.
- Private repos / authenticated GitHub access.
- Non-GitHub forges (GitLab, Codeberg, etc.).
- Using requirements.txt as a pip install input.