Fail on non-finite dial values and results

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

2 files changed, 28 insertions, 1 deletions

diff --git a/tests/test_evaluate.py b/tests/test_evaluate.py
index 6668b0e..da5b840 100644
--- a/tests/test_evaluate.py
+++ b/tests/test_evaluate.py
@@ -17,9 +17,12 @@
 
 import contextlib
 import io
+import json
+import tempfile
 import unittest
 from pathlib import Path
 
+from generat3d import Error
 from generat3d.evaluate import evaluate
 from generat3d.library import Library
 from generat3d.scene import load
@@ -37,3 +40,17 @@ class EvaluateTest(unittest.TestCase):
         self.assertEqual(rest["hip"]["end_point"], [0, 8, 0])
         self.assertEqual(rest["Fig"]["end_point"], [0, 10, 0])
         self.assertEqual(scene.figure.verts.tolist()[0], [0, 0, 0])  # base untouched
+
+    def test_overflow_is_error(self):
+        with tempfile.TemporaryDirectory() as d:
+            root = Path(d) / "extra"
+            p = root / "data/Test/Fig/Morphs/Test/Big.dsf"
+            p.parent.mkdir(parents=True)
+            p.write_text(json.dumps({"modifier_library": [{
+                "id": "Big", "parent": "/data/Test/Fig/Fig.dsf#Fig",
+                "channel": {"id": "value", "value": 1e300},
+                "morph": {"vertex_count": 3, "deltas": {"values": [[0, 1e300, 0, 0]]}}}]}))
+            with contextlib.redirect_stderr(io.StringIO()):
+                scene = load(DATA / "scene.duf", Library([DATA / "lib", root]))
+            with self.assertRaisesRegex(Error, "non-finite"):
+                evaluate(scene)
diff --git a/tests/test_scene.py b/tests/test_scene.py
index 0d2e3c9..fe6c34d 100644
--- a/tests/test_scene.py
+++ b/tests/test_scene.py
@@ -170,7 +170,7 @@ class SceneTest(unittest.TestCase):
                 load_quiet(self.duf(scene))
 
     def test_dial_not_a_number(self):
-        with self.assertRaisesRegex(Error, "dial value is not a number"):
+        with self.assertRaisesRegex(Error, "dial value is not a finite number"):
             load_quiet(self.duf({"nodes": self.base_nodes(), "modifiers": [
                 {"id": "Tall", "url": "/data/Test/Fig/Morphs/Test/Tall.dsf#Tall",
                  "parent": "#Fig", "channel": {"id": "value", "current_value": "a"}}]}))
@@ -271,3 +271,13 @@ class SceneTest(unittest.TestCase):
             "output": "Hip:/data/Test/Fig2/Fig2.dsf#hip?center_point/y",
             "operations": [{"op": "push", "val": 1}]}]})
         self.assertEqual(len(scene.graph.formulas["hip:hip?center_point/y"]), 1)
+
+    def test_dial_not_finite(self):
+        for v in ("1e400", "10**400"):
+            text = json.dumps({"scene": {"nodes": self.base_nodes(), "animations": [
+                {"url": "Fig:#Tall?value", "keys": [[0, 0]]}]}}).replace(
+                '"keys": [[0, 0]]', '"keys": [[0, %s]]' % ("1e400" if v == "1e400" else "1" + "0" * 400))
+            p = self.dir / "s.duf"
+            p.write_text(text)
+            with self.assertRaisesRegex(Error, "dial value is not a finite number"):
+                load_quiet(p)