1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
|
import unittest
from unittest.mock import MagicMock
from firefly_cli.commands import transaction as tx
from firefly_cli.context import Context
def make_ctx():
client = MagicMock()
resolver = MagicMock()
return Context(client=client, resolver=resolver, human=False), client, resolver
class TestTxAdd(unittest.TestCase):
def test_infers_withdrawal_from_asset_to_expense(self):
ctx, client, resolver = make_ctx()
resolver.account.side_effect = lambda n: {
"Checking": {"id": "1", "name": "Checking", "type": "asset"},
"Groceries": {"id": "2", "name": "Groceries", "type": "expense"},
}[n]
client.request.return_value = {"data": {"id": "55", "type": "transactions",
"attributes": {}}}
args = MagicMock(amount="42.50", source="Checking", dest="Groceries",
desc="food", date="2026-06-30", category=None,
tags=None, type=None)
rc = tx.cmd_add(args, ctx)
self.assertEqual(rc, 0)
method, path = client.request.call_args[0][:2]
body = client.request.call_args[1]["body"]
split = body["transactions"][0]
self.assertEqual((method, path), ("POST", "/api/v1/transactions"))
self.assertEqual(split["type"], "withdrawal")
self.assertEqual(split["source_id"], "1")
self.assertEqual(split["destination_id"], "2")
self.assertEqual(split["amount"], "42.50")
def test_infers_deposit_revenue_to_asset(self):
ctx, client, resolver = make_ctx()
resolver.account.side_effect = lambda n: {
"Salary": {"id": "7", "name": "Salary", "type": "revenue"},
"Checking": {"id": "1", "name": "Checking", "type": "asset"},
}[n]
client.request.return_value = {"data": {"id": "1", "attributes": {}}}
args = MagicMock(amount="1000", source="Salary", dest="Checking",
desc="pay", date=None, category=None, tags=None, type=None)
tx.cmd_add(args, ctx)
self.assertEqual(client.request.call_args[1]["body"]["transactions"][0]["type"],
"deposit")
def test_explicit_type_overrides_inference(self):
ctx, client, resolver = make_ctx()
resolver.account.side_effect = lambda n: {"id": "1", "type": "asset", "name": n}
client.request.return_value = {"data": {"id": "1", "attributes": {}}}
args = MagicMock(amount="5", source="A", dest="B", desc=None, date=None,
category=None, tags="food,fun", type="transfer")
tx.cmd_add(args, ctx)
split = client.request.call_args[1]["body"]["transactions"][0]
self.assertEqual(split["type"], "transfer")
self.assertEqual(split["tags"], ["food", "fun"])
def test_category_passed_raw_not_resolved(self):
# Category name goes straight to Firefly (auto-creates); resolver untouched.
ctx, client, resolver = make_ctx()
resolver.account.side_effect = lambda n: {"id": "1", "type": "asset", "name": n}
client.request.return_value = {"data": {"id": "1", "attributes": {}}}
args = MagicMock(amount="5", source="A", dest="B", desc=None, date=None,
category="Brand New Cat", tags=None, type="withdrawal")
tx.cmd_add(args, ctx)
split = client.request.call_args[1]["body"]["transactions"][0]
self.assertEqual(split["category_name"], "Brand New Cat")
resolver.category.assert_not_called()
class TestTxEdit(unittest.TestCase):
def test_edit_sends_only_provided_fields(self):
ctx, client, resolver = make_ctx()
client.request.return_value = {"data": {"id": "9", "attributes": {}}}
args = MagicMock(id="9", amount="12.00", date=None, desc="fixed",
source=None, dest=None, category=None, tags=None, type=None)
rc = tx.cmd_edit(args, ctx)
self.assertEqual(rc, 0)
method, path = client.request.call_args[0][:2]
split = client.request.call_args[1]["body"]["transactions"][0]
self.assertEqual((method, path), ("PUT", "/api/v1/transactions/9"))
self.assertEqual(split, {"amount": "12.00", "description": "fixed"})
resolver.account.assert_not_called()
def test_edit_resolves_accounts_when_given(self):
ctx, client, resolver = make_ctx()
resolver.account.side_effect = lambda n: {
"BBVA": {"id": "3", "name": "BBVA", "type": "asset"},
"Medio": {"id": "4", "name": "Medio", "type": "asset"},
}[n]
client.request.return_value = {"data": {"id": "9", "attributes": {}}}
args = MagicMock(id="9", amount=None, date=None, desc=None,
source="BBVA", dest="Medio", category=None, tags=None, type=None)
tx.cmd_edit(args, ctx)
split = client.request.call_args[1]["body"]["transactions"][0]
self.assertEqual(split, {"source_id": "3", "destination_id": "4"})
def test_edit_category_raw_and_tags_split(self):
ctx, client, resolver = make_ctx()
client.request.return_value = {"data": {"id": "9", "attributes": {}}}
args = MagicMock(id="9", amount=None, date=None, desc=None, source=None,
dest=None, category="Cat", tags="a, b", type="transfer")
tx.cmd_edit(args, ctx)
split = client.request.call_args[1]["body"]["transactions"][0]
self.assertEqual(split,
{"category_name": "Cat", "tags": ["a", "b"], "type": "transfer"})
resolver.category.assert_not_called()
def test_edit_with_no_fields_errors(self):
from firefly_cli.errors import FireflyError
ctx, client, _ = make_ctx()
args = MagicMock(id="9", amount=None, date=None, desc=None, source=None,
dest=None, category=None, tags=None, type=None)
with self.assertRaises(FireflyError):
tx.cmd_edit(args, ctx)
client.request.assert_not_called()
class TestTxDelete(unittest.TestCase):
def test_delete_requires_yes(self):
from firefly_cli.errors import FireflyError
ctx, client, _ = make_ctx()
args = MagicMock(id="9", yes=False)
with self.assertRaises(FireflyError):
tx.cmd_delete(args, ctx)
client.request.assert_not_called()
def test_delete_with_yes(self):
ctx, client, _ = make_ctx()
client.request.return_value = {}
args = MagicMock(id="9", yes=True)
rc = tx.cmd_delete(args, ctx)
self.assertEqual(rc, 0)
method, path = client.request.call_args[0][:2]
self.assertEqual((method, path), ("DELETE", "/api/v1/transactions/9"))
class TestTxList(unittest.TestCase):
def test_list_passes_date_params(self):
ctx, client, _ = make_ctx()
client.request.return_value = {"data": []}
args = MagicMock(since="2026-06-01", until="2026-06-30",
account=None, limit=10)
tx.cmd_list(args, ctx)
params = client.request.call_args[1]["params"]
self.assertEqual(params["start"], "2026-06-01")
self.assertEqual(params["end"], "2026-06-30")
self.assertEqual(params["limit"], 10)
|
