aboutsummaryrefslogtreecommitdiffstats
path: root/docs/superpowers/plans/2026-10-16-attachments.md
blob: 3632e804759710f89a81e6a68876d80e7a02bf59 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
# Attachments Implementation Plan

> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.

**Goal:** `ask` carries file paths; text files and PDFs reach the model inline, images and scanned PDF pages as image parts, and history keeps text inline and images as a path and hash.

**Architecture:** A block of stdlib functions in `assistant.py` (`kind_of`, `sha256`, `pdf_pages`, `attach`, `resolve`, `wire`, the `Refused` exception) turns paths into text blocks, image references and chips. `answer()` builds the question from them and sends `wire(msgs)`, which resolves references to data URLs at send time. `turns` gains a `files` column, added by `ALTER TABLE` on old databases. `sees_images()` reads the router's `input_modalities`.

**Tech Stack:** Python 3.12 stdlib, poppler `pdftotext` and `pdftoppm`.

**Spec:** `docs/superpowers/specs/2026-10-16-attachments-design.md`

**Conventions:** as in `2026-10-16-text-daemon.md`: no em dashes, no personal data or home paths in committed files, GPG-signed commits with a `Co-Authored-By:` trailer naming the model that commits, master. Self-check `/usr/bin/python3 assistant.py --test` prints `ok` last; two `refused:` log lines before it are the refusal cases.

**Verified while planning:** the patches below were applied to a scratch copy: tests alone fail (the shown turns lack `files`), tests plus implementation print `ok`, three runs in a row. Live, against Gemma4-12B on a scratch socket and history: an image reading "BLUE 42" was answered `BLUE 42`, first token at 6.1 s; a two-page PDF, one text page and one image-only page, was answered "The meeting is on Tuesday and the budget is 900 euro.", the second fact being read from the page image. A second daemon refused to start while the user's daemon served the real socket. The scratch socket had to live in a short directory: an AF_UNIX path is limited to 108 bytes.

**Decided while planning:**
- Refusals raise `Refused`, logged as one `refused:` line without a traceback; any other exception keeps its traceback.
- `ask` with `files` that is not a list of strings answers `bad files`.
- Text files and PDFs share the character budget equally; a text file is read no further than its share could use.
- A PDF's text is one block with `[page N]` markers.
- A conversation whose first question is only files is titled by the file names.
- Tests build their PDF and PNG with the standard library, so the check needs no `magick`.

---

### Task 1: Attachments in the daemon

**Files:**
- Modify: `assistant.py`

- [ ] **Step 1: Write the failing tests**

Apply the tests patch (it changes only `test()`): save the block below as `att-tests.patch` in the session's scratchpad and run `git apply -p1 <scratchpad>/att-tests.patch`.

```diff
--- a/assistant.py	2026-10-16 15:05:02.308067377 +0200
+++ b/assistant.py	2026-10-16 15:05:02.308852511 +0200
@@ -716,8 +716,8 @@
     hist, shown = load_conv(db, a)
     assert hist == [[{"role": "user", "content": "q"}], [{"role": "user", "content": "q2"}]]
     assert shown == [{"user": "che tempo fa in città oggi pomeriggio?", "reply": "Piove.",
-                      "tools": ["weather"]},
-                     {"user": "e domani?", "reply": "Sole.", "tools": []}]
+                      "tools": ["weather"], "files": []},
+                     {"user": "e domani?", "reply": "Sole.", "tools": [], "files": []}]
     assert load_conv(db, 999) is None
     hits = search(db, "citta")                       # no accent typed, accented word found
     assert [h["id"] for h in hits] == [a] and "**città**" in hits[0]["snippet"]
@@ -740,16 +740,103 @@
         assert os.stat(os.path.dirname(path)).st_mode & 0o777 == 0o700
         assert os.stat(path).st_mode & 0o777 == 0o600
 
+    # Attachments.
+    import struct
+    import zlib
+
+    def tiny_pdf(path, pages):
+        # One Helvetica line per page; "" is a page with no text, a scan.
+        objs = ["<< /Type /Catalog /Pages 2 0 R >>",
+                "<< /Type /Pages /Kids [%s] /Count %d >>"
+                % (" ".join(f"{4 + 2 * i} 0 R" for i in range(len(pages))), len(pages)),
+                "<< /Type /Font /Subtype /Type1 /BaseFont /Helvetica >>"]
+        for i, t in enumerate(pages):
+            stream = f"BT /F1 24 Tf 72 700 Td ({t}) Tj ET" if t else ""
+            objs += [f"<< /Type /Page /Parent 2 0 R /MediaBox [0 0 612 792] /Resources "
+                     f"<< /Font << /F1 3 0 R >> >> /Contents {5 + 2 * i} 0 R >>",
+                     f"<< /Length {len(stream)} >>\nstream\n{stream}\nendstream"]
+        out, offsets = b"%PDF-1.4\n", []
+        for k, o in enumerate(objs, 1):
+            offsets.append(len(out))
+            out += f"{k} 0 obj\n{o}\nendobj\n".encode()
+        xref = len(out)
+        out += (f"xref\n0 {len(objs) + 1}\n0000000000 65535 f \n".encode()
+                + b"".join(f"{o:010d} 00000 n \n".encode() for o in offsets)
+                + f"trailer\n<< /Size {len(objs) + 1} /Root 1 0 R >>\n"
+                  f"startxref\n{xref}\n%%EOF\n".encode())
+        with open(path, "wb") as f:
+            f.write(out)
+
+    def tiny_png(path, rgb=b"\xff\x00\x00"):
+        def chunk(t, d):
+            return struct.pack(">I", len(d)) + t + d + struct.pack(">I", zlib.crc32(t + d))
+        with open(path, "wb") as f:
+            f.write(b"\x89PNG\r\n\x1a\n" + chunk(b"IHDR", struct.pack(">IIBBBBB", 1, 1, 8, 2, 0, 0, 0))
+                    + chunk(b"IDAT", zlib.compress(b"\x00" + rgb)) + chunk(b"IEND", b""))
+
+    files_dir = tempfile.TemporaryDirectory()
+    fd = files_dir.name
+    code, png, pdf, other = (os.path.join(fd, n) for n in ("a.py", "red.png", "doc.pdf", "x.bin"))
+    with open(code, "w") as f:
+        f.write("print('hi')\n" * 50)
+    tiny_png(png)
+    tiny_pdf(pdf, ["hello pdf", ""])
+    with open(other, "wb") as f:
+        f.write(b"\x00\x01")
+    assert [kind_of(p) for p in (code, png, pdf, other, "/x/README.md", "/x/b.SlackBuild")] == \
+        ["text", "image", "pdf", "other", "text", "text"]
+    blocks, refs, chips = attach([code, pdf, png], 100000)
+    assert blocks[0].startswith("--- file: a.py ---\nprint('hi')") and "(truncated)" not in blocks[0]
+    assert "[page 1]\nhello pdf" in blocks[1] and "[page 2]" in blocks[1]
+    assert chips == [{"name": "a.py", "kind": "text", "truncated": False},
+                     {"name": "doc.pdf", "kind": "pdf", "truncated": False, "pages": 2},
+                     {"name": "red.png", "kind": "image", "truncated": False}]
+    # The blank page is a scan: it goes as an image, rendered when sent.
+    assert [r["name"] for r in refs] == ["doc.pdf page 2", "red.png"] and refs[0]["page"] == 2
+    sent = [resolve(r) for r in refs]
+    assert all(x["type"] == "image_url" for x in sent)
+    assert sent[1]["image_url"]["url"].startswith("data:image/png;base64,")
+    assert base64.b64decode(sent[0]["image_url"]["url"].split(",", 1)[1])[:4] == b"\x89PNG"
+    small = attach([code], 24)[0][0]                 # the share is the cut: two lines
+    assert "(truncated)" in small and small.count("print") == 2
+    for bad, why in ((["a.py"], "cannot read a.py"), ([fd + "/nope.txt"], "cannot read nope.txt"),
+                     ([fd], "cannot read"), ([other], "x.bin: chat supports text, images and PDF"),
+                     ([code] * 9, "at most 8 files")):
+        try:
+            attach(bad, 1000)
+            assert False, bad
+        except Refused as e:
+            assert why in str(e), (bad, e)
+    # Stored as a reference: survives a save and reload, gone once changed.
+    a = save_turn(db, None, "", "A red pixel.", [], [{"role": "user", "content": refs[1:]}],
+                  chips[2:])
+    hist, shown = load_conv(db, a)
+    assert shown[0]["files"] == chips[2:] and list_convs(db)[0]["title"] == "red.png"
+    assert wire(hist[0])[0]["content"][0]["type"] == "image_url"
+    tiny_png(png, b"\x00\xff\x00")
+    assert wire(hist[0])[0]["content"][0] == {
+        "type": "text", "text": "[image red.png is no longer available]"}
+    os.remove(png)
+    assert resolve(refs[1])["type"] == "text"        # deleted reads the same
+    # An old database gains the files column.
+    with tempfile.TemporaryDirectory() as d:
+        old = sqlite3.connect(os.path.join(d, "h.db"))
+        old.executescript(SCHEMA)
+        old.close()
+        assert "files" in {r[1] for r in db_open(os.path.join(d, "h.db"))
+                           .execute("PRAGMA table_info(turns)")}
+
     # Protocol, against a fake llama-server.
     global DB, TOOLS, TOOL_SCHEMA
-    script = {"replies": [], "delay": 0}
+    script = {"replies": [], "delay": 0, "inputs": ["text", "image"]}
 
     class Fake(http.server.BaseHTTPRequestHandler):
         def log_message(self, *a):
             pass
 
         def do_GET(self):
-            body = ({"data": [{"id": "m", "status": {"value": "loaded"}}]}
+            body = ({"data": [{"id": "m", "status": {"value": "loaded"},
+                               "architecture": {"input_modalities": script["inputs"]}}]}
                     if self.path.endswith("/models")
                     else {"default_generation_settings": {"n_ctx": 4096}})
             self.send_response(200)
@@ -818,7 +905,7 @@
         assert script["body"]["chat_template_kwargs"]["enable_thinking"] is True
         conv = cur["id"]
         assert load_conv(DB, conv)[1] == [{"user": "what time is it", "reply": "It is noon.",
-                                           "tools": ["now"]}]
+                                           "tools": ["now"], "files": []}]
         # The tool result went to the model but history keeps a placeholder.
         assert load_conv(DB, conv)[0][0][2] == {"role": "tool", "tool_call_id": "c1",
                                                 "content": "(shown to the user at the time)"}
@@ -888,6 +975,32 @@
         seen = until("conversations")
         assert {"type": "conversation", "id": None, "turns": []} in seen   # was current
         assert seen[-1]["items"] == []
+        # Files: the text inline, the image resolved, chips on the turn.
+        tiny_png(png)
+        script["replies"] = [[{"content": "Red."}]]
+        send(type="ask", text="what is it?", files=[pdf, png])
+        user = until("user")[-1]
+        assert user["files"][1] == {"name": "red.png", "kind": "image", "truncated": False}
+        until("done")
+        q = script["body"]["messages"][-1]["content"]
+        assert "hello pdf" in q[0]["text"] and q[0]["text"].endswith("what is it?")
+        assert [x["type"] for x in q] == ["text", "image_url", "image_url"]
+        assert cur["turns"][-1]["files"] == user["files"]
+        # Only files, no text.
+        script["replies"] = [[{"content": "Code."}]]
+        send(type="ask", text="", files=[code])
+        assert until("user")[-1]["text"] == ""
+        until("done")
+        # A model without vision is refused before anything is sent.
+        script["inputs"] = ["text"]
+        send(type="ask", text="see?", files=[png])
+        e = until("error")[-1]
+        assert e["message"] == "m cannot see images" and e["turn"] is True
+        script["inputs"] = ["text", "image"]
+        send(type="ask", text="x", files=[other])
+        assert "chat supports" in until("error")[-1]["message"]
+        send(type="ask", text="x", files="not a list")
+        assert until("error")[-1]["message"] == "bad files"
         # llama-server down: an error, not a dead thread.
         CFG["llm"] = "http://127.0.0.1:9/v1"
         send(type="ask", text="anyone?")
```

- [ ] **Step 2: Run them to make sure they fail**

Run: `/usr/bin/python3 assistant.py --test`
Expected: an `AssertionError` at the first `shown == [...]` comparison (the turns have no `files` yet).

- [ ] **Step 3: Implement**

Save the block below as `att-impl.patch` and run `git apply -p1 <scratchpad>/att-impl.patch`.

```diff
--- a/assistant.py	2026-10-16 15:05:02.310910000 +0200
+++ b/assistant.py	2026-10-16 15:05:02.311749928 +0200
@@ -21,8 +21,11 @@
 Run: python3 assistant.py        (--test runs the self-check)
 """
 
+import base64
 import glob
+import hashlib
 import json
+import mimetypes
 import os
 import re
 import signal
@@ -147,25 +150,30 @@
     conn.execute("PRAGMA journal_mode=WAL")
     conn.execute("PRAGMA foreign_keys=ON")
     conn.executescript(SCHEMA)
+    # Added with attachments; a database from before them gains the column.
+    if "files" not in {r[1] for r in conn.execute("PRAGMA table_info(turns)")}:
+        conn.execute("ALTER TABLE turns ADD COLUMN files TEXT")
     return conn
 
 
-def save_turn(conn, conv, user, reply, tools, messages):
+def save_turn(conn, conv, user, reply, tools, messages, files=()):
     # Returns the conversation id: the row is made at its first finished turn,
-    # so a New that is never used leaves nothing behind.
+    # so a New that is never used leaves nothing behind. A question that is
+    # only files is titled by their names.
     now = int(time.time())
+    title = " ".join(user.split()[:6]) or ", ".join(f["name"] for f in files)
     with conn:
         if conv is None:
             conv = conn.execute("INSERT INTO conversations(title, created, updated) "
-                                "VALUES (?, ?, ?)",
-                                (" ".join(user.split()[:6]), now, now)).lastrowid
+                                "VALUES (?, ?, ?)", (title, now, now)).lastrowid
         else:
             conn.execute("UPDATE conversations SET updated = ? WHERE id = ?", (now, conv))
         seq = conn.execute("SELECT COALESCE(MAX(seq), 0) + 1 FROM turns WHERE conv = ?",
                            (conv,)).fetchone()[0]
-        conn.execute("INSERT INTO turns(conv, seq, user, reply, tools, messages) "
-                     "VALUES (?, ?, ?, ?, ?, ?)",
-                     (conv, seq, user, reply, json.dumps(tools), json.dumps(messages)))
+        conn.execute("INSERT INTO turns(conv, seq, user, reply, tools, messages, files) "
+                     "VALUES (?, ?, ?, ?, ?, ?, ?)",
+                     (conv, seq, user, reply, json.dumps(tools), json.dumps(messages),
+                      json.dumps(list(files))))
     return conv
 
 
@@ -176,12 +184,13 @@
 
 def load_conv(conn, conv):
     # (model history, shown turns), or None for an id that is not there.
-    rows = conn.execute("SELECT user, reply, tools, messages FROM turns WHERE conv = ? "
-                        "ORDER BY seq", (conv,)).fetchall()
+    rows = conn.execute("SELECT user, reply, tools, messages, files FROM turns "
+                        "WHERE conv = ? ORDER BY seq", (conv,)).fetchall()
     if not rows:
         return None
-    return ([json.loads(m) for *_, m in rows],
-            [{"user": u, "reply": r, "tools": json.loads(t)} for u, r, t, _ in rows])
+    return ([json.loads(m) for _, _, _, m, _ in rows],
+            [{"user": u, "reply": r, "tools": json.loads(t), "files": json.loads(f or "[]")}
+             for u, r, t, _, f in rows])
 
 
 def search(conn, q):
@@ -209,6 +218,134 @@
         conn.execute("DELETE FROM conversations WHERE id = ?", (conv,))
 
 
+# Attachments. Paths come from the canvas; the daemon runs as the user and
+# reads them itself. Text, and a PDF's text, go inline and are stored that
+# way, so a reopened conversation still has them. Images are stored as a
+# path and hash and read again when sent, so the history does not grow by
+# every picture, and a file changed since is reported gone rather than
+# shown as something it no longer is.
+CODE_SUFFIXES = {
+    ".py", ".c", ".h", ".cpp", ".hpp", ".rs", ".go", ".js", ".ts", ".jsx",
+    ".tsx", ".sh", ".bash", ".zsh", ".lua", ".rb", ".pl", ".php", ".java",
+    ".kt", ".swift", ".sql", ".toml", ".yaml", ".yml", ".json", ".ini",
+    ".cfg", ".conf", ".md", ".rst", ".txt", ".csv", ".xml", ".html", ".css",
+    ".diff", ".patch", ".slackbuild", ".info", ".desktop", ".service", ".qml",
+}
+IMAGE_TYPES = {"image/png", "image/jpeg", "image/gif", "image/webp"}
+MAX_FILES = 8
+MAX_IMAGE = 20 << 20
+MAX_PAGE_IMAGES = 4                       # scanned PDF pages sent as images
+
+
+class Refused(Exception):
+    """A file or request the user has to change; logged without a trace."""
+
+
+def kind_of(path):
+    mime = mimetypes.guess_type(path)[0] or ""
+    if mime in IMAGE_TYPES:
+        return "image"
+    if mime == "application/pdf":
+        return "pdf"
+    if mime.startswith("text/") or os.path.splitext(path)[1].lower() in CODE_SUFFIXES:
+        return "text"
+    return "other"
+
+
+def sha256(path):
+    h = hashlib.sha256()
+    with open(path, "rb") as f:
+        for chunk in iter(lambda: f.read(1 << 20), b""):
+            h.update(chunk)
+    return h.hexdigest()
+
+
+def pdf_pages(path):
+    out = subprocess.run(["pdftotext", "-layout", path, "-"], capture_output=True,
+                         text=True, timeout=60)
+    if out.returncode:
+        last = out.stderr.strip().splitlines()[-1:] or ["pdftotext failed"]
+        raise Refused(f"cannot read {os.path.basename(path)}: {last[0]}")
+    pages = out.stdout.split("\f")
+    return pages[:-1] if out.stdout.endswith("\f") else pages   # each page ends in \f
+
+
+def attach(paths, budget):
+    # (text blocks, image references, chips) for the files; Refused says
+    # what is wrong with the first bad one. Text files and PDFs share the
+    # budget of characters equally.
+    if len(paths) > MAX_FILES:
+        raise Refused(f"at most {MAX_FILES} files")
+    loaded = []
+    for p in paths:
+        name = os.path.basename(p) or p
+        if not (os.path.isabs(p) and os.path.isfile(p) and os.access(p, os.R_OK)):
+            raise Refused(f"cannot read {name}")
+        kind = kind_of(p)
+        if kind == "other":
+            raise Refused(f"{name}: chat supports text, images and PDF")
+        if kind == "image" and os.path.getsize(p) > MAX_IMAGE:
+            raise Refused(f"{name}: images over 20 MB are refused")
+        loaded.append((p, name, kind))
+    share = budget // max(1, sum(k != "image" for _, _, k in loaded))
+    blocks, refs, chips = [], [], []
+    for p, name, kind in loaded:
+        chip = {"name": name, "kind": kind, "truncated": False}
+        chips.append(chip)
+        if kind == "image":
+            refs.append({"type": "image_ref", "name": name, "path": p, "sha256": sha256(p)})
+            continue
+        if kind == "pdf":
+            pages = pdf_pages(p)
+            chip["pages"] = len(pages)
+            body = "\n\n".join(f"[page {i}]\n{t.rstrip()}" for i, t in enumerate(pages, 1))
+            # A page with no text is a scan: the model reads it as an image.
+            blank = [i for i, t in enumerate(pages, 1) if not t.strip()][:MAX_PAGE_IMAGES]
+            digest = sha256(p) if blank else ""
+            refs += [{"type": "image_ref", "name": f"{name} page {n}", "path": p,
+                      "sha256": digest, "page": n} for n in blank]
+        else:
+            with open(p, "rb") as f:          # no more than the share could use
+                body = f.read(share * 4 + 4).decode("utf-8", "replace")
+        if len(body) > share:
+            body, chip["truncated"] = body[:share], True
+        note = " (truncated)" if chip["truncated"] else ""
+        blocks.append(f"--- file: {name}{note} ---\n{body}\n--- end file ---")
+    return blocks, refs, chips
+
+
+def resolve(part):
+    # An image reference back into an image the model can see, or a note
+    # that it is gone: moved, deleted, or changed since it was sent.
+    if part.get("type") != "image_ref":
+        return part
+    gone = {"type": "text", "text": f"[image {part['name']} is no longer available]"}
+    try:
+        if sha256(part["path"]) != part["sha256"]:
+            return gone
+        if "page" in part:
+            n = str(part["page"])
+            out = subprocess.run(["pdftoppm", "-f", n, "-l", n, "-r", "150", "-png", part["path"]],
+                                 capture_output=True, timeout=60)
+            if out.returncode or not out.stdout:
+                return gone
+            data, mime = out.stdout, "image/png"
+        else:
+            with open(part["path"], "rb") as f:
+                data = f.read()
+            mime = mimetypes.guess_type(part["path"])[0]
+    except (OSError, subprocess.TimeoutExpired):
+        return gone
+    return {"type": "image_url",
+            "image_url": {"url": f"data:{mime};base64,{base64.b64encode(data).decode()}"}}
+
+
+def wire(messages):
+    # What is sent: the stored messages with their image references resolved.
+    return [{**m, "content": [resolve(p) for p in m["content"]]}
+            if isinstance(m.get("content"), list) else m for m in messages]
+
+
 # The canvas's feed: JSON lines on a Unix socket, both ways. Every client
 # gets every event. A client that stalls for 2 s is dropped rather than
 # holding up the others.
@@ -354,6 +491,9 @@
     # equal an unsaved conversation's None.
     bad = ("bad id" if kind in ("open", "delete") and type(cmd.get("id")) is not int
            else "bad text" if kind == "ask" and not isinstance(cmd.get("text"), str)
+           else "bad files" if kind == "ask" and not (
+               isinstance(cmd.get("files", []), list)
+               and all(isinstance(f, str) for f in cmd.get("files", [])))
            else "bad query" if kind == "search" and not isinstance(cmd.get("q"), str)
            else None)
     if bad:
@@ -372,10 +512,10 @@
 def command(kind, cmd):
     # Caller holds lock; arguments are already checked.
     if kind == "ask":
-        text = cmd["text"].strip()
-        if text:
+        text, files = cmd["text"].strip(), cmd.get("files", [])
+        if text or files:
             interrupt()
-            threading.Thread(target=reply, args=(turn, text), daemon=True).start()
+            threading.Thread(target=reply, args=(turn, text, files), daemon=True).start()
     elif kind == "stop":
         interrupt()
     elif kind == "new":
@@ -474,6 +614,16 @@
                 models[0]["id"])
 
 
+def sees_images(model):
+    # The router reports each model's inputs; a server that does not is
+    # left to decide for itself.
+    with urllib.request.urlopen(CFG["llm"] + "/models", timeout=10) as r:
+        models = json.load(r)["data"]
+    m = next((m for m in models if m["id"] == model), {})
+    inputs = (m.get("architecture") or {}).get("input_modalities")
+    return inputs is None or "image" in inputs
+
+
 def ask(messages, calls, tools=None):
     # Yields ("think", text) and ("token", text) as they stream; tool-call
     # fragments go into calls.
@@ -540,11 +690,13 @@
         return True
 
 
-def reply(mine, text):
+def reply(mine, text, files=()):
     try:
-        answer(mine, text)
+        answer(mine, text, files)
     except Exception as e:
-        log("reply failed:\n" + traceback.format_exc().rstrip())
+        # A refused file is the user's to fix, not a bug: one line, no trace.
+        log(f"refused: {e}" if isinstance(e, Refused)
+            else "reply failed:\n" + traceback.format_exc().rstrip())
         with lock:
             if turn == mine:
                 cur["pending"] = None
@@ -554,16 +706,25 @@
                 emit({"type": "state", "state": "idle"})
 
 
-def answer(mine, text):
+def answer(mine, text, files=()):
+    blocks, refs, chips = [], [], []
+    if files:
+        # Half of what the context has free, at about 3 characters a token.
+        free = (ctx["max"] - ctx["used"]) // 2 * 3 if ctx["max"] else 24000
+        blocks, refs, chips = attach(files, max(free, 2000))
+        model = llm_model()
+        if refs and not sees_images(model):
+            raise Refused(f"{model} cannot see images")
     with lock:
         if turn != mine:
             return
         history = list(cur["history"])
-        cur["pending"] = {"user": text, "reply": "", "think": "", "tools": []}
-        emit({"type": "user", "text": text})
+        cur["pending"] = {"user": text, "reply": "", "think": "", "tools": [], "files": chips}
+        emit({"type": "user", "text": text, "files": chips})
         emit({"type": "state", "state": "thinking"})
-    log(f"you: {text}")
-    question = {"role": "user", "content": text}
+    log(f"you: {text}" + "".join(f" [{c['name']}]" for c in chips))
+    body = "\n\n".join(blocks + [text] if text else blocks)
+    question = {"role": "user", "content": [{"type": "text", "text": body}] + refs if refs else body}
     # The model has no clock: without the date it makes one up for tools.
     # Also stamped on the question itself, which history does not keep: with
     # the time only in the system prompt, "what time is it?" asked again an
@@ -573,7 +734,8 @@
     # ponytail: last 10 turns, summarise if long sessions need memory
     msgs = ([{"role": "system", "content": f"{CFG['system']} It is {now}."}]
             + [m for past in history[-10:] for m in past]
-            + [{"role": "user", "content": f"[{now}] {text}"}])
+            + [{"role": "user", "content": [{"type": "text", "text": f"[{now}] {body}"}] + refs
+                if refs else f"[{now}] {body}"}])
     first = len(msgs)                            # this turn's tool messages start here
     said, used = "", []
     # ponytail: a stopped reply notices at its next chunk, so llama-server's
@@ -581,7 +743,8 @@
     for rnd in range(CFG["tool_rounds"] + 1):
         calls, content = {}, ""
         # The last round offers no tools, which forces an answer.
-        for kind, piece in ask(msgs, calls, TOOL_SCHEMA if rnd < CFG["tool_rounds"] else None):
+        for kind, piece in ask(wire(msgs), calls,
+                               TOOL_SCHEMA if rnd < CFG["tool_rounds"] else None):
             if not say(mine, kind, piece):
                 log("interrupted")
                 return
@@ -619,9 +782,9 @@
         if turn != mine:
             log("interrupted")
             return
-        cur["id"] = save_turn(DB, cur["id"], text, said, used, entry)
+        cur["id"] = save_turn(DB, cur["id"], text, said, used, entry, chips)
         cur["history"].append(entry)
-        cur["turns"].append({"user": text, "reply": said, "tools": used})
+        cur["turns"].append({"user": text, "reply": said, "tools": used, "files": chips})
         cur["pending"] = None
         emit({"type": "done", "id": cur["id"]})
         emit({"type": "state", "state": "idle"})
```

- [ ] **Step 4: Run the self-check three times**

Run: `for i in 1 2 3; do /usr/bin/python3 assistant.py --test 2>&1 | tail -1; done`
Expected: `ok` three times.

- [ ] **Step 5: Commit**

```bash
git add assistant.py
git commit -m "Take files with a question

ask carries paths; the daemon reads them as the user. Text files and a
PDF's text go inline within half the free context, shared equally, and
are stored that way, so a reopened conversation still has them. Images,
and PDF pages with no text, go as image parts to a model the router
reports as seeing images, and are stored as a path and hash, resolved
when sent: a file changed or gone since is reported as no longer
available. turns gains a files column for the chips, added to an older
database on open. A refused file is one log line, not a traceback.

Co-Authored-By: <model making the commit> <noreply@anthropic.com>"
```

---

### Task 2: Docs

**Files:**
- Modify: `README.md`, `AGENTS.md`, `docs/superpowers/specs/2026-10-16-attachments-design.md`

- [ ] **Step 1: README**

In `## Protocol`, change the In list's `ask {text}` to `ask {text, files}` and add after the Out paragraph:

```markdown
`files` is a list of absolute paths, at most 8. Text and code files and
PDFs are read and inlined (a PDF page with no text goes as an image);
images go as image parts to a model that reports seeing them. History
keeps the text and, for images, the path and hash: a file that changed or
moved is reported as no longer available when the conversation is
reopened. Requirements gain poppler's `pdftotext` and `pdftoppm`.
```

and add `- poppler (`pdftotext`, `pdftoppm`) for PDF attachments` to `## Requirements`.

- [ ] **Step 2: AGENTS.md findings**

Under `## Findings`, before `### Text daemon, live check (2026-10-16)`, add:

```markdown
### Attachments, live check (2026-10-16)

- An image reading "BLUE 42" (`magick`, 400x120) was answered `BLUE 42`,
  first token at 6.1 s, ctx 1242 / 32768.
- A two-page PDF, a text page and an image-only page, was answered with
  facts from both: the text page went inline, the image-only page as a
  150 dpi `pdftoppm` render.
- tesseract is installed with no language data, so OCR is the model's
  vision, not tesseract.
- A Unix socket path is limited to 108 bytes: a test socket under a deep
  scratch directory fails with `AF_UNIX path too long`.
```

- [ ] **Step 3: Spec status**

Change the spec's `Status:` to `implemented (2026-10-16), live-checked.`

- [ ] **Step 4: Check and commit**

Run: `grep -nP "\x{2014}" README.md AGENTS.md docs/superpowers/specs/2026-10-16-attachments-design.md` → no output.

```bash
git add README.md AGENTS.md docs/superpowers/specs/2026-10-16-attachments-design.md
git commit -m "Docs: attachments

Co-Authored-By: <model making the commit> <noreply@anthropic.com>"
git push
```