fix(build): keep debug features out of release builds

GitHub Actions always sets GITHUB_WORKFLOW, so every release APK built by CI turned ENABLE_DEBUG_FEATURES on: debug logcat logging and the strict VM policy. Nothing sets SNAPSHOT any more, so release is simply false. The debug logging preference still works.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1 files changed, 1 insertions, 9 deletions

diff --git a/build-logic/src/main/kotlin/app/passwordstore/gradle/ApplicationPlugin.kt b/build-logic/src/main/kotlin/app/passwordstore/gradle/ApplicationPlugin.kt
index 47409d11..b6332b6a 100644
--- a/build-logic/src/main/kotlin/app/passwordstore/gradle/ApplicationPlugin.kt
+++ b/build-logic/src/main/kotlin/app/passwordstore/gradle/ApplicationPlugin.kt
@@ -48,7 +48,7 @@ class ApplicationPlugin : Plugin<Project> {
               "proguard-rules-missing-classes.pro",
             )
           )
-          buildConfigField("boolean", "ENABLE_DEBUG_FEATURES", "${project.isSnapshot()}")
+          buildConfigField("boolean", "ENABLE_DEBUG_FEATURES", "false")
           buildConfigField("String", "GIT_COMMIT", "\"\"")
         }
         named("debug") {
@@ -63,12 +63,4 @@ class ApplicationPlugin : Plugin<Project> {
       project.configureBuildSigning()
     }
   }
-
-  private fun Project.isSnapshot(): Boolean {
-    with(providers) {
-      val workflow = environmentVariable("GITHUB_WORKFLOW")
-      val snapshot = environmentVariable("SNAPSHOT")
-      return workflow.isPresent || snapshot.isPresent
-    }
-  }
 }