build: update to Gradle 9.8.2, AGP 9.5.0, Kotlin 2.4.21, Hilt 2.60.1

AGP 9 migration:
- Configure the shared Android setup through the new DSL
  (CommonExtension, ApplicationExtension) instead of the removed
  TestedExtension and BaseAppModuleExtension; targetSdk moves to the
  application extension.
- Stop applying the Kotlin Android plugin; AGP 9 compiles Kotlin itself.
- Replace kapt with KSP 2.3.13 for Hilt, which built-in Kotlin requires,
  and carry the Dagger compiler options over as KSP arguments.
- AGP 9 now applies packaging excludes to unit-test resources, which
  stripped the diceware word list (**/*.txt) from its tests; lift that
  exclude in the diceware module.
- Use resources.directories instead of the deprecated srcDir.

Plugin updates required by Gradle 9 / AGP 9: Sentry Gradle plugin
6.25.0 (sentry-android 8.62.0), metalava plugin 0.5.1, maven-publish
0.37.0, spotless 8.10.4, version-catalog-update 1.1.2, download task
5.7.0, foojay resolver 1.0.0, with their API changes. Newer metalava
models Kotlin properties, so autofill-parser/api.txt is regenerated;
the diff is representation only, no API was added or removed.

Fix new Kotlin 2.4 and lint findings (explicit return type in a
function with an early return, UseKtx in autofill-parser), drop
deprecated Kotlin Gradle properties, and make the AGENTS.md pre-commit
command cover every task CI runs (both flavors, lint on all modules).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1 files changed, 1 insertions, 6 deletions

diff --git a/build-logic/src/main/kotlin/app/passwordstore/gradle/PublishedAndroidLibraryPlugin.kt b/build-logic/src/main/kotlin/app/passwordstore/gradle/PublishedAndroidLibraryPlugin.kt
index 4e1ab741..055a921a 100644
--- a/build-logic/src/main/kotlin/app/passwordstore/gradle/PublishedAndroidLibraryPlugin.kt
+++ b/build-logic/src/main/kotlin/app/passwordstore/gradle/PublishedAndroidLibraryPlugin.kt
@@ -10,8 +10,6 @@ package app.passwordstore.gradle
 import com.vanniktech.maven.publish.AndroidMultiVariantLibrary
 import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import com.vanniktech.maven.publish.MavenPublishBasePlugin
-import com.vanniktech.maven.publish.SonatypeHost
-import me.tylerbwong.gradle.metalava.Documentation
 import me.tylerbwong.gradle.metalava.extension.MetalavaExtension
 import org.gradle.api.Plugin
 import org.gradle.api.Project
@@ -28,7 +26,7 @@ class PublishedAndroidLibraryPlugin : Plugin<Project> {
       apply("me.tylerbwong.gradle.metalava")
     }
     project.extensions.configure<MavenPublishBaseExtension> {
-      publishToMavenCentral(SonatypeHost.DEFAULT, true)
+      publishToMavenCentral(automaticRelease = true)
       if (project.providers.environmentVariable("CI").isPresent) {
         signAllPublications()
       }
@@ -36,10 +34,7 @@ class PublishedAndroidLibraryPlugin : Plugin<Project> {
       pomFromGradleProperties()
     }
     project.extensions.configure<MetalavaExtension> {
-      documentation.set(Documentation.PUBLIC)
       inputKotlinNulls.set(true)
-      outputKotlinNulls.set(true)
-      reportLintsAsErrors.set(true)
       reportWarningsAsErrors.set(true)
     }
   }