Fix lint warnings (#319)

* Fix lint errors/warnings

Fix a lot of lint errors and warnings.
Most things are automatically applied fixes done with android studio:

* externalize strings
* remove unused code / classes / layouts / imports
* migrate some fields to local variables

* Remove dead code from comments

Removed code that is commented out long ago.

* remove unused resources

* colors
* strings
* drawables
* layouts
* menus

4 files changed, 16 insertions, 22 deletions

diff --git a/app/src/main/res/menu/agp_intents.xml b/app/src/main/res/menu/agp_intents.xml
deleted file mode 100644
index 8aa52dfa..00000000
--- a/app/src/main/res/menu/agp_intents.xml
+++ /dev/null
@@ -1,9 +0,0 @@
-<menu xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
-    xmlns:pwstore="http://schemas.android.com/apk/res-auto"
-    tools:context="com.zeapo.pwdstore.AgpIntentsActivity" >
-    <item android:id="@+id/action_settings"
-        android:title="@string/action_settings"
-        android:orderInCategory="100"
-        pwstore:showAsAction="never" />
-</menu>
diff --git a/app/src/main/res/menu/context_pass.xml b/app/src/main/res/menu/context_pass.xml
index bcdb383c..cb1e9ee9 100644
--- a/app/src/main/res/menu/context_pass.xml
+++ b/app/src/main/res/menu/context_pass.xml
@@ -1,22 +1,25 @@
 <menu xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
     xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
     tools:context=".pwdstore">
 
-    <item android:id="@+id/menu_move_password"
+    <item
+        android:id="@+id/menu_move_password"
         android:icon="@drawable/ic_folder_white_24dp"
-        app:showAsAction="ifRoom"
-        android:title="Move"/>
+        android:title="@string/move"
+        app:showAsAction="ifRoom" />
 
-    <item android:id="@+id/menu_edit_password"
+    <item
+        android:id="@+id/menu_edit_password"
         android:icon="@drawable/ic_edit_white_24dp"
-        app:showAsAction="ifRoom"
-        android:title="Edit"/>
+        android:title="@string/edit"
+        app:showAsAction="ifRoom" />
 
-    <item android:id="@+id/menu_delete_password"
+    <item
+        android:id="@+id/menu_delete_password"
         android:icon="@drawable/ic_delete_white_24dp"
-        app:showAsAction="ifRoom"
-        android:title="Delete"/>
+        android:title="@string/delete"
+        app:showAsAction="ifRoom" />
 
 </menu>
 
diff --git a/app/src/main/res/menu/pgp_handler_new_password.xml b/app/src/main/res/menu/pgp_handler_new_password.xml
index 0e2ef32c..6c7e12c9 100644
--- a/app/src/main/res/menu/pgp_handler_new_password.xml
+++ b/app/src/main/res/menu/pgp_handler_new_password.xml
@@ -2,12 +2,12 @@
     xmlns:tools="http://schemas.android.com/tools"
     xmlns:pwstore="http://schemas.android.com/apk/res-auto"
     tools:context="com.zeapo.pwdstore.crypto.PgpHandler" >
-    <item android:title="Cancel"
+    <item android:title="@string/crypto_cancel"
         android:icon="@drawable/ic_clear_white_24dp"
         pwstore:showAsAction="ifRoom"
         android:id="@+id/crypto_cancel_add"
         />
-    <item android:title="Save"
+    <item android:title="@string/crypto_save"
         android:icon="@drawable/ic_done_white_24dp"
         pwstore:showAsAction="ifRoom"
         android:id="@+id/crypto_confirm_add"
diff --git a/app/src/main/res/menu/pgp_handler_select_folder.xml b/app/src/main/res/menu/pgp_handler_select_folder.xml
index 9bfba01b..c18ede62 100644
--- a/app/src/main/res/menu/pgp_handler_select_folder.xml
+++ b/app/src/main/res/menu/pgp_handler_select_folder.xml
@@ -3,7 +3,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     xmlns:pwstore="http://schemas.android.com/apk/res-auto"
     tools:context="com.zeapo.pwdstore.crypto.PgpHandler" >
-    <item android:title="Select"
+    <item android:title="@string/crypto_select"
         android:icon="@drawable/ic_done_white_24dp"
         pwstore:showAsAction="ifRoom"
         android:id="@+id/crypto_select"