Fix lint warnings (#319)

* Fix lint errors/warnings

Fix a lot of lint errors and warnings.
Most things are automatically applied fixes done with android studio:

* externalize strings
* remove unused code / classes / layouts / imports
* migrate some fields to local variables

* Remove dead code from comments

Removed code that is commented out long ago.

* remove unused resources

* colors
* strings
* drawables
* layouts
* menus

1 files changed, 12 insertions, 11 deletions

diff --git a/app/src/main/res/layout/decrypt_layout.xml b/app/src/main/res/layout/decrypt_layout.xml
index 2a94dfee..f076dbad 100644
--- a/app/src/main/res/layout/decrypt_layout.xml
+++ b/app/src/main/res/layout/decrypt_layout.xml
@@ -19,26 +19,28 @@
             android:orientation="vertical">
 
             <TextView
+                android:id="@+id/crypto_password_category"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:textColor="@color/grey_500"
-                android:text="CATEGORY HERE"
-                android:id="@+id/crypto_password_category"
                 android:layout_gravity="center_vertical"
-                android:textSize="18dp"
+                android:layout_marginLeft="16dp"
+                android:text="CATEGORY HERE"
+                android:textColor="@color/grey_500"
                 android:textIsSelectable="false"
-                android:layout_marginLeft="16dp" />
+                android:textSize="18dp"
+                tools:ignore="HardcodedText" />
 
             <TextView
+                android:id="@+id/crypto_password_file"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
+                android:layout_marginLeft="@dimen/activity_horizontal_margin"
+                android:text="PASSWORD FILE NAME HERE"
+                android:textAppearance="@android:style/TextAppearance.DeviceDefault.Medium"
                 android:textColor="@color/accent"
+                android:textSize="24dp"
                 android:textStyle="bold"
-                android:textAppearance="@android:style/TextAppearance.DeviceDefault.Medium"
-                android:text="PASSWORD FILE NAME HERE"
-                android:id="@+id/crypto_password_file"
-                android:layout_marginLeft="@dimen/activity_horizontal_margin"
-                android:textSize="24dp" />
+                tools:ignore="HardcodedText" />
         </LinearLayout>
 
         <ImageView
@@ -170,5 +172,4 @@
 
     </LinearLayout>
 
-
 </ScrollView>
\ No newline at end of file