aboutsummaryrefslogtreecommitdiffstats
path: root/TODO-icons.md
diff options
context:
space:
mode:
Diffstat (limited to 'TODO-icons.md')
-rw-r--r--TODO-icons.md50
1 files changed, 50 insertions, 0 deletions
diff --git a/TODO-icons.md b/TODO-icons.md
new file mode 100644
index 0000000..ac904f7
--- /dev/null
+++ b/TODO-icons.md
@@ -0,0 +1,50 @@
+# Unhardcode the icon theme
+
+Done. The active icon theme is now read from
+`gsettings get org.gnome.desktop.interface icon-theme`, which is what the
+appearance drawer's Icons tab sets, so a switch there reaches this bar instead
+of being silently reverted.
+
+## How it works
+
+`bin/wb-icon` reads the gsettings key once and resolves names through GTK's
+icon lookup. Nothing else may assume a path shape: themes disagree about both
+the subdirectory and the file extension (the Suru themes keep `web-browser` at
+`categories/22/*.svg`, elementary-xfce at `apps/22/*.png`), so substituting one
+directory prefix would have broken on any non-Suru theme.
+
+Two new modes serve `install.sh`:
+
+- `wb-icon --path NAME` prints one absolute path
+- `wb-icon --theme` prints the resolved theme name
+
+`styles/modules.css` names icons as `@ICON:name@` placeholders and
+`modules/extras/taskbar.jsonc` carries `@ICON_THEME@`; `install.sh` resolves
+both at install time. taskbar.jsonc is generated for this reason and is no
+longer symlinked.
+
+## After a theme switch
+
+Re-run `install.sh`, then **restart waybar**. CSS reloads itself through
+`reload_style_on_change`, but `taskbar.jsonc` is config: a signal is not enough.
+
+## Fixed elsewhere
+
+- `~/.config/rofi/config.rasi` — `icon-theme` commented out, so rofi follows
+ the desktop theme.
+- `~/.local/share/applications/firefox-clean.desktop` — absolute `Icon=` path
+ replaced with the bare name `firefox-aurora`, which the desktop-entry spec
+ resolves through the active theme (and which picks a 48px icon rather than
+ the 16px one that was pinned).
+
+## Not a conflict
+
+`~/.config/hypr/hyprqt6engine.conf`'s `icon_theme` is commented out.
+unified-desktop-theme's `templates/qt-gtk/*` are reference copies that nothing
+installs; see that repo's TODO-icons.md.
+
+## Caveat
+
+A theme lacking one of the 20 names this bar asks for fails the install at the
+`--selftest` step rather than rendering empty pills. elementary-xfce, for
+example, has no `text-editor` or `internet-chat`.