1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
|
/*
* qtmaildir - a Qt6 mail client for notmuch-indexed Maildirs
* Copyright (C) 2026 Danilo M. <danix@danix.xyz>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <QtTest>
#include <QTemporaryDir>
#include <QDir>
#include "mimeparser.h"
class TestMimeParser : public QObject
{
Q_OBJECT
private slots:
void initTestCase();
void parsesPlainText();
void prefersHtmlWhenAvailable();
void fallsBackToPlainWhenHtmlDisabled();
void collectsInlineCidParts();
void decodesQuotedPrintableAttachment();
void decodesEncodedHeaders();
void malformedMessageDoesNotCrash();
void missingFileIsReported();
void hostileFilenameIsSanitised();
void savedAttachmentMatchesBytes();
void safeFilenameStripsPathComponents();
void pathInsideDirectoryRejectsSiblingPrefix();
private:
QString fixture(const QString &name) const
{ return m_fixtureDir + QLatin1Char('/') + name; }
QString m_fixtureDir;
};
void TestMimeParser::initTestCase()
{
// FIXTURE_DIR is defined by CMake so the test can run from any cwd.
m_fixtureDir = QStringLiteral(FIXTURE_DIR);
QVERIFY2(QDir(m_fixtureDir).exists(), "fixture directory missing");
}
void TestMimeParser::parsesPlainText()
{
MimeParser parser;
const ParsedMessage msg = parser.parse(fixture(QStringLiteral("plain.eml")));
QVERIFY(msg.ok);
QCOMPARE(msg.subject, QStringLiteral("Plain hello"));
QCOMPARE(msg.from, QStringLiteral("Alice <alice@example.org>"));
QVERIFY(msg.plainBody.contains(QStringLiteral("Hello Bob.")));
QVERIFY(msg.htmlBody.isEmpty());
QVERIFY(msg.attachments.isEmpty());
}
void TestMimeParser::prefersHtmlWhenAvailable()
{
MimeParser parser;
const ParsedMessage msg =
parser.parse(fixture(QStringLiteral("alternative.eml")));
QVERIFY(msg.ok);
QVERIFY(msg.htmlBody.contains(QStringLiteral("html version")));
// The plain alternative is kept so the user can toggle to it.
QVERIFY(msg.plainBody.contains(QStringLiteral("plain version")));
QVERIFY(msg.hasHtml());
}
void TestMimeParser::fallsBackToPlainWhenHtmlDisabled()
{
MimeParser parser;
const ParsedMessage msg = parser.parse(fixture(QStringLiteral("plain.eml")));
QVERIFY(!msg.hasHtml());
QVERIFY(!msg.plainBody.isEmpty());
}
void TestMimeParser::collectsInlineCidParts()
{
MimeParser parser;
const ParsedMessage msg =
parser.parse(fixture(QStringLiteral("inline_image.eml")));
QVERIFY(msg.ok);
QCOMPARE(msg.inlineParts.size(), 1);
// Content-ID angle brackets are stripped so it matches the cid: URL body.
QVERIFY(msg.inlineParts.contains(QStringLiteral("logo@example.org")));
const InlinePart part = msg.inlineParts.value(QStringLiteral("logo@example.org"));
QCOMPARE(part.mimeType, QStringLiteral("image/png"));
// Decoded 1x1 PNG starts with the PNG magic bytes.
QVERIFY(part.data.startsWith(QByteArray("\x89PNG", 4)));
}
void TestMimeParser::decodesQuotedPrintableAttachment()
{
MimeParser parser;
const ParsedMessage msg =
parser.parse(fixture(QStringLiteral("attachment.eml")));
QVERIFY(msg.ok);
QCOMPARE(msg.attachments.size(), 1);
QCOMPARE(msg.attachments.first().filename, QStringLiteral("notes.txt"));
QCOMPARE(QString::fromUtf8(msg.attachments.first().data),
QStringLiteral("café notes"));
}
void TestMimeParser::decodesEncodedHeaders()
{
MimeParser parser;
const ParsedMessage msg =
parser.parse(fixture(QStringLiteral("encoded_subject.eml")));
QVERIFY(msg.ok);
QCOMPARE(msg.subject, QStringLiteral("Café meeting"));
QVERIFY(msg.from.contains(QStringLiteral("Älice")));
}
void TestMimeParser::malformedMessageDoesNotCrash()
{
MimeParser parser;
const ParsedMessage msg =
parser.parse(fixture(QStringLiteral("truncated.eml")));
// GMime is tolerant: it recovers the headers and whatever body it found.
// The requirement is only that parsing terminates and reports something.
QCOMPARE(msg.subject, QStringLiteral("Truncated"));
}
void TestMimeParser::missingFileIsReported()
{
MimeParser parser;
const ParsedMessage msg =
parser.parse(fixture(QStringLiteral("does_not_exist.eml")));
QVERIFY(!msg.ok);
QVERIFY(!msg.error.isEmpty());
}
void TestMimeParser::hostileFilenameIsSanitised()
{
MimeParser parser;
const ParsedMessage msg =
parser.parse(fixture(QStringLiteral("hostile_filename.eml")));
QVERIFY(msg.ok);
QCOMPARE(msg.attachments.size(), 1);
// The raw header value is preserved for display...
QVERIFY(msg.attachments.first().filename.contains(QStringLiteral("..")));
// ...but the name used on disk is reduced to a basename.
QCOMPARE(msg.attachments.first().safeFilename(), QStringLiteral("pwned.txt"));
}
void TestMimeParser::savedAttachmentMatchesBytes()
{
MimeParser parser;
const ParsedMessage msg =
parser.parse(fixture(QStringLiteral("attachment.eml")));
QVERIFY(msg.ok);
QTemporaryDir dir;
QString error;
const QString written =
msg.attachments.first().saveTo(dir.path(), &error);
QVERIFY2(!written.isEmpty(), qPrintable(error));
// Never escapes the target directory.
QVERIFY(written.startsWith(dir.path()));
QFile f(written);
QVERIFY(f.open(QIODevice::ReadOnly));
QCOMPARE(f.readAll(), msg.attachments.first().data);
}
void TestMimeParser::safeFilenameStripsPathComponents()
{
// This is the control that genuinely stops traversal: saveTo() always
// routes through safeFilename() first, so whatever this function
// guarantees is what actually protects a write to disk. Constructed by
// hand since these are adversarial names not tied to any fixture.
Attachment a;
a.mimeType = QStringLiteral("text/plain");
a.data = QByteArrayLiteral("x");
a.filename = QStringLiteral("../../../../tmp/pwned.txt");
QCOMPARE(a.safeFilename(), QStringLiteral("pwned.txt"));
a.filename = QStringLiteral("../xyz-evil/x.txt");
QCOMPARE(a.safeFilename(), QStringLiteral("x.txt"));
a.filename = QStringLiteral("..\\..\\windows\\evil.txt");
QCOMPARE(a.safeFilename(), QStringLiteral("evil.txt"));
a.filename = QStringLiteral("plain.txt");
QCOMPARE(a.safeFilename(), QStringLiteral("plain.txt"));
// Nothing usable remains: a generated name is produced instead. Assert
// its shape rather than an exact value, since it embeds a fresh UUID.
a.filename = QStringLiteral("..");
QString generated = a.safeFilename();
QVERIFY(!generated.isEmpty());
QVERIFY(generated != QStringLiteral(".."));
QVERIFY(!generated.contains(QLatin1Char('/')));
a.filename = QString();
generated = a.safeFilename();
QVERIFY(!generated.isEmpty());
QVERIFY(!generated.contains(QLatin1Char('/')));
}
void TestMimeParser::pathInsideDirectoryRejectsSiblingPrefix()
{
// Direct test of the containment guard's own comparison, independent of
// safeFilename() (which always runs first inside saveTo() and would
// mask a broken guard, since it never produces an escaping path). This
// targets exactly the defect that was found: a plain string
// startsWith() incorrectly treats a sibling directory whose name merely
// extends the target's name (e.g. "/tmp/safe-evil") as contained within
// it (e.g. "/tmp/safe").
const QString base = QStringLiteral("/tmp/safe");
QVERIFY(Attachment::isPathInsideDirectory(base, base + QStringLiteral("/notes.txt")));
QVERIFY(Attachment::isPathInsideDirectory(base, base + QStringLiteral("/sub/notes.txt")));
QVERIFY(Attachment::isPathInsideDirectory(base, base));
QVERIFY(!Attachment::isPathInsideDirectory(base, QStringLiteral("/tmp/safe-evil/x")));
QVERIFY(!Attachment::isPathInsideDirectory(base, QStringLiteral("/tmp/safe/../etc/passwd")));
QVERIFY(!Attachment::isPathInsideDirectory(base, QStringLiteral("/etc/passwd")));
}
QTEST_MAIN(TestMimeParser)
#include "test_mimeparser.moc"
|
