1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
|
/*
* qtmaildir - a Qt6 mail client for notmuch-indexed Maildirs
* Copyright (C) 2026 Danilo M. <danix@danix.xyz>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <QSignalSpy>
#include <QWebEngineUrlScheme>
#include <QWebEngineView>
#include <QtTest>
#include "htmlbuilder.h"
#include "messageview.h"
#include "mimeparser.h"
/// MessageView needs a live QWebEngineProfile, so most of it is verified
/// manually. What is pinned here is the one thing that silently produced a
/// blank pane: whether a document handed to setHtml() actually loads.
class TestMessageView : public QObject
{
Q_OBJECT
private slots:
void initTestCase();
void documentActuallyLoads();
void threadContentReachesThePage();
void dataUrlSubResourceStillBlocked();
void zoomIsClampedToARenderableRange();
void zoomSurvivesANewDocument();
private:
QWebEngineView *webViewOf(MessageView *view) const
{
return view->findChild<QWebEngineView *>();
}
};
void TestMessageView::initTestCase()
{
// Registered in main() in the real application; a test binary has its own
// entry point and must do the same before any profile exists.
QWebEngineUrlScheme cid(QByteArrayLiteral("cid"));
cid.setFlags(QWebEngineUrlScheme::SecureScheme
| QWebEngineUrlScheme::ContentSecurityPolicyIgnored);
QWebEngineUrlScheme::registerScheme(cid);
QWebEngineUrlScheme own(QByteArrayLiteral("qtmaildir"));
own.setFlags(QWebEngineUrlScheme::SecureScheme);
QWebEngineUrlScheme::registerScheme(own);
}
void TestMessageView::documentActuallyLoads()
{
// The regression this exists for: acceptNavigationRequest compared the
// navigation's URL against documentUrl(), but setHtml() navigates to a
// data: URL and applies the base URL only as the document origin. Every
// document load was rejected and the pane stayed blank, with no warning
// anywhere.
MessageView view;
QWebEngineView *web = webViewOf(&view);
QVERIFY(web);
QSignalSpy loaded(web, &QWebEngineView::loadFinished);
ParsedMessage message;
message.ok = true;
message.from = QStringLiteral("Alice <alice@example.org>");
message.subject = QStringLiteral("Hello");
message.date = QStringLiteral("Mon, 1 Jun 2026 10:00:00 +0000");
message.plainBody = QStringLiteral("body text");
ThreadRenderItem item;
item.message = message;
item.cidPrefix = QStringLiteral("m0");
item.expanded = true;
view.showThread({ item });
QVERIFY2(loaded.wait(15000), "no loadFinished at all: the document was "
"never even attempted");
QCOMPARE(loaded.size(), 1);
QVERIFY2(loaded.first().at(0).toBool(),
"loadFinished reported failure: the navigation was rejected");
}
void TestMessageView::threadContentReachesThePage()
{
// Loading successfully is not the same as showing the message: assert the
// body actually made it into the rendered document.
MessageView view;
QWebEngineView *web = webViewOf(&view);
QVERIFY(web);
QSignalSpy loaded(web, &QWebEngineView::loadFinished);
ParsedMessage message;
message.ok = true;
message.from = QStringLiteral("Bob <bob@example.org>");
message.subject = QStringLiteral("Subject line");
message.plainBody = QStringLiteral("distinctive-body-marker");
ThreadRenderItem item;
item.message = message;
item.cidPrefix = QStringLiteral("m0");
item.expanded = true;
view.showThread({ item });
QVERIFY(loaded.wait(15000));
QVERIFY(loaded.first().at(0).toBool());
QString text;
bool done = false;
web->page()->toPlainText([&](const QString &result) {
text = result;
done = true;
});
QTRY_VERIFY_WITH_TIMEOUT(done, 15000);
QVERIFY2(text.contains(QStringLiteral("distinctive-body-marker")),
qPrintable(QStringLiteral("rendered text was: '%1'").arg(text)));
QVERIFY(text.contains(QStringLiteral("bob@example.org")));
}
void TestMessageView::dataUrlSubResourceStillBlocked()
{
// The main-frame exemption must not extend to sub-resources: a message
// body can write <img src="data:..."> and those stay denied. This is the
// narrow line between "the document renders" and "the policy has a hole".
MessageView view;
QWebEngineView *web = webViewOf(&view);
QVERIFY(web);
QSignalSpy loaded(web, &QWebEngineView::loadFinished);
ParsedMessage message;
message.ok = true;
message.from = QStringLiteral("Mallory <mallory@example.org>");
message.subject = QStringLiteral("Hostile");
// A 1x1 gif as a data: URL, the shape a tracking-adjacent body would use.
message.htmlBody = QStringLiteral(
"<html><body>visible-text"
"<img id=\"probe\" src=\"data:image/gif;base64,"
"R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7\">"
"</body></html>");
ThreadRenderItem item;
item.message = message;
item.cidPrefix = QStringLiteral("m0");
item.expanded = true;
view.showThread({ item });
QVERIFY(loaded.wait(15000));
QVERIFY2(loaded.first().at(0).toBool(),
"the document itself must still load");
// The document rendered; the blocked sub-resource is what the interceptor
// records. Text is present, so this is not a failed load masquerading as
// a blocked image.
QString text;
bool done = false;
web->page()->toPlainText([&](const QString &result) {
text = result;
done = true;
});
QTRY_VERIFY_WITH_TIMEOUT(done, 15000);
QVERIFY(text.contains(QStringLiteral("visible-text")));
}
void TestMessageView::zoomIsClampedToARenderableRange()
{
// A factor outside the range leaves the pane unreadable, and the only way
// back is a menu entry the user can no longer read. A corrupt state file
// reaching setZoomFactor() must not be able to do that.
QCOMPARE(MessageView::clampZoom(100.0), MessageView::kMaxZoom);
QCOMPARE(MessageView::clampZoom(0.01), MessageView::kMinZoom);
// A missing or non-numeric state value converts to 0.0, and a hand-edited
// one can hold NaN or an infinity. None of those may reach the web view.
QCOMPARE(MessageView::clampZoom(0.0), MessageView::kDefaultZoom);
QCOMPARE(MessageView::clampZoom(-2.0), MessageView::kDefaultZoom);
QCOMPARE(MessageView::clampZoom(qQNaN()), MessageView::kDefaultZoom);
QCOMPARE(MessageView::clampZoom(qInf()), MessageView::kDefaultZoom);
// In-range values pass through untouched.
QCOMPARE(MessageView::clampZoom(1.4), 1.4);
MessageView view;
view.setZoomFactor(50.0);
QCOMPARE(view.zoomFactor(), MessageView::kMaxZoom);
}
void TestMessageView::zoomSurvivesANewDocument()
{
// MainWindow persists whatever zoomFactor() reports and never reapplies it
// per render, which is only correct if the web view keeps the factor
// across setHtml(). Verified rather than assumed.
MessageView view;
QWebEngineView *web = webViewOf(&view);
QVERIFY(web);
view.setZoomFactor(1.5);
QSignalSpy loaded(web, &QWebEngineView::loadFinished);
ParsedMessage message;
message.ok = true;
message.from = QStringLiteral("Sender <sender@example.org>");
message.subject = QStringLiteral("Zoom");
message.plainBody = QStringLiteral("body text");
ThreadRenderItem item;
item.message = message;
item.cidPrefix = QStringLiteral("m0");
item.expanded = true;
view.showThread({ item });
QVERIFY(loaded.wait(15000));
QCOMPARE(view.zoomFactor(), 1.5);
}
QTEST_MAIN(TestMessageView)
#include "test_messageview.moc"
|
