1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
|
#include <QtTest>
#include <QTemporaryDir>
#include <QSettings>
#include "keymap.h"
class TestKeyMap : public QObject
{
Q_OBJECT
private slots:
void defaultsAreLoaded();
void iniOverridesDefault();
void iniAddsNewBinding();
void chordSequenceParses();
void unknownActionIsReported();
void invalidSequenceIsReported();
void collidingOverridesAreReported();
};
void TestKeyMap::defaultsAreLoaded()
{
KeyMap map;
map.loadDefaults();
QCOMPARE(map.actionFor(QKeySequence(QStringLiteral("j"))),
QStringLiteral("next_thread"));
QCOMPARE(map.actionFor(QKeySequence(QStringLiteral("a"))),
QStringLiteral("archive"));
}
void TestKeyMap::iniOverridesDefault()
{
QTemporaryDir dir;
const QString path = dir.filePath(QStringLiteral("t.conf"));
{
QSettings s(path, QSettings::IniFormat);
s.beginGroup(QStringLiteral("keys"));
s.setValue(QStringLiteral("j"), QStringLiteral("archive"));
s.endGroup();
}
KeyMap map;
map.loadDefaults();
QSettings s(path, QSettings::IniFormat);
map.loadOverrides(s);
QCOMPARE(map.actionFor(QKeySequence(QStringLiteral("j"))),
QStringLiteral("archive"));
// An untouched default survives.
QCOMPARE(map.actionFor(QKeySequence(QStringLiteral("k"))),
QStringLiteral("prev_thread"));
}
void TestKeyMap::iniAddsNewBinding()
{
QTemporaryDir dir;
const QString path = dir.filePath(QStringLiteral("t.conf"));
{
QSettings s(path, QSettings::IniFormat);
s.beginGroup(QStringLiteral("keys"));
s.setValue(QStringLiteral("Ctrl+Shift+A"), QStringLiteral("archive"));
s.endGroup();
}
KeyMap map;
map.loadDefaults();
QSettings s(path, QSettings::IniFormat);
map.loadOverrides(s);
QCOMPARE(map.actionFor(QKeySequence(QStringLiteral("Ctrl+Shift+A"))),
QStringLiteral("archive"));
}
void TestKeyMap::chordSequenceParses()
{
QTemporaryDir dir;
const QString path = dir.filePath(QStringLiteral("t.conf"));
{
QSettings s(path, QSettings::IniFormat);
s.beginGroup(QStringLiteral("keys"));
s.setValue(QStringLiteral("g,i"), QStringLiteral("focus_query"));
s.endGroup();
}
KeyMap map;
QSettings s(path, QSettings::IniFormat);
map.loadOverrides(s);
const QKeySequence chord = QKeySequence::fromString(QStringLiteral("g,i"));
QCOMPARE(chord.count(), 2);
QCOMPARE(map.actionFor(chord), QStringLiteral("focus_query"));
}
void TestKeyMap::unknownActionIsReported()
{
QTemporaryDir dir;
const QString path = dir.filePath(QStringLiteral("t.conf"));
{
QSettings s(path, QSettings::IniFormat);
s.beginGroup(QStringLiteral("keys"));
s.setValue(QStringLiteral("z"), QStringLiteral("no_such_action"));
s.endGroup();
}
KeyMap map;
QSettings s(path, QSettings::IniFormat);
map.loadOverrides(s);
// Reported, not fatal, and not bound.
QCOMPARE(map.warnings().size(), 1);
QVERIFY(map.warnings().first().contains(QStringLiteral("no_such_action")));
QVERIFY(map.actionFor(QKeySequence(QStringLiteral("z"))).isEmpty());
}
void TestKeyMap::invalidSequenceIsReported()
{
QTemporaryDir dir;
const QString path = dir.filePath(QStringLiteral("t.conf"));
{
QSettings s(path, QSettings::IniFormat);
s.beginGroup(QStringLiteral("keys"));
s.setValue(QStringLiteral("NotAKey++"), QStringLiteral("archive"));
s.endGroup();
}
KeyMap map;
QSettings s(path, QSettings::IniFormat);
map.loadOverrides(s);
QCOMPARE(map.warnings().size(), 1);
}
void TestKeyMap::collidingOverridesAreReported()
{
// "y" and "Y" both normalize to the same QKeySequence ("Y"), so binding
// both in [keys] is a genuine collision that must not silently drop one.
{
QTemporaryDir dir;
const QString path = dir.filePath(QStringLiteral("t.conf"));
{
QSettings s(path, QSettings::IniFormat);
s.beginGroup(QStringLiteral("keys"));
s.setValue(QStringLiteral("y"), QStringLiteral("archive"));
s.setValue(QStringLiteral("Y"), QStringLiteral("delete"));
s.endGroup();
}
KeyMap map;
QSettings s(path, QSettings::IniFormat);
map.loadOverrides(s);
QCOMPARE(map.warnings().size(), 1);
QVERIFY(map.warnings().first().contains(QStringLiteral("archive")));
QVERIFY(map.warnings().first().contains(QStringLiteral("delete")));
}
// Overriding a default is not a collision: loadDefaults() puts 'j' in
// the map first, then the override pass rebinds the same 'j'. That must
// stay silent (regression check for iniOverridesDefault's scenario).
{
QTemporaryDir dir;
const QString path = dir.filePath(QStringLiteral("t.conf"));
{
QSettings s(path, QSettings::IniFormat);
s.beginGroup(QStringLiteral("keys"));
s.setValue(QStringLiteral("j"), QStringLiteral("archive"));
s.endGroup();
}
KeyMap map;
map.loadDefaults();
QSettings s(path, QSettings::IniFormat);
map.loadOverrides(s);
QCOMPARE(map.warnings().size(), 0);
}
}
QTEST_MAIN(TestKeyMap)
#include "test_keymap.moc"
|
