fix(rules): keep the text-mode toggle reachable

Ticking "Edit as text" was a one-way trip: the only way back to the rows
was closing the dialog and reopening it. The checkbox was parented to the
builder widget and sat on the match row, and switching to text mode hides
that widget, so the toggle disappeared along with the rows it governs.

Move it to the query row, which is visible in both modes.

The existing tests all passed against this, because they drove the toggle
through setChecked and then asserted on the checked STATE. A hidden
checkbox reports its state perfectly well, so every one of those
assertions held while the widget was unreachable. The new test asks the
question that matters, whether the toggle would be on screen, and it uses
isVisibleTo since nothing is isVisible on a dialog that was never shown.

Worth recording how close the mutation check came to endorsing this too.
Reparenting the checkbox alone left it in the query row's layout, so it
stayed visible and the test still passed. Only restoring the full shipped
shape, parent and layout together, reproduced the fault and failed the
test. A mutation that does not reproduce the original bug proves nothing
about the test that is meant to catch it.

The spec's layout sketch carried the same error and is corrected, with
the reason, so the next reader does not reintroduce it.

1 files changed, 44 insertions, 0 deletions

diff --git a/tests/test_tagrules.cpp b/tests/test_tagrules.cpp
index 8207b3c..cf7dadb 100644
--- a/tests/test_tagrules.cpp
+++ b/tests/test_tagrules.cpp
@@ -48,6 +48,7 @@ private slots:
     void aTextModeRuleStaysTextWhenAnotherRuleIsVisited();
     void leavingTextModeIsRefusedWhenTheQueryCannotBeShownAsRows();
     void aFolderRowUsesTheDropdownAndKeepsItsSuffix();
+    void theTextModeToggleSurvivesBeingSwitchedOn();
 
 private:
     QString writeRules(const QString &json);
@@ -590,5 +591,48 @@ void TestTagRules::aFolderRowUsesTheDropdownAndKeepsItsSuffix()
              QStringLiteral("path:\"account-two/**\""));
 }
 
+void TestTagRules::theTextModeToggleSurvivesBeingSwitchedOn()
+{
+    // The toggle governs the builder, so it must not live INSIDE the builder:
+    // switching to text mode hides that widget, and a checkbox parented there
+    // disappears along with the rows, leaving no way back except closing the
+    // dialog. That shipped in the first draft and a user found it by hand.
+    //
+    // Asserting on the checked state alone passes against the bug, because a
+    // hidden widget still reports its state perfectly well. The question is
+    // reachability.
+    QTemporaryDir configHome;
+    QVERIFY(configHome.isValid());
+    qputenv("XDG_CONFIG_HOME", configHome.path().toUtf8());
+    QVERIFY(QDir().mkpath(configHome.filePath(QStringLiteral("mailrules"))));
+
+    QFile out(configHome.filePath(QStringLiteral("mailrules/rules.json")));
+    QVERIFY(out.open(QIODevice::WriteOnly));
+    out.write(R"({
+      "version": 1,
+      "rules": [
+        {"id": "vendor", "query": "from:vendor.example.org",
+         "add": ["vendor"], "stage": 50, "enabled": true}
+      ]
+    })");
+    out.close();
+
+    TagRulesDialog dialog;
+    QVERIFY(dialog.textModeToggleIsReachableForTest());
+
+    dialog.setTextModeForTest(true);
+    QVERIFY2(dialog.textModeToggleIsReachableForTest(),
+             "the toggle must survive switching to text, or there is no "
+             "way back to the rows");
+
+    // And the round trip works, which is the behaviour the user wanted.
+    dialog.setTextModeForTest(false);
+    QVERIFY(!dialog.textModeForTest());
+    QVERIFY(dialog.textModeToggleIsReachableForTest());
+    QCOMPARE(dialog.rowCountForTest(), 1);
+    QCOMPARE(dialog.queryLineForTest(),
+             QStringLiteral("from:vendor.example.org"));
+}
+
 QTEST_MAIN(TestTagRules)
 #include "test_tagrules.moc"