fix(mime): a body part carrying a Content-Id no longer renders blank

collectParts() filed any part with a Content-Id into inlineParts and
returned before the text/plain and text/html branches. Setting a
Content-Id on the text/html body is legal and common in bulk-sender
output, and such a message parsed with both body slots empty, so
hasHtml() was false, HtmlBuilder fell through to an empty plain body,
and the pane rendered nothing. Both halves of the report, the blank
message and "no HTML part", came from that one ordering.

A content id makes a part referenceable, not undisplayable. The two are
independent. The branch now registers the part and falls through rather
than returning, so the body still fills its slot. Registering first
keeps a part that is both the body and a cid: target reachable under
its id for any sibling referencing it.

Content-Disposition is deliberately not used as the discriminator: it
is absent far more often than it is correct, and a body part commonly
carries none. The existing attachment check remains the only test for
"not a body", and the first-one-wins isEmpty() guard still stops an
inline image displacing a real body, since an image matches neither
text branch.

Verified against a hand-written fixture whose text/html part carries a
Content-Id, asserting the body renders, the id still resolves, and the
sibling image is unaffected. Load-bearing by mutation: restoring the
early return fails the test. The user could not relocate the message
that prompted the report, so the end-to-end path is unconfirmed.

Closes item 41.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1 files changed, 31 insertions, 0 deletions

diff --git a/tests/test_mimeparser.cpp b/tests/test_mimeparser.cpp
index f1bbc8a..d16735f 100644
--- a/tests/test_mimeparser.cpp
+++ b/tests/test_mimeparser.cpp
@@ -31,6 +31,7 @@ private slots:
     void prefersHtmlWhenAvailable();
     void fallsBackToPlainWhenHtmlDisabled();
     void collectsInlineCidParts();
+    void aBodyCarryingAContentIdStillRenders();
     void decodesQuotedPrintableAttachment();
     void decodesEncodedHeaders();
     void malformedMessageDoesNotCrash();
@@ -109,6 +110,36 @@ void TestMimeParser::collectsInlineCidParts()
     QVERIFY(part.data.startsWith(QByteArray("\x89PNG", 4)));
 }
 
+void TestMimeParser::aBodyCarryingAContentIdStillRenders()
+{
+    // Reported by the user: a bulk sender's message opened blank, with the app
+    // saying it had no HTML part.
+    //
+    // A Content-Id makes a part referenceable, not non-displayable, and setting
+    // one on the text/html body is legal and common. collectParts filed any
+    // part with an id into inlineParts and returned before the body branches,
+    // so such a message parsed with both body slots empty.
+    MimeParser parser;
+    const ParsedMessage msg =
+        parser.parse(fixture(QStringLiteral("body_with_content_id.eml")));
+
+    QVERIFY(msg.ok);
+
+    // The body fills its slot despite the id.
+    QVERIFY2(msg.hasHtml(), "the html body was swallowed by its own content id");
+    QVERIFY(msg.htmlBody.contains(QStringLiteral("Body text.")));
+
+    // And it stays reachable under that id, so a sibling referencing it still
+    // resolves. Register first, then assign: the two are independent.
+    QVERIFY(msg.inlineParts.contains(QStringLiteral("body@example.org")));
+    QCOMPARE(msg.inlineParts.value(QStringLiteral("body@example.org")).mimeType,
+             QStringLiteral("text/html"));
+
+    // The genuinely inline image is untouched by the change.
+    QVERIFY(msg.inlineParts.contains(QStringLiteral("logo@example.org")));
+    QCOMPARE(msg.inlineParts.size(), 2);
+}
+
 void TestMimeParser::decodesQuotedPrintableAttachment()
 {
     MimeParser parser;