fix(ui): tell read threads from unread without relying on bold

Bold was unread's only cue, and it renders identically to regular on the
user's system: confirmed by eye against a bare QTableView holding a
plain QStandardItemModel, with no code from this project involved. The
fault is in Qt or fontconfig, below this application, and nothing in the
model could ever have reached it. Read and unread mail looked exactly
alike.

The emphasis is inverted instead. Unread rows keep the palette's own
text colour and read rows are dimmed toward the background, so the cue
rides on Qt::ForegroundRole, which the delegate already honours, and
costs no column. It also suits the real ratio, measured at 99 unread
against 4220 read: dimming the bulk is calmer than highlighting it. The
dim colour is derived from the palette, never hardcoded, per the rule
item 12 established. Bold is kept for systems where it works, but
nothing depends on it now.

That exposed a second defect, visible the moment it shipped. Qt resolves
ForegroundRole into the palette and then prefers it over
HighlightedText, so a model-supplied colour wins on a SELECTED row too.
The dim is blended against the unselected background, so a selected read
row painted grey on the selection colour, near unreadable.
SubjectDelegate::initStyleOption now reverses that, and the delegate is
installed view-wide rather than on the subject column alone, so every
column gets the same handling instead of three of them keeping Qt's
ordering.

The guarding tests state the property rather than the mechanism: strip
the font from the model's answer and the two states must still differ.
A test asserting only that bold is set passes on a system where bold
paints like regular, which is exactly how this survived. The selection
test renders two rows identical but for the unread tag, selects both,
and requires zero differing pixels.

Part of item 5; the density work and the star column remain.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1 files changed, 55 insertions, 0 deletions

diff --git a/tests/test_mainwindow.cpp b/tests/test_mainwindow.cpp
index 1fdeaf2..1af95ed 100644
--- a/tests/test_mainwindow.cpp
+++ b/tests/test_mainwindow.cpp
@@ -81,6 +81,7 @@ private slots:
     void aSkippedLocalSyncStillReportsTheOtherRunFinishing();
     void anUnobservableLockTableLeavesTheSyncButtonUsable();
     void theStatusBarFollowsTheSyncPhase();
+    void aSelectedReadThreadIsNotDimmedIntoTheHighlight();
     void markAllReadIsDisabledUntilTheQueryFinishes();
     void markAllReadActsOnEveryRowAndUndoesInOneStep();
     void markAllReadDoesNothingWhenNothingIsUnread();
@@ -370,6 +371,60 @@ static ThreadSummary makeThread(const QString &id, const QStringList &tags)
     return thread;
 }
 
+void TestMainWindow::aSelectedReadThreadIsNotDimmedIntoTheHighlight()
+{
+    // Read threads carry a dimmed Qt::ForegroundRole, blended against the
+    // UNSELECTED background. Qt's own painting prefers a model foreground over
+    // HighlightedText, so without SubjectDelegate::initStyleOption reversing
+    // that, selecting a read row paints it grey on the selection colour, which
+    // is close to unreadable. Seen in a screenshot before it was caught here.
+    //
+    // Rendered rather than asserted on roles: the model is right either way,
+    // and the defect lives entirely in how the delegate resolves them.
+    const Config config;
+    MainWindow window(config);
+
+    auto *model = window.findChild<ThreadListModel *>();
+    QVERIFY(model);
+    auto *view = window.findChild<QTableView *>();
+    QVERIFY(view);
+
+    // Identical but for the unread tag, so any pixel difference between the
+    // two selected rows is the dimming leaking through.
+    ThreadSummary read = makeThread(QStringLiteral("t1"), {});
+    ThreadSummary unread =
+        makeThread(QStringLiteral("t2"), { QStringLiteral("unread") });
+    read.subject = unread.subject = QStringLiteral("Same subject both rows");
+    read.authors = unread.authors = QStringLiteral("Someone <s@example.org>");
+    model->appendBatch({ read, unread });
+
+    window.resize(900, 300);
+    window.show();
+    QVERIFY(QTest::qWaitForWindowExposed(&window));
+
+    view->selectAll();
+    QApplication::processEvents();
+
+    const int rowHeight = view->rowHeight(0);
+    QVERIFY(rowHeight > 0);
+
+    QImage shot(view->viewport()->size(), QImage::Format_ARGB32);
+    shot.fill(Qt::transparent);
+    view->viewport()->render(&shot);
+
+    int differing = 0;
+    for (int y = 0; y < rowHeight && y + rowHeight < shot.height(); ++y)
+        for (int x = 0; x < shot.width(); ++x)
+            if (shot.pixel(x, y) != shot.pixel(x, y + rowHeight))
+                ++differing;
+
+    QVERIFY2(differing == 0,
+             qPrintable(QStringLiteral("a selected read row paints differently "
+                                       "from a selected unread one (%1 pixels): "
+                                       "the dimming is overriding the selection "
+                                       "highlight").arg(differing)));
+}
+
 void TestMainWindow::markAllReadIsDisabledUntilTheQueryFinishes()
 {
     // Threads arrive in batches, so acting mid-load would silently skip