feat(panes): draw the pane marks from shipped SVGs, not font glyphs

Items 70 and 69, the second folded into the first as item 70's own size note
predicted it should be.

The panes drew their state marks as font glyphs: U+1F4CE for an attachment and
U+2605 for a flagged thread, each with a fallback for a font that cannot render
it. Both fell back to "*", so on such a font a flagged thread and one carrying
an attachment were indistinguishable, which is a defect the fallback introduced
rather than prevented. What a mark looks like was also the desktop's decision
rather than this application's, and the panes are exactly where it should not
be: the user asked for the toolbar and menus to keep following their icon theme
while the panes stop.

Six marks now ship in assets/icons/marks/: flagged, attachment, passed, replied
and the two expander triangles. QIcon::fromTheme still resolves every toolbar
and menu icon and was not touched.

Licensing chose the shapes. The look came from a GPL3 icon theme, and this
project is GPLv2-only, which are incompatible: GPLv2's "no further
restrictions" clause bars shipping GPL3 assets in a v2-only work. The six were
drawn fresh in the same idiom instead, with no path data copied. The idiom is
generic: solid single-path silhouettes at 16x16 with no strokes.

They are compiled in as string literals rather than loaded from a .qrc.
src/CMakeLists.txt already records why resources belong to the executable: a
qrc in the static library registers itself from a global initialiser the linker
drops. The tests link the library, so a resource-based mark would be missing
exactly where it needs asserting. assets/icons/marks/ stays the editable
source.

One asset serves both palettes. Every payload paints with fill="currentColor",
which QSvgRenderer renders black rather than resolving, so Marks::pixmap
composites the wanted colour with CompositionMode_SourceIn. A mark then takes
the card's own pen colour and follows selection and the read/unread dimming
without a second variant to keep in step.

CardLayout reserves a rect per mark and CardDelegate paints into it. The marks
were glyphs inside the subject STRING, so their width came free from the text
metrics; as icons the geometry has to know they are there or the subject runs
underneath them. The expander pill had the same trap, its triangle being a
glyph in expanderLabel(), and now reserves that width explicitly.

Item 69's part: passed and replied were words in the tag strip and are marks
beside the subject now. The message pane's header carries the flagged and
attachment marks next to the subject, per the user's decision that the right
pane needs those two and only outside the message area.

A duplicate that no test caught is worth recording. Every geometry assertion
passed while a card showed passed as BOTH an arrow and a green tag chip: the
chip filter had no reason to know a mark had appeared. It was found by
rendering real cards to an image and looking at them. isDrawnAsAMark() is now
one list consulted by both PillTagsRole and MessageOwnTagsRole, since two
copies drifting apart is how a tag ends up drawn twice on one row and not at
all on another.

Fourteen tests: nine in test_marks, four in test_cardlayout, one in
test_threadlistmodel. Mutation-checked at four points, each failing a test: the
subject ignoring the marks, the flag not indenting the subject, the pill
forgetting the triangle's width, and the recolour composite removed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1 files changed, 164 insertions, 9 deletions

diff --git a/tests/test_cardlayout.cpp b/tests/test_cardlayout.cpp
index bce6a0f..f5f40ab 100644
--- a/tests/test_cardlayout.cpp
+++ b/tests/test_cardlayout.cpp
@@ -35,6 +35,10 @@ private slots:
     void expanderSitsOnTheSecondLine();
     void expanderIsEmptyWithoutReplies();
     void theExpanderReadsAsAPillWithAWord();
+    void marksReserveTheirOwnSpaceRatherThanOverlappingTheSubject();
+    void anAbsentMarkReservesNothing();
+    void theFlagIndentsTheSubjectRatherThanSittingOnIt();
+    void marksDoNotCollideWithEachOtherOrTheExpander();
     void dateIsFlushRight();
     void threadCardCarriesAnAccentBar();
     void replyCardCarriesNoAccentBar();
@@ -228,15 +232,22 @@ void TestCardLayout::theExpanderReadsAsAPillWithAWord()
     // A bare "3" beside the subject reads as an unexplained number and gives
     // no hint that it can be clicked. The label carries the word, and the rect
     // carries padding for the pill drawn behind it.
-    QCOMPARE(CardLayout::expanderLabel(3, false),
-             QStringLiteral("\u25b8 3 replies"));
-    QCOMPARE(CardLayout::expanderLabel(3, true),
-             QStringLiteral("\u25be 3 replies"));
+    //
+    // NO triangle in the label since item 70: it is a drawn mark now, and a
+    // glyph left here would be a second triangle beside the drawn one. The
+    // label is the words alone, and the state no longer changes it.
+    QCOMPARE(CardLayout::expanderLabel(3, false), QStringLiteral("3 replies"));
+    QCOMPARE(CardLayout::expanderLabel(3, true), QStringLiteral("3 replies"));
 
     // Singular, because "1 replies" is the kind of detail that makes an
     // interface look unfinished.
-    QCOMPARE(CardLayout::expanderLabel(1, false),
-             QStringLiteral("\u25b8 1 reply"));
+    QCOMPARE(CardLayout::expanderLabel(1, false), QStringLiteral("1 reply"));
+
+    // The glyphs are gone from the label entirely. Asserted rather than assumed,
+    // because a stray one would draw underneath the mark and look like a
+    // rendering fault rather than like a stale string.
+    QVERIFY(!CardLayout::expanderLabel(3, false).contains(QChar(0x25b8)));
+    QVERIFY(!CardLayout::expanderLabel(3, true).contains(QChar(0x25be)));
 
     const QFont font;
     const int h = CardLayout::heightFor(font);
@@ -244,12 +255,17 @@ void TestCardLayout::theExpanderReadsAsAPillWithAWord()
         CardLayout::compute(threadInput(), QRect(0, 0, 400, h), font);
     const QFontMetrics small(CardLayout::smallFont(font));
 
-    // The rect must hold the label AND its padding, or the pill's background
-    // is narrower than the text sitting on it.
+    // The rect must hold the label, the drawn triangle, the gap between them
+    // AND the padding, or the pill's background is narrower than what sits on
+    // it. The triangle's width came free from the text metrics while it was a
+    // glyph in the label; since item 70 it is reserved explicitly, and this is
+    // what would catch it being forgotten.
     QVERIFY2(card.expanderRect.width()
                  >= small.horizontalAdvance(CardLayout::expanderLabel(3, false))
+                        + small.ascent() + CardLayout::kMarkGap
                         + CardLayout::kPillPaddingX * 2,
-             "the expander rect is too narrow for its own label and padding");
+             "the expander rect is too narrow for its label, its triangle and "
+             "its padding");
 
     // And it must NOT change width when the card opens: a pill that resized on
     // click would shift the subject's elision under the pointer.
@@ -259,6 +275,145 @@ void TestCardLayout::theExpanderReadsAsAPillWithAWord()
     QCOMPARE(expanded.expanderRect.width(), card.expanderRect.width());
 }
 
+void TestCardLayout::marksReserveTheirOwnSpaceRatherThanOverlappingTheSubject()
+{
+    // Item 70. The marks were glyphs INSIDE the subject string until then, so
+    // their width came free from the text metrics and no arrangement was
+    // needed. As drawn icons they occupy rects, and a subject sized as though
+    // they were absent runs underneath them. This is the assertion that would
+    // catch that, and it cannot be made anywhere else: a rendering probe over
+    // the delegate would show overlapping ink as a plausible-looking card.
+    const QFont font;
+    const int h = CardLayout::heightFor(font);
+    const QRect rect(0, 0, 400, h);
+
+    CardLayout::Input bare = threadInput();
+    CardLayout::Input marked = threadInput();
+    marked.hasAttachment = true;
+    marked.passed = true;
+    marked.replied = true;
+
+    const CardLayout without = CardLayout::compute(bare, rect, font);
+    const CardLayout with = CardLayout::compute(marked, rect, font);
+
+    QVERIFY(!with.attachmentRect.isEmpty());
+    QVERIFY(!with.passedRect.isEmpty());
+    QVERIFY(!with.repliedRect.isEmpty());
+
+    // The subject gives up exactly the room the marks take.
+    QVERIFY2(with.subjectRect.width() < without.subjectRect.width(),
+             "the marks reserved no space, so the subject is sized as though "
+             "they were not there and its text runs underneath them");
+
+    // And every mark begins after the subject ends. Compared as exclusive
+    // edges: QRect::right() is inclusive, which is the trap this file already
+    // documents for the date.
+    const int subjectEnd = with.subjectRect.left() + with.subjectRect.width();
+    QVERIFY2(with.attachmentRect.left() >= subjectEnd,
+             "the attachment mark overlaps the subject");
+    QVERIFY2(with.passedRect.left() >= subjectEnd, "passed overlaps the subject");
+    QVERIFY2(with.repliedRect.left() >= subjectEnd,
+             "replied overlaps the subject");
+
+    // Square, so nothing is drawn stretched.
+    QCOMPARE(with.attachmentRect.width(), with.attachmentRect.height());
+}
+
+void TestCardLayout::anAbsentMarkReservesNothing()
+{
+    // A card with no attachment must not leave a hole where the mark would be:
+    // the subject is the elastic part of line two and every reserved-but-unused
+    // pixel comes out of it.
+    const QFont font;
+    const int h = CardLayout::heightFor(font);
+    const QRect rect(0, 0, 400, h);
+
+    const CardLayout card = CardLayout::compute(threadInput(), rect, font);
+
+    QVERIFY(card.flagRect.isEmpty());
+    QVERIFY(card.attachmentRect.isEmpty());
+    QVERIFY(card.passedRect.isEmpty());
+    QVERIFY(card.repliedRect.isEmpty());
+
+    // Guard: the same input WITH a mark must produce one, or the assertions
+    // above pass against a layout that never draws marks at all.
+    CardLayout::Input marked = threadInput();
+    marked.hasAttachment = true;
+    QVERIFY(!CardLayout::compute(marked, rect, font).attachmentRect.isEmpty());
+}
+
+void TestCardLayout::theFlagIndentsTheSubjectRatherThanSittingOnIt()
+{
+    // The flag is the one mark on the LEFT, where its glyph was, so a flagged
+    // card still reads flagged from the left edge.
+    const QFont font;
+    const int h = CardLayout::heightFor(font);
+    const QRect rect(0, 0, 400, h);
+
+    CardLayout::Input flagged = threadInput();
+    flagged.flagged = true;
+
+    const CardLayout plain = CardLayout::compute(threadInput(), rect, font);
+    const CardLayout marked = CardLayout::compute(flagged, rect, font);
+
+    QVERIFY(!marked.flagRect.isEmpty());
+    QCOMPARE(marked.flagRect.left(), marked.contentLeft);
+
+    // The subject starts after the flag, rather than at contentLeft with the
+    // flag drawn over it.
+    QVERIFY2(marked.subjectRect.left() > plain.subjectRect.left(),
+             "the flag did not move the subject, so it is drawn on top of it");
+    QVERIFY(marked.subjectRect.left()
+            >= marked.flagRect.left() + marked.flagRect.width());
+}
+
+void TestCardLayout::marksDoNotCollideWithEachOtherOrTheExpander()
+{
+    // All four marks at once on a card that also has an expander, which is the
+    // densest line two can get. Nothing may overlap anything.
+    const QFont font;
+    const int h = CardLayout::heightFor(font);
+    const QRect rect(0, 0, 400, h);
+
+    CardLayout::Input in = threadInput();
+    in.flagged = true;
+    in.hasAttachment = true;
+    in.passed = true;
+    in.replied = true;
+
+    const CardLayout card = CardLayout::compute(in, rect, font);
+
+    QVERIFY(!card.expanderRect.isEmpty());
+
+    // Left to right: flag, subject, attachment, passed, replied, expander.
+    const QList<QRect> ordered = { card.flagRect,   card.subjectRect,
+                                   card.attachmentRect, card.passedRect,
+                                   card.repliedRect,  card.expanderRect };
+    for (int i = 0; i + 1 < ordered.size(); ++i) {
+        const QRect &left = ordered.at(i);
+        const QRect &right = ordered.at(i + 1);
+        QVERIFY2(left.left() + left.width() <= right.left(),
+                 qPrintable(QStringLiteral("rect %1 (x %2 w %3) overlaps rect "
+                                           "%4 (x %5)")
+                                .arg(i)
+                                .arg(left.left())
+                                .arg(left.width())
+                                .arg(i + 1)
+                                .arg(right.left())));
+    }
+
+    // And the whole line stays inside the card.
+    QVERIFY(card.repliedRect.left() + card.repliedRect.width()
+            <= card.expanderRect.left());
+    QVERIFY(card.expanderRect.left() + card.expanderRect.width()
+            <= rect.right() + 1);
+
+    // The subject survives at a usable width rather than being squeezed to
+    // nothing by four marks: they are small and fixed, it is the elastic part.
+    QVERIFY2(card.subjectRect.width() > 100,
+             "four marks left the subject with almost no room on a 400px card");
+}
+
 void TestCardLayout::dateIsFlushRight()
 {
     const QFont font;