summaryrefslogtreecommitdiffstats
path: root/src/threaddashboard.h
diff options
context:
space:
mode:
authorDanilo M. <danix@danix.xyz>2026-08-29 10:11:59 +0200
committerDanilo M. <danix@danix.xyz>2026-08-29 10:11:59 +0200
commite2bd68a863513209a5881696164fd463ddc83503 (patch)
treefe9fc90462030f9f99d5298eb09785018cc60f40 /src/threaddashboard.h
parentfeb15bcec261501eb49ad0de1fdc05a9992227c2 (diff)
downloadqtmaildir-e2bd68a863513209a5881696164fd463ddc83503.tar.gz
qtmaildir-e2bd68a863513209a5881696164fd463ddc83503.zip
fix: say an edit is waiting for the sync instead of claiming it landed
Item 182, found by hand: a thread of 9 messages with 5 unread, marked read while a sync was running, reported "<subject>: mark as read" and then reported the same work again when the sync finished. The user read it as double reporting. Not a double write, and the mail was correct. It is one action reported twice because the FIRST report was the wrong one. A sync holds notmuch's exclusive write lock and the worker's read-write open blocks on it rather than failing, so an edit made during a sync is held and sent when the lock frees. All three hold branches say exactly that, in a label chosen deliberately: NOT transient, because it describes state lasting until the sync ends, and a message that expired would leave rows showing a tag the database has not got and no explanation of why. That label never survived. Every caller announced the action itself a line later through showTransientStatus(), which overwrote it, so the user was told the write had happened and the hold was never mentioned. The flush at the end of the sync then reported the same work again and read as a duplicate rather than as its completion. announceAction() asks whether a sync holds the lock and, when one does, sets a non-transient label naming the action AND the wait. The action is still named because that announcement is what stands in for the confirmation dialog this project rules out: it is how a user tells that something larger than they meant has just happened, so the hold is added to it rather than replacing it. The flush message is untouched and is the only signal that held work actually landed, whose absence was item 106. The test drives toggle_unread, the route the user took, and asserts both halves: the text mentions the sync, and it still says what is waiting. Asserting only the first would pass against an announcement that dropped the action entirely. Mutation-checked by forcing the non-held branch, which fails with the exact text the user reported. The new string is translated, since one that misses the Italian ships as English inside an otherwise Italian UI: lupdate found it with no context warnings, lrelease reports 552 finished and 0 unfinished. Suite: 42 of 43, with undoMovesTheMessageBack failing as it does on master (item 136).
Diffstat (limited to 'src/threaddashboard.h')
0 files changed, 0 insertions, 0 deletions