aboutsummaryrefslogtreecommitdiffstats
path: root/src/mailsync.h
diff options
context:
space:
mode:
authorDanilo M. <danix@danix.xyz>2026-08-20 10:50:10 +0200
committerDanilo M. <danix@danix.xyz>2026-08-20 10:50:10 +0200
commite4e2f4af71a6597548d2e35d82a5dec6a4ed3a5c (patch)
treefacb5bfaa35b587ff9abbb12d95d6e88fde0d111 /src/mailsync.h
parent3f256acda192fbe2b9fad28d09cd74dca9a69418 (diff)
downloadqtmaildir-e4e2f4af71a6597548d2e35d82a5dec6a4ed3a5c.tar.gz
qtmaildir-e4e2f4af71a6597548d2e35d82a5dec6a4ed3a5c.zip
fix(pane): drop Save link from a link's context menu
Reported by hand after the item 127 fix: right-clicking a link still offered Save link. It had been deferred to item 114 alongside Save image, on the grounds that both are inert without a downloadRequested handler. That is true and it was the wrong conclusion, because the two are not the same question. Save image is content the message already carries, and item 114 is about making it work. Save link fetches a remote URL chosen by the sender, through the pane's profile, which is the one profile in this application that must never fetch remote content: that is what m_allowRemote and the interceptor exist to prevent. Answering it with a download handler would put a network fetch of attacker-controlled content behind one context-menu entry. Saving what the user actually wants already has a path that never touches the network: saveAttachment(), which writes a MIME part already parsed into memory and sanitises the filename. So it is removed rather than implemented, and the test asserts its absence. Item 114 now carries the constraint that follows: a downloadRequested handler added to make Save image work must not make Save link reachable again, which the natural per-profile implementation would do by default. Mutation checked: dropping the entry from the filter fails the test with "a link action survived: Save link". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDq53rMd3AQp7QmcZzpuBM
Diffstat (limited to 'src/mailsync.h')
0 files changed, 0 insertions, 0 deletions