diff options
| author | Danilo M. <danix@danix.xyz> | 2026-08-14 18:25:03 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-08-14 18:25:03 +0200 |
| commit | 86074f40121466798cdd64e07a00db2542543c52 (patch) | |
| tree | 96517aeee0a8a6bb072a3e7d5e0eda7651423fba /docs/superpowers | |
| parent | 1c479f2834533938d8055146c75fe7cbe79a8cd0 (diff) | |
| download | qtmaildir-86074f40121466798cdd64e07a00db2542543c52.tar.gz qtmaildir-86074f40121466798cdd64e07a00db2542543c52.zip | |
fix(startup): raise the config-problem modal outside the constructor
showWarnings() did two separable things and one of them could not be
reached from a test. It set the status label, which is harmless, and it
raised a QMessageBox from the MainWindow constructor, which under the
offscreen platform nothing can dismiss: the constructor never returned
and the suite hung with no output, reading as an infrastructure failure
rather than a test one.
It splits in two. applyWarnings() keeps the status label and stays in
the constructor. configProblems() returns the list, and main.cpp raises
the dialog after show(), which also gives it a visible parent to sit on.
The distinction between warnings and problems is preserved exactly: a
keybinding being ignored interrupts startup, "no sync command
configured" does not.
The warning path now has its first test, using the config shape that
caused the original hang. Mutation checked by putting the modal back in
the constructor: the test times out at 124 rather than failing, which is
the behaviour this removes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'docs/superpowers')
0 files changed, 0 insertions, 0 deletions
