diff options
| author | Danilo M. <danix@danix.xyz> | 2026-08-07 10:32:08 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-08-07 10:32:08 +0200 |
| commit | 6935bfc99ed0df5c79867f7015ba04041e03f908 (patch) | |
| tree | 38c407c5ce7a5ae55331c89603fa2b6e4776d147 /docs/superpowers/plans | |
| parent | db4dbbf4bf4fd8aab1a9e20d87c266ce7836a946 (diff) | |
| download | qtmaildir-6935bfc99ed0df5c79867f7015ba04041e03f908.tar.gz qtmaildir-6935bfc99ed0df5c79867f7015ba04041e03f908.zip | |
fix(tags): the Remove field suggests only tags the selection has
Both TagDialog fields built their completer from knownTags, the whole
database's tag list, so removing a tag offered every tag in existence
rather than the handful the selected threads actually carry.
The candidates were already in the dialog: currentTags, used until now
only to render the checkbox list. The constructor now walks two
(field, vocabulary) pairs instead of two fields sharing one list, with
knownTags for Add and currentTags.keys() for Remove. On a multi-thread
selection that is the union, not the intersection, since removing a tag
two of three threads carry is a meaningful request.
The setWidget and per-token prefix machinery is untouched: these fields
hold a comma-separated list, and QLineEdit::setCompleter is the trap
this dialog already works around. Only the candidate list changed.
Completion stays a suggestion, never a whitelist, so a tag absent from
the candidates still applies.
Tests type keys rather than using setText, which does not drive a
completer at all. Verified load-bearing by mutation: reverting the
Remove vocabulary to knownTags fails the new test.
Closes item 48.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'docs/superpowers/plans')
| -rw-r--r-- | docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md index f10a301..0091d27 100644 --- a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md +++ b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md @@ -95,7 +95,7 @@ taking that too literally. | 45 | Two Sync buttons, and only one of them works properly | correctness | S | **done** | | 46 | `uiStateSurvivesARestart` fails under the offscreen platform | testing | XS | **done** | | 47 | The query bar looks unfinished, and cannot be cleared by mouse | presentation | XS | **done** | -| 48 | Removing a tag suggests every tag, not the thread's own | workflow | XS | open | +| 48 | Removing a tag suggests every tag, not the thread's own | workflow | XS | **done** | Sizes are rough: XS under an hour, S a sitting, M a session. |