diff options
| author | Danilo M. <danix@danix.xyz> | 2026-08-20 10:50:10 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-08-20 10:50:10 +0200 |
| commit | e4e2f4af71a6597548d2e35d82a5dec6a4ed3a5c (patch) | |
| tree | facb5bfaa35b587ff9abbb12d95d6e88fde0d111 /docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md | |
| parent | 3f256acda192fbe2b9fad28d09cd74dca9a69418 (diff) | |
| download | qtmaildir-e4e2f4af71a6597548d2e35d82a5dec6a4ed3a5c.tar.gz qtmaildir-e4e2f4af71a6597548d2e35d82a5dec6a4ed3a5c.zip | |
fix(pane): drop Save link from a link's context menu
Reported by hand after the item 127 fix: right-clicking a link still
offered Save link.
It had been deferred to item 114 alongside Save image, on the grounds that
both are inert without a downloadRequested handler. That is true and it was
the wrong conclusion, because the two are not the same question.
Save image is content the message already carries, and item 114 is about
making it work. Save link fetches a remote URL chosen by the sender,
through the pane's profile, which is the one profile in this application
that must never fetch remote content: that is what m_allowRemote and the
interceptor exist to prevent. Answering it with a download handler would
put a network fetch of attacker-controlled content behind one context-menu
entry.
Saving what the user actually wants already has a path that never touches
the network: saveAttachment(), which writes a MIME part already parsed into
memory and sanitises the filename.
So it is removed rather than implemented, and the test asserts its absence.
Item 114 now carries the constraint that follows: a downloadRequested
handler added to make Save image work must not make Save link reachable
again, which the natural per-profile implementation would do by default.
Mutation checked: dropping the entry from the filter fails the test with
"a link action survived: Save link".
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YDq53rMd3AQp7QmcZzpuBM
Diffstat (limited to 'docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md')
| -rw-r--r-- | docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md index 3848a6d..d7783f7 100644 --- a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md +++ b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md @@ -730,6 +730,22 @@ for the network to satisfy it. **Size: S.** +**Save LINK is no longer part of this item** (2026-08-20, item 127). It was +deferred here on the grounds that both are inert for want of a +`downloadRequested` handler, which is true and beside the point: they are not +the same question. + +Save image is content the message already carries, and making it work is what +this item is about. Save link fetches a REMOTE URL chosen by the sender, +through the pane's profile, which is the one profile in the application that +must never fetch remote content. It is removed from the menu rather than +implemented, and `theLinkMenuDropsTheOpenInWindowActions` asserts its absence. + +**That assertion constrains this item.** A `downloadRequested` handler added to +make Save image work must not make Save link reachable again. The test fails if +it does, which is the point: the handler is per-profile, so the natural +implementation would light up both entries at once. + ## 118. No way to empty the trash from inside the app **Observed (user, 2026-08-17):** raised while reviewing item 103's spec, as |
