diff options
| author | Danilo M. <danix@danix.xyz> | 2026-08-04 12:43:32 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-08-04 12:55:06 +0200 |
| commit | 1407f70352c05d59fa2e1bb7c59b048b767972e5 (patch) | |
| tree | ff820668b456a483db20b39aeb3b9f2881e3ebf0 | |
| parent | f0e99dceb5a395eb542a6a67a0b56b7bb33a2474 (diff) | |
| download | qtmaildir-1407f70352c05d59fa2e1bb7c59b048b767972e5.tar.gz qtmaildir-1407f70352c05d59fa2e1bb7c59b048b767972e5.zip | |
docs: scrub account names from comments, tests and fixtures
Real Maildir account keys had reached comments and test data:
provider-and-mailbox names across three source files, one of them
carrying a surname, plus a real address used as example data in the
notmuch test fixture and the design spec.
The user's standing rule is that maildir and account names never reach a
commit, and this is about to become a public repository, which is what
makes it consequential rather than untidy. Replaced with generic keys
that carry the same shape, since the length is the point in every one of
these comments: a 33-character account tag is why the chip label exists
and why the tag column was removed.
The measurements stay. They are the evidence behind those decisions and
are not personal details.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
| -rw-r--r-- | docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md | 6 | ||||
| -rw-r--r-- | docs/superpowers/specs/2026-08-02-qtmaildir-design.md | 4 | ||||
| -rw-r--r-- | src/config.h | 4 | ||||
| -rw-r--r-- | tests/notmuchfixture.h | 2 | ||||
| -rw-r--r-- | tests/test_tagcolors.cpp | 12 |
5 files changed, 14 insertions, 14 deletions
diff --git a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md index 5fcd6d8..277283e 100644 --- a/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md +++ b/docs/superpowers/plans/2026-08-03-post-0.1.0-usability.md @@ -633,9 +633,9 @@ and inspected: normal, unread, deleted, spam, and deleted-plus-unread rows. ## 14. Tag column unreadable **Observed:** with tags spelled out per row the column ran to 500 pixels of -mostly repeated text ("account-provider-work attachment flagged -inbox passed replied"), dominated by the account prefix, and consumed most of -the list's width. +mostly repeated text (a 33-character account tag followed by "attachment +flagged inbox passed replied"), dominated by the account prefix, and consumed +most of the list's width. **Cause:** presentation, not data. 96 tags in this database, many hierarchical (`shopping/amazon`, `mailing-list/SBo`), rendered as a joined string. diff --git a/docs/superpowers/specs/2026-08-02-qtmaildir-design.md b/docs/superpowers/specs/2026-08-02-qtmaildir-design.md index 67ba857..de2ae12 100644 --- a/docs/superpowers/specs/2026-08-02-qtmaildir-design.md +++ b/docs/superpowers/specs/2026-08-02-qtmaildir-design.md @@ -206,8 +206,8 @@ identity. command = /home/you/bin/mailsync.sh [account.work] -name = Danilo M. -address = danix@danix.xyz +name = Your Name +address = you@example.org maildir = work-mail ; relative to notmuch's database.path drafts = Drafts diff --git a/src/config.h b/src/config.h index ba9b7f6..84f02df 100644 --- a/src/config.h +++ b/src/config.h @@ -41,8 +41,8 @@ struct Account QColor color; /// Text shown on the chip. Empty falls back to the key, which can be long: - /// "provider-work" is a lot of row for one bit of information. - /// This renames nothing in notmuch, only what the chip displays. + /// a provider-plus-mailbox key of 25 characters is a lot of row for one + /// bit of information. This renames nothing in notmuch, only the display. QString label; bool isValid() const { return !key.isEmpty() && !maildir.isEmpty(); } diff --git a/tests/notmuchfixture.h b/tests/notmuchfixture.h index 38e2f15..4d2e59b 100644 --- a/tests/notmuchfixture.h +++ b/tests/notmuchfixture.h @@ -77,7 +77,7 @@ public: QTextStream out(&file); out << "From: " << from << "\n" - << "To: danix@danix.xyz\n" + << "To: you@example.org\n" << "Subject: " << subject << "\n" << "Message-ID: <" << messageId << ">\n" << "Date: " << date << "\n"; diff --git a/tests/test_tagcolors.cpp b/tests/test_tagcolors.cpp index 1d5efdc..0b47e7b 100644 --- a/tests/test_tagcolors.cpp +++ b/tests/test_tagcolors.cpp @@ -190,18 +190,18 @@ void TestTagColors::accountLabelDefaultsToTheKey() void TestTagColors::accountLabelCanBeOverridden() { - // "account-provider-work" is 33 characters of chip for what is - // really one bit of information, so the label is configurable. + // A real account tag can run to 33 characters of chip for what is really + // one bit of information, so the label is configurable. TagColors colours; colours.setAccountLabel(QStringLiteral("webmail-personal"), QStringLiteral("WM-personal")); - colours.setAccountLabel(QStringLiteral("provider-personal"), - QStringLiteral("PR-personal")); + colours.setAccountLabel(QStringLiteral("provider-work"), + QStringLiteral("PR-work")); QCOMPARE(colours.labelForAccountTag(QStringLiteral("account-webmail-personal")), QStringLiteral("WM-personal")); - QCOMPARE(colours.labelForAccountTag(QStringLiteral("account-provider-personal")), - QStringLiteral("PR-personal")); + QCOMPARE(colours.labelForAccountTag(QStringLiteral("account-provider-work")), + QStringLiteral("PR-work")); // An account left unlabelled still falls back to its key. QCOMPARE(colours.labelForAccountTag(QStringLiteral("account-work")), |
