diff options
| author | Danilo M. <danix@danix.xyz> | 2026-07-02 09:21:27 +0200 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-07-02 09:21:27 +0200 |
| commit | 71658d023fdbf60be6b4501372519bf8171d6e13 (patch) | |
| tree | bf9adcd6bfd60b56303dad219dfe79b003fe0818 /firefly_cli | |
| parent | 166f82d0bfdc598099c088275d68dc42499694f9 (diff) | |
| download | firefly-cli-838e43e058a71762cfdde8307c7a42ea37081599.tar.gz firefly-cli-838e43e058a71762cfdde8307c7a42ea37081599.zip | |
v0.3.7 placed the @registry.command decorator above a helper
(_resolve_side) inserted between the decorator and cmd_add, so the
registry bound the helper as the "tx add" handler. Unit tests call
cmd_add directly and missed it; live CLI dispatch failed with
"_resolve_side() missing 2 required positional arguments". Move the
helper above the decorator and add a regression test asserting the
registered handler is cmd_add.
Found by live smoke test against the test instance. Also note in
resolver that Firefly returns 401 (not 404) for an unknown account id.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'firefly_cli')
| -rw-r--r-- | firefly_cli/__init__.py | 2 | ||||
| -rw-r--r-- | firefly_cli/commands/transaction.py | 2 | ||||
| -rw-r--r-- | firefly_cli/resolver.py | 5 |
3 files changed, 6 insertions, 3 deletions
diff --git a/firefly_cli/__init__.py b/firefly_cli/__init__.py index 1ed8352..66300ca 100644 --- a/firefly_cli/__init__.py +++ b/firefly_cli/__init__.py @@ -2,4 +2,4 @@ # Copyright (C) 2026 Danilo M. <danix@danix.xyz> # Licensed under the GNU General Public License v2.0 only. -__version__ = "0.3.7" +__version__ = "0.3.8" diff --git a/firefly_cli/commands/transaction.py b/firefly_cli/commands/transaction.py index 3ce20f3..60af6f4 100644 --- a/firefly_cli/commands/transaction.py +++ b/firefly_cli/commands/transaction.py @@ -39,7 +39,6 @@ def _add_args(p): p.add_argument("--skip-dupes", dest="skip_dupes", action="store_true", help="skip if a tx with same amount+date+source+destination exists") -@registry.command("tx add", help="record a transaction; source/destination resolve to accounts, category/tags auto-create", args=_add_args) def _resolve_side(ctx, name, acc_id, side): # Exactly one of name/id per side (mutually exclusive). id path (ISSUES.md # #2) fetches by id, validating existence; name path resolves as before. @@ -49,6 +48,7 @@ def _resolve_side(ctx, name, acc_id, side): f"(got name={name!r}, id={acc_id!r})") return ctx.resolver.account_by_id(acc_id) if acc_id else ctx.resolver.account(name) +@registry.command("tx add", help="record a transaction; source/destination resolve to accounts, category/tags auto-create", args=_add_args) def cmd_add(args, ctx): src = _resolve_side(ctx, args.source, args.source_id, "from") dst = _resolve_side(ctx, args.dest, args.dest_id, "to") diff --git a/firefly_cli/resolver.py b/firefly_cli/resolver.py index 2a73e79..7296aad 100644 --- a/firefly_cli/resolver.py +++ b/firefly_cli/resolver.py @@ -30,7 +30,10 @@ class Resolver: def account_by_id(self, acc_id): # Escape hatch for same-name accounts (ISSUES.md #2): GET the account - # directly; a bad id 404s and client.request surfaces a FireflyError. + # directly; a bad id errors and client.request surfaces a FireflyError. + # ponytail: Firefly returns 401 (not 404) for an unknown account id, so + # the message reads "Unauthenticated"; the write is still blocked, which + # is what matters. Remap to "account not found" only if it confuses users. item = self.client.request("GET", f"/api/v1/accounts/{acc_id}")["data"] return {"id": item["id"], **item.get("attributes", {})} |