aboutsummaryrefslogtreecommitdiffstats
path: root/crypto/common
AgeCommit message (Collapse)AuthorFilesLines
53 min.fix(app): harden the setup key importsDanilo M.1-0/+4
- PGP key import reads at most 1 MiB (bounded read, buffer zeroed) and refuses larger files with a new message. - SshKeyViewModel catches any Exception from import and generation (CancellationException rethrown) instead of a short list, so an unexpected provider or sshj error no longer crashes the app. - Pending PGP key bytes are zeroed in a finally block, also on cancellation during addKey after a replace, and an earlier pending pick is zeroed before a new one takes its place. - PGPKeyManager never replaces a stored secret key with a public-only key of the same ID, with or without replace (KeyDowngradeException); the setup ViewModel shows a localized message for it. Unit test added. - storeRecipients strips '#' comments and a trailing '!' as pass reads .gpg-id; tests added. - GitServerViewModel.clearStore returns the failure when the store folder cannot be emptied, so the clone does not start; the plan's Task 3 call site reports it. - readGpgId opens the file with NOFOLLOW_LINKS and reads at most 64 KiB + 1 bytes, refusing more. - SshKey.import writes the new private key to a temp file and moves it over atomically before dropping the old key's Keystore entry, public key and passphrase, so an I/O error keeps the old key. - KeyUtils.isSecretKey notes (ponytail) that GnuPG stub and smartcard keyrings count as secret. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
29 hoursbuild(deps): update Bouncy Castle to 1.86 and PGPainless to 1.7.8Danilo M.1-5/+1
Bouncy Castle 1.78.1 is affected by GHSA-574f-3g2m-x479, GHSA-9pwp-9qqc-pr26, GHSA-c3fc-8qff-9hwx and GHSA-qp49-qgx5-5m26, all fixed by 1.85. PGPainless 1.7.8 is the newest 1.x release. A root resolution rule keeps every Bouncy Castle module on the catalog version; before, bcpg 1.77 shipped next to bcprov 1.78.1. The new stack decrypts the OCB (LibrePGP) packets GnuPG 2.3+ emits by default, which the old one rejected as "non-standard AEAD". Drop the NonStandardAEAD error, its bottom sheet and strings, and replace the mislabelled aead_* fixtures (SHA-1 self-signed keys plus a message encrypted to an unrelated key) with a real GnuPG 2.5 key and OCB message that the tests now decrypt. The new fixture is a throwaway test key, so it is allowlisted in .gitleaksignore by fingerprint. Fix KeyUtils.isKeyUsable, which compared a Boolean to null and so accepted every key that parsed, including keys with no encryption subkey. A signing-only key fixture now covers the rejection path. Also: migrate the removed SelectUserId.firstMatch and deprecated addDecryptionPassphrase APIs, keep one copy of the Bouncy Castle META-INF/LICENSE.md in the APK, and move the existing InvalidPackage lint baseline entries to the bcpkix 1.86 jar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2024-09-03fix(deps): update dependency com.android.tools.build:gradle to v8.6.0 (#3192)renovate[bot]1-1/+1
* fix(deps): update dependency com.android.tools.build:gradle to v8.6.0 * chore: regenerate Lint baselines --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2024-08-14chore: add missing copyright headers and update existing onesHarsh Shandilya5-3/+13
2024-06-14fix(deps): update dependency com.android.tools.build:gradle to v8.5.0 (#3094)renovate[bot]1-1/+1
* fix(deps): update dependency com.android.tools.build:gradle to v8.5.0 * chore: refresh Lint baseline --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2024-05-27feat(pgpainless): add detection for passphrase-less messages (#3069)Harsh Shandilya1-0/+5
* WIP: feat(pgpainless): add detection for passphrase-less messages * refactor: test keys instead of the message This makes more logical sense
2024-04-14fix: special-case AEAD failureHarsh Shandilya1-1/+6
Fixes #2974 Fixes #2963 Fixes #2921 Fixes #2924 Fixes #2653 Fixes #2461 Fixes #2586 Fixes #2179
2024-02-04Sync localisations from Crowdin (#2888)Harsh Shandilya1-1/+1
* strings: sync with crowdin * chore: refresh Lint baseline --------- Co-authored-by: GitHub Actions <noreply@github.com>
2023-12-27Revert "fix: check if passphrase is necessary before asking for it"Harsh Shandilya1-6/+0
Didn't fix the issue. This reverts commit d8f76b33e9ea74eb567a115dd63559f6b27b2fce.
2023-12-25fix: check if passphrase is necessary before asking for itHarsh Shandilya1-0/+6
Updates #2836
2023-11-27fix(deps): upgrade to JGit 4.5.7.201904151645-rHarsh Shandilya1-1/+1
Currently requires deleting and re-cloning the repository to properly detect symlink support, this will be fixed in the future to auto-detect on existing repositories as well. Fixes #2594 Fixes #2396 Fixes #636 Fixes #387 Fixes #98
2023-09-27fix(deps): update dependency com.slack.lint:slack-lint-checks to v0.6.0 (#2697)renovate[bot]1-1/+1
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2023-08-30fix(deps): update dependency org.pgpainless:pgpainless-core to v1.6.2 (#2667)renovate[bot]1-1/+1
* fix(deps): update dependency org.pgpainless:pgpainless-core to v1.6.2 * fix(deps): use `-jdk18on` artifacts for BouncyCastle * chore: re-roll Lint baseline --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2023-08-10refactor: un-flatten module structureHarsh Shandilya6-0/+152