aboutsummaryrefslogtreecommitdiffstats
path: root/app/src/main/java/com
AgeCommit message (Collapse)AuthorFilesLines
2020-03-29Significantly improve app theming (#679)Harsh Shandilya1-1/+32
* Update CHANGELOG * Use outlined box style in folder creation dialog * Add user-facing choice for app theme Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-29Don't inflate menu multiple times (#678)Harsh Shandilya1-1/+5
Otherwise you get this insanity https://i.imgur.com/N918NFG.png Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-29Workaround and potential fix for search issues (#677)Fabian Henneke1-2/+3
2020-03-28Add "alias" to the username heuristic terms (#676)Fabian Henneke1-1/+1
2020-03-27Let IME button dismiss keyboard during search (#673)Fabian Henneke1-0/+1
The IME search button is currently without function while the PasswordStore SearchView is focused, which means that the keyboard hides part of the search result until back is pressed. This commit makes the IME button function like the back key in this situation, dismissing the keyboard. Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-03-27Fix: Restore store scroll position on back press (#670)Fabian Henneke1-2/+2
Restoring the scroll position in the main store fragment is currently broken since the stored state (recyclerView.verticalScrollbarPosition) is always 0 - it is just an enum that governs where the scrollbar is placed on the screen. The fix is to remember the list position of the last fully visible item and scroll to it when restoring the scroll position. Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-03-27Fix: Set childCount correctly on recycled rows (#675)Fabian Henneke1-4/+2
The childCount is not set explicitly for empty directories, which means that the childCount of the entry from which the current row was recycled is preserved. This results in empty directories being shown with seemingly random child counts. The fix is to always set text and visibility for the childCount view. Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-03-27Un-hack focus gain in folder creation dialog (#672)Fabian Henneke1-15/+15
The current way to let the folder name EditText in the folder creation dialog gain focus is... slightly hacky. This commit proposes a more conceptual solution, which, if it works reliably, could be much easier to maintain.
2020-03-27Improve Autofill heuristic terms (#674)Fabian Henneke1-2/+2
Add "e-mail" and "login" as username terms and sort the lists. Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-03-27Make folder creation dialog cancelable (#671)Fabian Henneke1-1/+0
2020-03-26Fix: Commit file after Autofill generate/save (#669)Fabian Henneke2-13/+24
Currently, password files generated via the Autofill generate or save flow are not committed to the Git repository and therefore also not synchronized to the remote. The root cause is that it was missed that PgpActivity relies on PasswordStore to commit the changes when it returns an appropriate result code. The fix is to extract the commit code into the companion object of PasswordStore and call it from AutofillSaveActivity's onActivityResult.
2020-03-26Fix deletion of individual password files (#668)Fabian Henneke1-1/+5
Commit fde8137b (#659) introduced a regression that results in Password Store crashing when the user tries to delete a single password file as opposed to a directory. The root cause is a call of FileUtils.listFiles() on the selected item, which only works for directories. The fix is to work with a list consisting only of the selected item if it happens to be a file.
2020-03-26Fix: Don't apply single-origin mode to native apps (#667)Fabian Henneke2-16/+10
An unwarranted use of the Elivs operator in Form.kt makes it such that the restrictions of single-origin mode also apply to native apps. This commit fixes the bug and also reduces the number of intermediate values that can mask mistakes like this one. It also renames saveFlag to saveFlags in BrowserAutofillSupportInfo since this variable is not limited to contain only a single flag.
2020-03-26Workaround: Prevent fill-in datasets from being shown on Android… (#666)Fabian Henneke1-1/+8
2020-03-25Fix: Properly handle IP addresses and invalid domains in Autofill (#664)Fabian Henneke1-2/+13
Mozilla's getPublicSuffixPlusOne is only meant to be invoked on syntactically valid domain names. In particular, it does not give reasonable results for IP addresses. This commit ensures that the domain passed to getPublicSuffixPlusOne is syntactically valid and not an IP address (the latter is unfortunately considered a domain by the Android validation patterns).
2020-03-25Make preferred directory structure for Autofill configurable (#660)Fabian Henneke7-65/+193
Some users keep their password files in a directory structure such as: /example.org/john@doe.org.gpg while others prefer the style: /example.org/john@doe.org/password.gpg This commit adds a setting that allows to switch between the two. All Autofill operations, such as search, match, generate and save, respect this setting. Note: The first style seems to be the most widely used and is therefore kept as the default. The second style is mentioned on the official Pass website at: https://www.passwordstore.org/#organization
2020-03-25Add "pass" as a hint pattern for password fields (#661)Fabian Henneke1-1/+1
2020-03-25Add more lenient rules that apply only on manual request (#662)Fabian Henneke5-17/+74
Add rules that match password/username fields even if no heuristic matches, but only when the user explicitly requests Autofill. Since there is now a generic way to always trigger Autofill (at least in apps), other rules no longer need to match fields that fail the heuristics. Along the way, the apply functions in AutofillStrategy.kt are renamed to match in order to not conflict with the Kotlin apply() extension function. Furthermore, named parameters are used more widely now to pass around Booleans.
2020-03-25Delete AutofillMatches when deleting files (#659)Fabian Henneke2-5/+11
2020-03-24Add support for Oreo Autofill (#653)Fabian Henneke20-55/+2983
Adds support for the Autofill feature first available in Android Oreo. In compatible apps and browsers, login forms are automatically detected and the user is presented with options to fill or generate credentials. In most apps and certain browsers, the service will also offer to create new Password Store entries from credentials entered into login forms. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-21Revise copy (#656)Harsh Shandilya1-15/+22
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20Codestyle cleanupHarsh Shandilya12-61/+68
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20ClipboardService: Fix iconHarsh Shandilya1-1/+1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-07Show snackbar when git repo is not initialized (#651)Aditya Wasan2-10/+17
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-03-05Resolve various memory leaks (#637)Harsh Shandilya5-71/+247
This migrates the clipboard clear logic into a foreground service that allows us to also provide a notification that runs the clear task immediately on click, rather than wait for the timeout. Co-authored-by: Aditya Wasan <adityawasan55@gmail.com> Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-01Swipe2refresh fix (#647)glowinthedark1-6/+1
2020-03-01swipe to refresh using androidx SwipeRefreshLayout (#645)glowinthedark1-0/+27
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-01Add xkpasswd-style password generator (#633)glowinthedark7-9/+503
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-24Add longpress to copy implicit username (#635)Gigahawk1-0/+6
* Add longpress to copy implicit username * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-22Delete passwords recursively (#639)Harsh Shandilya1-1/+1
Delete passwords recursively * Fixes #638 * Update CHANGELOG Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-21UserPreference: Fix changes from 9787489bc5b7Harsh Shandilya1-1/+2
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-21AutofillService: Speed item loadingHarsh Shandilya1-4/+4
Don't make cacheable function calls in loops Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-21Resolve some crashes reported on Play Store (#631)Harsh Shandilya2-6/+5
* ShowSshKeyFragment: Resolve illegal casts * UserPreference: Try harder to not crash Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-20Better UI flow (#630)Gigahawk3-4/+37
* Filter against entire pathname when searching * Add option to directly open search dialog on start * Replace basic search filter with fuzzy search * Update CHANGELOG Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Open search in onResume, force search icon to always show * Add option to always search from root directory Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-10Gain focus in folder creation dialog (#624)Harsh Shandilya1-2/+21
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2020-02-01Theming related fixes (#627)Harsh Shandilya3-3/+7
* Make navigation match window background Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> * Remove light navigation flag Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> * Use black navbar in light theme windowLightNavigationBar is not portable across API 23 to 29 so we're better off with this solution Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> * Simplify folder dialog title UI Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> * Make night theme completely flat Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> * Remove unnecessary type Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> * Don't try to use non-existent external repo Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2020-01-30Autofill UX improvements and code cleanup (#626)Harsh Shandilya1-71/+56
Co-authored-by: Aditya Wasan <adityawasan55@gmail.com> Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-01-30Update license headers (#625)Harsh Shandilya48-48/+48
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-01-28Allow creating folders (#623)Harsh Shandilya4-5/+220
* Introduce EmitExpandableTransformationBehaviour * Implement expand transition * More folder work * Add icons and tweak layout clipping Rishi again with the icon rescue * Theming rework * Dont set tag * Update list and commit after creating folder * Fix theme issues * Add dialog title * Fix hint text color * Remove commit method * Cleanup * Update CHANGELOG Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2020-01-27Improved debugging tools (#620)Harsh Shandilya1-0/+4
* Add WhatTheStack * Add leakcanary * Codestyle nit * Support snapshot builds for debug tooling Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-01-26Add fastscroller with alphabetic hints (#616)Harsh Shandilya4-2/+18
* Setup basic fast scroll Work towards #558 * Implement PopupTextProvider Fixes #558 * Update changes * Hide system scrollbars * Port fastscroll to autofill preferences * Spotless Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-01-26Switch to Timber for logging (#617)Harsh Shandilya9-43/+63
* Switch to Timber for logging Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> * Update changelog Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com> * Fix rebase error Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-01-25Correctly unmarshal errors from OpenKeychain (#615)Harsh Shandilya2-2/+2
Fixes #614 Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-01-21Add full path open in autofill dialog (#609) (#610)Gigahawk2-2/+11
Fixes #609
2020-01-21Fix autofill window size (#611) (#612)Gigahawk1-2/+3
2019-12-16Fix release builds (#601)Harsh Shandilya1-1/+6
* proguard: Don't obfuscate stacktraces * Deploy snapshots from this branch * PasswordRepository: Handle uninitialized settings * Keep classes that are used in parcels * Revert "Deploy snapshots from this branch" This reverts commit 66918ca2b90dbf7629bd56606eb3d3f578d96105. Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-11-29Update to openpgp-ktx 1.0.0 (#585)Harsh Shandilya2-164/+173
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-11-29LaunchActivity: Optionally delay finish call to allow transition… (#583)Harsh Shandilya1-4/+5
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-11-16Tweak password row layout some more (#567)Harsh Shandilya1-7/+7
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-11-15Also count subdirectories in child count (#573)Harsh Shandilya1-1/+9
* Also count sub-directories in child count * Respect hidden folders setting in child count Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>