aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-04-06Fix: Make path editable when generating a password (#688)Fabian Henneke1-3/+4
2020-04-05Fix: Make generated entry path editable without suggested username (#687)Fabian Henneke1-1/+1
The path of a new entry created via Autofill should always be editable, even when no username is prefilled (e.g., when generating a new password or saving a form with no detected username field).
2020-04-02Update dependencies and fix Gradle props (#684)Harsh Shandilya2-10/+3
* Remove CI specific gradle props They are installed by the CI pipeline automatically Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Upgrade AGP to 3.6.2 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Suppress android.useMinimalKeepRules warning Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update to Spotless 3.28.1 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-29Significantly improve app theming (#679)Harsh Shandilya17-37/+98
* Update CHANGELOG * Use outlined box style in folder creation dialog * Add user-facing choice for app theme Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-29Fix PgpActivity crash on orientation change (#681)Fabian Henneke1-1/+2
Currently, PgpActivity resets or crashes when the orientation (or screen size) changes. Since we do not use separate resources in landscape mode, the easiest and only slightly hacky solution is to tell the system to not recreate the activity in response to these changes.
2020-03-29Don't inflate menu multiple times (#678)Harsh Shandilya1-1/+5
Otherwise you get this insanity https://i.imgur.com/N918NFG.png Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-29Workaround and potential fix for search issues (#677)Fabian Henneke1-2/+3
2020-03-28Add "alias" to the username heuristic terms (#676)Fabian Henneke1-1/+1
2020-03-27Let IME button dismiss keyboard during search (#673)Fabian Henneke1-0/+1
The IME search button is currently without function while the PasswordStore SearchView is focused, which means that the keyboard hides part of the search result until back is pressed. This commit makes the IME button function like the back key in this situation, dismissing the keyboard. Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-03-27Fix: Restore store scroll position on back press (#670)Fabian Henneke1-2/+2
Restoring the scroll position in the main store fragment is currently broken since the stored state (recyclerView.verticalScrollbarPosition) is always 0 - it is just an enum that governs where the scrollbar is placed on the screen. The fix is to remember the list position of the last fully visible item and scroll to it when restoring the scroll position. Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-03-27Fix: Set childCount correctly on recycled rows (#675)Fabian Henneke1-4/+2
The childCount is not set explicitly for empty directories, which means that the childCount of the entry from which the current row was recycled is preserved. This results in empty directories being shown with seemingly random child counts. The fix is to always set text and visibility for the childCount view. Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-03-27Un-hack focus gain in folder creation dialog (#672)Fabian Henneke1-15/+15
The current way to let the folder name EditText in the folder creation dialog gain focus is... slightly hacky. This commit proposes a more conceptual solution, which, if it works reliably, could be much easier to maintain.
2020-03-27Improve Autofill heuristic terms (#674)Fabian Henneke1-2/+2
Add "e-mail" and "login" as username terms and sort the lists. Co-authored-by: Harsh Shandilya <msfjarvis@gmail.com>
2020-03-27Make folder creation dialog cancelable (#671)Fabian Henneke1-1/+0
2020-03-26Fix: Commit file after Autofill generate/save (#669)Fabian Henneke2-13/+24
Currently, password files generated via the Autofill generate or save flow are not committed to the Git repository and therefore also not synchronized to the remote. The root cause is that it was missed that PgpActivity relies on PasswordStore to commit the changes when it returns an appropriate result code. The fix is to extract the commit code into the companion object of PasswordStore and call it from AutofillSaveActivity's onActivityResult.
2020-03-26Fix deletion of individual password files (#668)Fabian Henneke1-1/+5
Commit fde8137b (#659) introduced a regression that results in Password Store crashing when the user tries to delete a single password file as opposed to a directory. The root cause is a call of FileUtils.listFiles() on the selected item, which only works for directories. The fix is to work with a list consisting only of the selected item if it happens to be a file.
2020-03-26Fix: Don't apply single-origin mode to native apps (#667)Fabian Henneke2-16/+10
An unwarranted use of the Elivs operator in Form.kt makes it such that the restrictions of single-origin mode also apply to native apps. This commit fixes the bug and also reduces the number of intermediate values that can mask mistakes like this one. It also renames saveFlag to saveFlags in BrowserAutofillSupportInfo since this variable is not limited to contain only a single flag.
2020-03-26[ci skip] Update CHANGELOGHarsh Shandilya1-0/+3
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-26Workaround: Prevent fill-in datasets from being shown on Android… (#666)Fabian Henneke1-1/+8
2020-03-25Fix: Properly handle IP addresses and invalid domains in Autofill (#664)Fabian Henneke1-2/+13
Mozilla's getPublicSuffixPlusOne is only meant to be invoked on syntactically valid domain names. In particular, it does not give reasonable results for IP addresses. This commit ensures that the domain passed to getPublicSuffixPlusOne is syntactically valid and not an IP address (the latter is unfortunately considered a domain by the Android validation patterns).
2020-03-25Make preferred directory structure for Autofill configurable (#660)Fabian Henneke11-67/+212
Some users keep their password files in a directory structure such as: /example.org/john@doe.org.gpg while others prefer the style: /example.org/john@doe.org/password.gpg This commit adds a setting that allows to switch between the two. All Autofill operations, such as search, match, generate and save, respect this setting. Note: The first style seems to be the most widely used and is therefore kept as the default. The second style is mentioned on the official Pass website at: https://www.passwordstore.org/#organization
2020-03-25Add "pass" as a hint pattern for password fields (#661)Fabian Henneke1-1/+1
2020-03-25Add more lenient rules that apply only on manual request (#662)Fabian Henneke5-17/+74
Add rules that match password/username fields even if no heuristic matches, but only when the user explicitly requests Autofill. Since there is now a generic way to always trigger Autofill (at least in apps), other rules no longer need to match fields that fail the heuristics. Along the way, the apply functions in AutofillStrategy.kt are renamed to match in order to not conflict with the Kotlin apply() extension function. Furthermore, named parameters are used more widely now to pass around Booleans.
2020-03-25Delete AutofillMatches when deleting files (#659)Fabian Henneke2-5/+11
2020-03-25Upgrade Spotless and Kotlin (#658)Harsh Shandilya1-3/+3
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-24Add support for Oreo Autofill (#653)Fabian Henneke41-85/+3566
Adds support for the Autofill feature first available in Android Oreo. In compatible apps and browsers, login forms are automatically detected and the user is presented with options to fill or generate credentials. In most apps and certain browsers, the service will also offer to create new Password Store entries from credentials entered into login forms. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-21Revise copy (#656)Harsh Shandilya14-180/+183
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20CHANGELOG: Fix linksHarsh Shandilya1-7/+7
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20Prepare next development versionHarsh Shandilya1-2/+2
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20Bump version to 1.6.0Harsh Shandilya2-3/+6
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20Upgrade to Build Tools 29.0.3Harsh Shandilya1-1/+1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20Codestyle cleanupHarsh Shandilya12-61/+68
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20ClipboardService: Fix iconHarsh Shandilya1-1/+1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-20Dependency upgradesHarsh Shandilya1-7/+7
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-07Show snackbar when git repo is not initialized (#651)Aditya Wasan3-10/+18
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-03-07Upgrade all dependencies (#649)Harsh Shandilya3-16/+12
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-05Resolve various memory leaks (#637)Harsh Shandilya11-84/+259
This migrates the clipboard clear logic into a foreground service that allows us to also provide a notification that runs the clear task immediately on click, rather than wait for the timeout. Co-authored-by: Aditya Wasan <adityawasan55@gmail.com> Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-01Swipe2refresh fix (#647)glowinthedark1-6/+1
2020-03-01swipe to refresh using androidx SwipeRefreshLayout (#645)glowinthedark5-7/+43
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-03-01Add xkpasswd-style password generator (#633)glowinthedark13-10/+9719
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-25CI workflow improvements (#642)Harsh Shandilya5-16/+42
* github: Only run debug tasks in PRs * github: Remove nightly deploys * github: Setup automatic debug branch deployment * Tweak Gradle config in CI Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Aditya Wasan <adityawasan55@gmail.com>
2020-02-25Update AGP and GradleHarsh Shandilya3-2/+5
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-24Update dependenciesHarsh Shandilya1-8/+8
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-24Bump com.github.ben-manes.versions from 0.27.0 to 0.28.0 (#641)dependabot-preview[bot]1-1/+1
Bumps com.github.ben-manes.versions from 0.27.0 to 0.28.0. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-24Add longpress to copy implicit username (#635)Gigahawk2-0/+9
* Add longpress to copy implicit username * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-22Delete passwords recursively (#639)Harsh Shandilya2-1/+4
Delete passwords recursively * Fixes #638 * Update CHANGELOG Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-21release/deploy-github: Fix release stepHarsh Shandilya1-1/+1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-21Update CHANGELOGHarsh Shandilya1-0/+5
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-21Prepare next development versionHarsh Shandilya1-2/+2
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-02-21Bump versionHarsh Shandilya1-2/+2