summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-09-29Unwrap root cause for InvalidRemoteException (#1122)Harsh Shandilya2-1/+6
* BaseGitActivity: unwrap root cause for InvalidRemoteException as well JGit's InvalidRemoteException, like TransportException, swallows more useful errors as is clear from this (redacted) snippet. ``` D org.eclipse.jgit.api.errors.InvalidRemoteException: Invalid remote: origin D at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:26) D at org.eclipse.jgit.api.PullCommand.call(PullCommand.java:41) D at com.zeapo.pwdstore.git.GitCommandExecutor$execute$2$result$1.invokeSuspend(GitCommandExecutor.kt:2) D at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3) D at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:15) D at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:1) D at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:13) D Caused by: org.eclipse.jgit.errors.NoRemoteRepositoryException: ssh://msfjarvis@[fe80::dead:beef]:22/pass-repo: fatal: '/pass-repo' does not appear to be a git repository D at org.eclipse.jgit.transport.TransportGitSsh.cleanNotFound(TransportGitSsh.java:14) D at org.eclipse.jgit.transport.TransportGitSsh$SshFetchConnection.<init>(TransportGitSsh.java:20) D at org.eclipse.jgit.transport.TransportGitSsh.openFetch(TransportGitSsh.java:1) D at org.eclipse.jgit.transport.FetchProcess.executeImp(FetchProcess.java:1) D at org.eclipse.jgit.transport.Transport.fetch(Transport.java:20) D at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:18) ``` Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Add changelog entry Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-26Update Public Suffix List data (#1121)github-actions[bot]1-0/+0
Co-authored-by: FabianHenneke <FabianHenneke@users.noreply.github.com>
2020-09-24Prepare release 1.12.0v1.12.0Harsh Shandilya2-3/+7
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-24Restore settings button to onboarding screen (#1119)Harsh Shandilya2-0/+16
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-22Sync strings from Crowdin (#1117)Harsh Shandilya15-167/+543
* strings: sync from Crowdin Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Update changelog Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: disable ImpliedQuantity lint I hope our translators know better Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-21Remove Autofill onboarding prompt and cleanup strings (#1116)Harsh Shandilya15-182/+1
2020-09-21Refactor auth mode check/uncheck (#1115)Harsh Shandilya1-7/+11
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-21Revert "github: remove ci-gradle.properties" (#1113)Harsh Shandilya4-0/+16
GitHub's runners are still too weak for us to go by without doing this: https://pipelines.actions.githubusercontent.com/eRaLlgv7QgiQrEiMWvOVzCfcXl8ehv3iNil9w7DRw7wdT9P1kT/_apis/pipelines/1/runs/2741/signedlogcontent/3?urlExpires=2020-09-21T07%3A46%3A57.1297541Z&urlSigningMethod=HMACV1&urlSignature=6e1r7tlUIn9E2EuEm2i4skqgQwZ4jCmO9ARlGZ6a3SU%3D This reverts commit 098c765132a823225e2b2ef82c1302e02f68cd31.
2020-09-20github: remove ci-gradle.propertiesHarsh Shandilya4-21/+0
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20gradle: update properties list for build improvementsHarsh Shandilya2-13/+40
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20Dependencies: downgrade annotation to 1.1.0Harsh Shandilya1-1/+1
We don't use the new annotation added in the alpha and since this dependency is shared between the library and app it's best to stick to stable until necessary Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20autofill-parser: add dependency on AndroidX annotationHarsh Shandilya1-0/+1
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20autofill-parser: drop use of core-ktxHarsh Shandilya2-5/+5
We use an alpha version of core-ktx that might be undesirable for projects including the library Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20autofill-parser: add READMEHarsh Shandilya1-0/+37
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-20autofill-parser: configure maven-publish pluginHarsh Shandilya3-0/+60
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19Add check for potential issues with SSH URLHarsh Shandilya3-0/+22
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19BasicBottomSheet: initHarsh Shandilya2-0/+206
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-19Finish activity in case of external directory (#1110)Aditya Wasan1-1/+4
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-09-18Misc cleanups to build and extension functions (#1108)Harsh Shandilya11-172/+221
2020-09-18Add annotation to WelcomeFragment class (#1107)Aditya Wasan1-0/+2
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
2020-09-17github: remove nonFree flavor from tests (#1102)Harsh Shandilya1-16/+3
Our tests have zero differences between these flavors so running 4 jobs rather than 2 just slows us down Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-16Autofill: Extract AutofillParser into separate subproject (#1101)Vincent Breitmoser36-536/+623
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Fabian Henneke <fabian@henneke.me>
2020-09-15Update on-boarding UI (#1099)Aditya Wasan18-142/+517
* Add onboarding flow from v2 Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Minor fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Add changelog entry Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Remove old activity from manifest Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Remove view type prefix from view ids Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Review fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Treewide: Reformat code Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Moar review fixes Signed-off-by: Aditya Wasan <adityawasan55@gmail.com> * Revert "Treewide: Reformat code" This reverts commit 348ef0050942526a55890b245afec8d7fee4d81e. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * onboarding: cleanup OnboardingActivity init Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unused layout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unnecessary ConstraintLayout Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Shorten animation duration Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * onboarding: use viewBinding extension in fragments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-14Add tentative workaround for dialog crashes and refactor Git-related code ↵Harsh Shandilya7-63/+58
(#1100) * Ensure we're creating dialogs on the main thread Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Remove unused operation type Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Refactor launchGitOperation to use an enum Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-13PasswordRepository: properly gate symlink feature (#1098)Harsh Shandilya1-7/+9
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-12Continue onboarding if permissions are granted prematurely (#1097)Harsh Shandilya1-0/+4
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-12Update Public Suffix List data (#1096)github-actions[bot]1-0/+0
Co-authored-by: FabianHenneke <FabianHenneke@users.noreply.github.com>
2020-09-11Correctly count children in password list (#1095)Harsh Shandilya1-9/+1
2020-09-11Disable SSH multiplexing if not supported (#1093)Fabian Henneke5-2/+44
Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-10build: update Kotlin and dependency-updates plugin (#1094)Harsh Shandilya2-2/+2
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-10Autofill: add kiwi as a supported browser (#1091)Rounak Datta3-1/+4
2020-09-09Fix directory selection in onboarding if storage permissions are granted (#1090)Harsh Shandilya4-18/+20
* OnboardingActivity: fix directory change option Add an else clause to cover the case when storage permission is granted already Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * all: rename permission grant method The new name is a bit more explicit about its purpose Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * UserPreference: add static method for external directory selection intent Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-08Support multiple authentication methods (#825)Fabian Henneke4-28/+32
* Offer password SSH authentication after publickey * git: re-add back button handling Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Hide unsupported authentication methods Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * GitCommandExecutor: cleanup and address build warning Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * DecryptActivity: hide menu items until decrypt finishes Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Add changelog entry Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-08Use same checks as BiometricAuthenticator in UserPreference (#1088)Aditya Wasan3-8/+10
2020-09-07UX fixups and improvements (#1086)Harsh Shandilya6-6/+66
* git: re-add back button handling Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Hide unsupported authentication methods Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * GitCommandExecutor: cleanup and address build warning Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * Address review comments Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * DecryptActivity: hide menu items until decrypt finishes Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * GitServerConfigActivity: don't finish on failure Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-07Fix behavior on failing Git operations (#1084)Fabian Henneke5-27/+52
2020-09-07Fix changelog links (#1083)Harsh Shandilya2-13/+13
* changelog: fix links Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * github: prepend 'v' to version passed in changelog action Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-06Update dependencies and add EditorConfig file (#1082)Harsh Shandilya4-12/+34
* build: uprev Gradle Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * editorconfig: init Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: remove unused dependency analysis plugin Signed-off-by: Harsh Shandilya <me@msfjarvis.dev> * build: update ConstraintLayout and AndroidX testing libraries Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05PasswordGeneratorDialogFragment: use runCatching to replace exception handlingHarsh Shandilya1-5/+6
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05DecryptActivity: use runCatching to replace exception handlingHarsh Shandilya1-7/+12
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05PasswordCreationActivity: use runCatching to replace exception handlingHarsh Shandilya1-19/+20
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05SshjConfig: use runCatching to replace exception handlingHarsh Shandilya1-4/+2
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05BasePgpActivity: use runCatching to replace exception handlingHarsh Shandilya1-15/+7
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05SshKey: use runCatching to replace exception handlingHarsh Shandilya1-10/+12
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05SshjSessionFactory: use runCatching to replace exception handlingHarsh Shandilya1-3/+4
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05GitOperation: use runCatching to replace exception handlingHarsh Shandilya1-6/+7
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05GitLogModel: use runCatching to replace exception handlingHarsh Shandilya1-3/+5
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05AutofillPublisherChangedActivity: use runCatching to replace exception handlingHarsh Shandilya1-3/+5
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05AutofillScenario: use runCatching to replace exception handlingHarsh Shandilya1-3/+5
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
2020-09-05GitSettings: use runCatching to replace exception handlingHarsh Shandilya1-2/+4
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>