build: update to Gradle 9.8.2, AGP 9.5.0, Kotlin 2.4.21, Hilt 2.60.1

AGP 9 migration:
- Configure the shared Android setup through the new DSL
  (CommonExtension, ApplicationExtension) instead of the removed
  TestedExtension and BaseAppModuleExtension; targetSdk moves to the
  application extension.
- Stop applying the Kotlin Android plugin; AGP 9 compiles Kotlin itself.
- Replace kapt with KSP 2.3.13 for Hilt, which built-in Kotlin requires,
  and carry the Dagger compiler options over as KSP arguments.
- AGP 9 now applies packaging excludes to unit-test resources, which
  stripped the diceware word list (**/*.txt) from its tests; lift that
  exclude in the diceware module.
- Use resources.directories instead of the deprecated srcDir.

Plugin updates required by Gradle 9 / AGP 9: Sentry Gradle plugin
6.25.0 (sentry-android 8.62.0), metalava plugin 0.5.1, maven-publish
0.37.0, spotless 8.10.4, version-catalog-update 1.1.2, download task
5.7.0, foojay resolver 1.0.0, with their API changes. Newer metalava
models Kotlin properties, so autofill-parser/api.txt is regenerated;
the diff is representation only, no API was added or removed.

Fix new Kotlin 2.4 and lint findings (explicit return type in a
function with an early return, UseKtx in autofill-parser), drop
deprecated Kotlin Gradle properties, and make the AGENTS.md pre-commit
command cover every task CI runs (both flavors, lint on all modules).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1 files changed, 52 insertions, 34 deletions

diff --git a/gradlew.bat b/gradlew.bat
index 5eed7ee8..03754c4c 100644
--- a/gradlew.bat
+++ b/gradlew.bat
@@ -19,12 +19,39 @@
 @if "%DEBUG%"=="" @echo off

 @rem ##########################################################################

 @rem

-@rem  Gradle startup script for Windows

+@rem  gradlew startup script for Windows

 @rem

 @rem ##########################################################################

 

-@rem Set local scope for the variables with windows NT shell

-if "%OS%"=="Windows_NT" setlocal

+@rem Set local scope for the variables, and ensure extensions are enabled

+setlocal EnableExtensions

+

+@rem Catch executions from older scripts and ensure they exit cleanly.

+@rem This can be removed once we can be reasonably confident that few people

+@rem will be migrating directly to this new wrapper.

+goto afterSafetyNet

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

+goto exitWithErrorLevel

+:afterSafetyNet

 

 set DIRNAME=%~dp0

 if "%DIRNAME%"=="" set DIRNAME=.

@@ -45,13 +72,14 @@ set JAVA_EXE=java.exe
 %JAVA_EXE% -version >NUL 2>&1

 if %ERRORLEVEL% equ 0 goto execute

 

-echo. 1>&2

-echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2

-echo. 1>&2

-echo Please set the JAVA_HOME variable in your environment to match the 1>&2

-echo location of your Java installation. 1>&2

+1>&2 echo.

+1>&2 echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.

+1>&2 echo.

+1>&2 echo Please set the JAVA_HOME variable in your environment to match the

+1>&2 echo location of your Java installation.

 

-goto fail

+"%COMSPEC%" /c exit 1

+goto exitWithErrorLevel

 

 :findJavaFromJavaHome

 set JAVA_HOME=%JAVA_HOME:"=%

@@ -59,36 +87,26 @@ set JAVA_EXE=%JAVA_HOME%/bin/java.exe
 

 if exist "%JAVA_EXE%" goto execute

 

-echo. 1>&2

-echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2

-echo. 1>&2

-echo Please set the JAVA_HOME variable in your environment to match the 1>&2

-echo location of your Java installation. 1>&2

+1>&2 echo.

+1>&2 echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%

+1>&2 echo.

+1>&2 echo Please set the JAVA_HOME variable in your environment to match the

+1>&2 echo location of your Java installation.

 

-goto fail

+"%COMSPEC%" /c exit 1

+goto exitWithErrorLevel

 

 :execute

 @rem Setup the command line

 

-set CLASSPATH=

 

 

-@rem Execute Gradle

-"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*

+@rem Execute gradlew

+@rem endlocal doesn't take effect until after the line is parsed and variables are expanded

+@rem which allows us to clear the local environment before executing the java command

+endlocal & "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* & call :exitWithErrorLevel & goto exitWithErrorLevel

 

-:end

-@rem End local scope for the variables with windows NT shell

-if %ERRORLEVEL% equ 0 goto mainEnd

-

-:fail

-rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of

-rem the _cmd.exe /c_ return code!

-set EXIT_CODE=%ERRORLEVEL%

-if %EXIT_CODE% equ 0 set EXIT_CODE=1

-if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE%

-exit /b %EXIT_CODE%

-

-:mainEnd

-if "%OS%"=="Windows_NT" endlocal

-

-:omega

+@rem This label must not be changed. We rely on old scripts being able to jump to this point.

+:exitWithErrorLevel

+@rem Use "%COMSPEC%" /c exit to allow operators to work properly in scripts

+"%COMSPEC%" /c exit %ERRORLEVEL%