Refactor package structure (#1233)

* idea: default test runner to Gradle

* Kick off package structure revamp

* Reparent all classes under dev.msfjarvis.aps

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

3 files changed, 201 insertions, 0 deletions

diff --git a/app/src/androidTest/java/dev/msfjarvis/aps/util/settings/MigrationsTest.kt b/app/src/androidTest/java/dev/msfjarvis/aps/util/settings/MigrationsTest.kt
new file mode 100644
index 00000000..d27b4c1c
--- /dev/null
+++ b/app/src/androidTest/java/dev/msfjarvis/aps/util/settings/MigrationsTest.kt
@@ -0,0 +1,107 @@
+/*
+ * Copyright © 2014-2020 The Android Password Store Authors. All Rights Reserved.
+ * SPDX-License-Identifier: GPL-3.0-only
+ */
+
+@file:Suppress("DEPRECATION")
+
+package dev.msfjarvis.aps.util.settings
+
+import android.content.Context
+import androidx.core.content.edit
+import dev.msfjarvis.aps.Application
+import dev.msfjarvis.aps.util.extensions.getString
+import dev.msfjarvis.aps.util.extensions.sharedPrefs
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNull
+import org.junit.Test
+
+class MigrationsTest {
+
+    private fun checkOldKeysAreRemoved(context: Context) = with(context.sharedPrefs) {
+        assertNull(getString(PreferenceKeys.GIT_REMOTE_PORT))
+        assertNull(getString(PreferenceKeys.GIT_REMOTE_USERNAME))
+        assertNull(getString(PreferenceKeys.GIT_REMOTE_SERVER))
+        assertNull(getString(PreferenceKeys.GIT_REMOTE_LOCATION))
+        assertNull(getString(PreferenceKeys.GIT_REMOTE_PROTOCOL))
+    }
+
+    @Test
+    fun verifySshWithCustomPortMigration() {
+        val context = Application.instance.applicationContext
+        context.sharedPrefs.edit {
+            clear()
+            putString(PreferenceKeys.GIT_REMOTE_PORT, "2200")
+            putString(PreferenceKeys.GIT_REMOTE_USERNAME, "msfjarvis")
+            putString(PreferenceKeys.GIT_REMOTE_LOCATION, "/mnt/disk3/pass-repo")
+            putString(PreferenceKeys.GIT_REMOTE_SERVER, "192.168.0.102")
+            putString(PreferenceKeys.GIT_REMOTE_PROTOCOL, Protocol.Ssh.pref)
+            putString(PreferenceKeys.GIT_REMOTE_AUTH, AuthMode.Password.pref)
+        }
+        runMigrations(context)
+        checkOldKeysAreRemoved(context)
+        assertEquals(
+            context.sharedPrefs.getString(PreferenceKeys.GIT_REMOTE_URL),
+            "ssh://msfjarvis@192.168.0.102:2200/mnt/disk3/pass-repo"
+        )
+    }
+
+    @Test
+    fun verifySshWithDefaultPortMigration() {
+        val context = Application.instance.applicationContext
+        context.sharedPrefs.edit {
+            clear()
+            putString(PreferenceKeys.GIT_REMOTE_USERNAME, "msfjarvis")
+            putString(PreferenceKeys.GIT_REMOTE_LOCATION, "/mnt/disk3/pass-repo")
+            putString(PreferenceKeys.GIT_REMOTE_SERVER, "192.168.0.102")
+            putString(PreferenceKeys.GIT_REMOTE_PROTOCOL, Protocol.Ssh.pref)
+            putString(PreferenceKeys.GIT_REMOTE_AUTH, AuthMode.SshKey.pref)
+        }
+        runMigrations(context)
+        checkOldKeysAreRemoved(context)
+        assertEquals(
+            context.sharedPrefs.getString(PreferenceKeys.GIT_REMOTE_URL),
+            "msfjarvis@192.168.0.102:/mnt/disk3/pass-repo"
+        )
+    }
+
+    @Test
+    fun verifyHttpsWithGitHubMigration() {
+        val context = Application.instance.applicationContext
+        context.sharedPrefs.edit {
+            clear()
+            putString(PreferenceKeys.GIT_REMOTE_USERNAME, "msfjarvis")
+            putString(PreferenceKeys.GIT_REMOTE_LOCATION, "Android-Password-Store/pass-test")
+            putString(PreferenceKeys.GIT_REMOTE_SERVER, "github.com")
+            putString(PreferenceKeys.GIT_REMOTE_PROTOCOL, Protocol.Https.pref)
+            putString(PreferenceKeys.GIT_REMOTE_AUTH, AuthMode.None.pref)
+        }
+        runMigrations(context)
+        checkOldKeysAreRemoved(context)
+        assertEquals(
+            context.sharedPrefs.getString(PreferenceKeys.GIT_REMOTE_URL),
+            "https://github.com/Android-Password-Store/pass-test"
+        )
+    }
+
+    @Test
+    fun verifyHiddenFoldersMigrationIfDisabled() {
+        val context = Application.instance.applicationContext
+        context.sharedPrefs.edit { clear() }
+        runMigrations(context)
+        assertEquals(true, context.sharedPrefs.getBoolean(PreferenceKeys.SHOW_HIDDEN_FOLDERS, true))
+        assertEquals(false, context.sharedPrefs.getBoolean(PreferenceKeys.SHOW_HIDDEN_CONTENTS, false))
+    }
+
+    @Test
+    fun verifyHiddenFoldersMigrationIfEnabled() {
+        val context = Application.instance.applicationContext
+        context.sharedPrefs.edit {
+            clear()
+            putBoolean(PreferenceKeys.SHOW_HIDDEN_FOLDERS, true)
+        }
+        runMigrations(context)
+        assertEquals(false, context.sharedPrefs.getBoolean(PreferenceKeys.SHOW_HIDDEN_FOLDERS, false))
+        assertEquals(true, context.sharedPrefs.getBoolean(PreferenceKeys.SHOW_HIDDEN_CONTENTS, false))
+    }
+}
diff --git a/app/src/androidTest/java/dev/msfjarvis/aps/util/totp/UriTotpFinderTest.kt b/app/src/androidTest/java/dev/msfjarvis/aps/util/totp/UriTotpFinderTest.kt
new file mode 100644
index 00000000..6dba51b3
--- /dev/null
+++ b/app/src/androidTest/java/dev/msfjarvis/aps/util/totp/UriTotpFinderTest.kt
@@ -0,0 +1,45 @@
+/*
+ * Copyright © 2014-2020 The Android Password Store Authors. All Rights Reserved.
+ * SPDX-License-Identifier: GPL-3.0-only
+ */
+
+package dev.msfjarvis.aps.util.totp
+
+import kotlin.test.assertEquals
+import org.junit.Test
+
+class UriTotpFinderTest {
+
+    private val totpFinder = UriTotpFinder()
+
+    @Test
+    fun findSecret() {
+        assertEquals("HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ", totpFinder.findSecret(TOTP_URI))
+        assertEquals("HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ", totpFinder.findSecret("name\npassword\ntotp: HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ"))
+        assertEquals("HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ", totpFinder.findSecret(PASS_FILE_CONTENT))
+    }
+
+    @Test
+    fun findDigits() {
+        assertEquals("12", totpFinder.findDigits(TOTP_URI))
+        assertEquals("12", totpFinder.findDigits(PASS_FILE_CONTENT))
+    }
+
+    @Test
+    fun findPeriod() {
+        assertEquals(25, totpFinder.findPeriod(TOTP_URI))
+        assertEquals(25, totpFinder.findPeriod(PASS_FILE_CONTENT))
+    }
+
+    @Test
+    fun findAlgorithm() {
+        assertEquals("SHA256", totpFinder.findAlgorithm(TOTP_URI))
+        assertEquals("SHA256", totpFinder.findAlgorithm(PASS_FILE_CONTENT))
+    }
+
+    companion object {
+
+        const val TOTP_URI = "otpauth://totp/ACME%20Co:john@example.com?secret=HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ&issuer=ACME%20Co&algorithm=SHA256&digits=12&period=25"
+        const val PASS_FILE_CONTENT = "password\n$TOTP_URI"
+    }
+}
diff --git a/app/src/androidTest/java/dev/msfjarvis/aps/util/viewmodel/StrictDomainRegexTest.kt b/app/src/androidTest/java/dev/msfjarvis/aps/util/viewmodel/StrictDomainRegexTest.kt
new file mode 100644
index 00000000..876a0478
--- /dev/null
+++ b/app/src/androidTest/java/dev/msfjarvis/aps/util/viewmodel/StrictDomainRegexTest.kt
@@ -0,0 +1,49 @@
+/*
+ * Copyright © 2014-2020 The Android Password Store Authors. All Rights Reserved.
+ * SPDX-License-Identifier: GPL-3.0-only
+ */
+package dev.msfjarvis.aps.util.viewmodel
+
+import kotlin.test.assertFalse
+import kotlin.test.assertNull
+import kotlin.test.assertTrue
+import org.junit.Test
+
+private infix fun String.matchedForDomain(domain: String) =
+    SearchableRepositoryViewModel.generateStrictDomainRegex(domain)?.containsMatchIn(this) == true
+
+class StrictDomainRegexTest {
+
+    @Test fun acceptsLiteralDomain() {
+        assertTrue("work/example.org/john.doe@example.org.gpg" matchedForDomain "example.org")
+        assertTrue("example.org/john.doe@example.org.gpg" matchedForDomain "example.org")
+        assertTrue("example.org.gpg" matchedForDomain "example.org")
+    }
+
+    @Test fun acceptsSubdomains() {
+        assertTrue("work/www.example.org/john.doe@example.org.gpg" matchedForDomain "example.org")
+        assertTrue("www2.example.org/john.doe@example.org.gpg" matchedForDomain "example.org")
+        assertTrue("www.login.example.org.gpg" matchedForDomain "example.org")
+    }
+
+    @Test fun rejectsPhishingAttempts() {
+        assertFalse("example.org.gpg" matchedForDomain "xample.org")
+        assertFalse("login.example.org.gpg" matchedForDomain "xample.org")
+        assertFalse("example.org/john.doe@exmple.org.gpg" matchedForDomain "xample.org")
+        assertFalse("example.org.gpg" matchedForDomain "e/xample.org")
+    }
+
+    @Test fun rejectNonGpgComponentMatches() {
+        assertFalse("work/example.org" matchedForDomain "example.org")
+    }
+
+    @Test fun rejectsEmailAddresses() {
+        assertFalse("work/notexample.org/john.doe@example.org.gpg" matchedForDomain "example.org")
+        assertFalse("work/notexample.org/john.doe@www.example.org.gpg" matchedForDomain "example.org")
+        assertFalse("work/john.doe@www.example.org/foo.org" matchedForDomain "example.org")
+    }
+
+    @Test fun rejectsPathSeparators() {
+        assertNull(SearchableRepositoryViewModel.generateStrictDomainRegex("ex/ample.org"))
+    }
+}