summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDanilo M. <danix@danix.xyz>2026-11-02 19:31:23 +0100
committerDanilo M. <danix@danix.xyz>2026-11-02 19:31:23 +0100
commitc33afe9d099a3cc59d02cef5729b29e4c8270bc4 (patch)
tree1227a5b7c12c7d55bf4e1352e09177f3376e86f2
parentbf07c157071bea82000850ee431917fd5983d96d (diff)
downloadHardenedPass-c33afe9d099a3cc59d02cef5729b29e4c8270bc4.tar.gz
HardenedPass-c33afe9d099a3cc59d02cef5729b29e4c8270bc4.zip
fix(editor): write a space after "username:"
Entries created in the app said "username:dave". pass users and other clients write "username: dave"; the parser already trims either form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
-rw-r--r--CHANGELOG.md2
-rw-r--r--app/src/main/java/app/passwordstore/autofill/oreo/ui/AutofillSmsActivity.kt26
-rw-r--r--app/src/main/java/app/passwordstore/ui/crypto/PasswordCreationActivity.kt2
-rw-r--r--app/src/main/res/drawable/ic_autofill_sms.xml15
4 files changed, 3 insertions, 42 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 62469d96..2e7f628b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,8 @@ All notable changes to this project will be documented in this file.
### Changed
+- New entries write `username: name` with a space after the colon, as `pass` users and other clients expect
+- Removed the inactive "fill OTP from SMS" autofill code, which needed Google Play Services
- Updated sshj to 0.41.2, which drops the unmaintained `net.i2p.crypto:eddsa` library; Ed25519 keys now go through Bouncy Castle. Existing generated Ed25519 keys keep working
## [0.1.3] - 2026-11-02
diff --git a/app/src/main/java/app/passwordstore/autofill/oreo/ui/AutofillSmsActivity.kt b/app/src/main/java/app/passwordstore/autofill/oreo/ui/AutofillSmsActivity.kt
deleted file mode 100644
index 7acc72f9..00000000
--- a/app/src/main/java/app/passwordstore/autofill/oreo/ui/AutofillSmsActivity.kt
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Copyright © 2014-2024 The Android Password Store Authors. All Rights Reserved.
- * SPDX-License-Identifier: GPL-3.0-only
- */
-package app.passwordstore.autofill.oreo.ui
-
-import android.content.Context
-import android.content.IntentSender
-import androidx.appcompat.app.AppCompatActivity
-
-// ponytail: filling OTPs from SMS needed Play Services (removed with the nonFree flavor), so
-// this stub keeps the feature off. Delete it together with the FillOtpFromSms autofill paths.
-@Suppress("UNUSED_PARAMETER")
-class AutofillSmsActivity : AppCompatActivity() {
-
- companion object {
-
- fun shouldOfferFillFromSms(context: Context): Boolean {
- return false
- }
-
- fun makeFillOtpFromSmsIntentSender(context: Context): IntentSender {
- throw NotImplementedError("Filling OTPs from SMS requires non-free dependencies")
- }
- }
-}
diff --git a/app/src/main/java/app/passwordstore/ui/crypto/PasswordCreationActivity.kt b/app/src/main/java/app/passwordstore/ui/crypto/PasswordCreationActivity.kt
index 6971c2e3..7652c98e 100644
--- a/app/src/main/java/app/passwordstore/ui/crypto/PasswordCreationActivity.kt
+++ b/app/src/main/java/app/passwordstore/ui/crypto/PasswordCreationActivity.kt
@@ -335,7 +335,7 @@ class PasswordCreationActivity : BasePGPActivity() {
}
if (!editUsername.isEmpty()) {
- editUsername = "\nusername:$editUsername"
+ editUsername = "\nusername: $editUsername"
}
if (editPass.isEmpty() && editExtra.isEmpty()) {
diff --git a/app/src/main/res/drawable/ic_autofill_sms.xml b/app/src/main/res/drawable/ic_autofill_sms.xml
deleted file mode 100644
index 87158ffe..00000000
--- a/app/src/main/res/drawable/ic_autofill_sms.xml
+++ /dev/null
@@ -1,15 +0,0 @@
-<!--
- ~ Copyright © 2014-2024 The Android Password Store Authors. All Rights Reserved.
- ~ SPDX-License-Identifier: GPL-3.0-only
- -->
-
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
- android:width="24dp"
- android:height="24dp"
- android:tint="?attr/colorControlNormal"
- android:viewportWidth="24"
- android:viewportHeight="24">
- <path
- android:fillColor="#FFFFFF"
- android:pathData="M20,2L4,2c-1.1,0 -1.99,0.9 -1.99,2L2,22l4,-4h14c1.1,0 2,-0.9 2,-2L22,4c0,-1.1 -0.9,-2 -2,-2zM9,11L7,11L7,9h2v2zM13,11h-2L11,9h2v2zM17,11h-2L15,9h2v2z" />
-</vector>