diff options
| author | Danilo M. <danix@danix.xyz> | 2026-11-02 19:45:27 +0100 |
|---|---|---|
| committer | Danilo M. <danix@danix.xyz> | 2026-11-02 19:45:27 +0100 |
| commit | 35316092fd1597873561874ea6cad8801fb979e1 (patch) | |
| tree | 44bfaa74f57b205f4fbf5d77f58b48ccf49eda2f | |
| parent | eb60c81c17b48be8a74790aad5ce2e18e7d0f38b (diff) | |
| download | HardenedPass-35316092fd1597873561874ea6cad8801fb979e1.tar.gz HardenedPass-35316092fd1597873561874ea6cad8801fb979e1.zip | |
fix(ui-compose): tint the copy icon with the platform attribute
ic_content_copy used AppCompat's ?attr/colorControlNormal, which
ui:compose does not depend on, so building the module in release mode
failed resource verification. ?android:attr/colorControlNormal is the
same color under AppCompat themes and needs no dependency. A bare
assembleRelease now passes; update AGENTS.md accordingly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| -rw-r--r-- | AGENTS.md | 5 | ||||
| -rw-r--r-- | ui/compose/src/main/res/drawable/ic_content_copy.xml | 2 |
2 files changed, 3 insertions, 4 deletions
@@ -45,9 +45,8 @@ that passes locally fails CI. Before committing, run: lint metalavaCheckCompatibilityRelease No product flavors: the app has no proprietary dependencies, no Sentry and no Play Services -(the upstream `nonFree` flavor was removed). Scope `assemble*` to `:app`; a bare -`assembleRelease` also verifies library modules in release mode, where `ui:compose` fails on a -drawable using an AppCompat attribute it does not depend on. +(the upstream `nonFree` flavor was removed). Scope `assemble*` to `:app`, which is all CI and +releases need; a bare `assembleRelease` also builds every library module. CI is `.github/workflows/pull_request.yml` (named "CI"), on push to `master`. Workflows use the `setup-gradle` composite action from this fork at `@master`. It checks the repository out diff --git a/ui/compose/src/main/res/drawable/ic_content_copy.xml b/ui/compose/src/main/res/drawable/ic_content_copy.xml index cdee1758..d2aafebf 100644 --- a/ui/compose/src/main/res/drawable/ic_content_copy.xml +++ b/ui/compose/src/main/res/drawable/ic_content_copy.xml @@ -6,7 +6,7 @@ <vector xmlns:android="http://schemas.android.com/apk/res/android" android:width="24dp" android:height="24dp" - android:tint="?attr/colorControlNormal" + android:tint="?android:attr/colorControlNormal" android:viewportWidth="24" android:viewportHeight="24"> <path |