From 867e21f99361c0c566b268006b558ab08256824b Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Tue, 20 Oct 2026 11:37:25 +0200 Subject: Hints tab: a click anywhere on a row ticks or unticks it The box is no longer user-checkable on its own, so a click on it is not counted twice; one cellClicked handler toggles every row click. Co-Authored-By: Claude Opus 5.5 --- sb_builder/hints_tab.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'sb_builder') diff --git a/sb_builder/hints_tab.py b/sb_builder/hints_tab.py index 2956abc..bf2011a 100644 --- a/sb_builder/hints_tab.py +++ b/sb_builder/hints_tab.py @@ -71,6 +71,7 @@ class HintsTab(QWidget): self.table.horizontalHeader().setStretchLastSection(True) for col, width in enumerate((28, 220, 110, 110, 110)): self.table.setColumnWidth(col, width) + self.table.cellClicked.connect(self._toggle) self.status = QLabel() self.check_btn = QPushButton("Check upstream") @@ -122,7 +123,7 @@ class HintsTab(QWidget): for i, r in enumerate(self.rows): r["state"] = upstream.state(r, self.names, self.versions, self.errors) box = QTableWidgetItem() - box.setFlags(Qt.ItemFlag.ItemIsEnabled | Qt.ItemFlag.ItemIsUserCheckable) + box.setFlags(Qt.ItemFlag.ItemIsEnabled) # not user-checkable: _toggle owns every click on = r["state"] == "outdated" if check_outdated else r["name"] in checked box.setCheckState(Qt.CheckState.Checked if on else Qt.CheckState.Unchecked) box.setData(Qt.ItemDataRole.UserRole, r["name"]) @@ -153,6 +154,13 @@ class HintsTab(QWidget): n = len(self.checked()) self.status.setText(f"{shown} shown · {n} selected" + (f" · {self.failure}" if self.failure else "")) + def _toggle(self, row, _col): + """A click anywhere on a row, its box included, ticks or unticks it.""" + box = self.table.item(row, 0) + box.setCheckState(Qt.CheckState.Unchecked if box.checkState() == Qt.CheckState.Checked + else Qt.CheckState.Checked) + self.refilter() + def check_rows(self, on): """Tick every visible row (on), or untick every row.""" state = Qt.CheckState.Checked if on else Qt.CheckState.Unchecked -- cgit v1.2.3