From 7db7405c80e8f00008bc5196abfda2c500071a98 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Thu, 15 Oct 2026 12:20:32 +0200 Subject: fix(updates): review findings in updatesctl A git hash starting with a letter (3.1-a59215d) ordered behind its base, because any trailing alphabetic chunk counted as a pre-release; only alpha, beta, rc, pre and dev do now. Trailing zeros (1.14 against 1.14.0) compare equal instead of reading as an upstream bump. A bad line in the slackpkg blacklist is skipped rather than crashing the script and leaving the drawer with nothing. An AppImage keeps its key over a flatpak of the same name, as the spec orders them, and flatpak list has a timeout. A Slackware upgrade compares version and build, so an arch change alone is not a row. The spec's prose now matches the code: the upstream comparison includes the installed version. Co-Authored-By: Claude Opus 5.5 --- docs/superpowers/specs/2026-10-15-updates-design.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'docs/superpowers') diff --git a/docs/superpowers/specs/2026-10-15-updates-design.md b/docs/superpowers/specs/2026-10-15-updates-design.md index 54ebfbf..e838d28 100644 --- a/docs/superpowers/specs/2026-10-15-updates-design.md +++ b/docs/superpowers/specs/2026-10-15-updates-design.md @@ -59,7 +59,7 @@ matches, so a row shows the next step and nothing after it. 3. **Awaiting build**: R is at or past U, B is older than U, and the package is installed. The SlackBuild, the user's or SBo's, is current and only needs building. -4. **Upstream newer**: U newer than both R and B. The SlackBuild or its hint +4. **Upstream newer**: U newer than the newest of R, B and I. The SlackBuild or its hint needs bumping, then a build. An `SBo` recipe that lags upstream lands here: the bump is a hint file on the build VM. Shown when the package is installed, or when the recipe is the user's (repo work either way). @@ -135,7 +135,7 @@ slot, as a separate commit in that repo. `nvtable` stays in `desktop/modules/updates/test_updatesctl.py`, run with `/usr/bin/python3`: - `vercmp`: 1.14.10 > 1.14.9, 2.1.278 > 2.1.267, 2026_10_02 > 2026_09_12, - a kernel suffix equal to its base. + a kernel suffix or git hash never behind its base. - Section assignment on fixture directories built in a temp dir, one row per case: built and newer goes to Upgrade here, bumped and unbuilt to Awaiting build, unbumped to Upstream newer, an SBo recipe behind upstream to -- cgit v1.2.3