From 661d477e7806d322d3499c19537541c5dd4e7d82 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Tue, 15 Sep 2026 12:29:42 +0200 Subject: fix(status): address final review findings F1: after a click the shared Switch writes checked directly, dropping StatusRow's declarative binding, so an external mode change from waybar or statusctl no longer moved the switch. Resync via onValueChanged. F2: the spec claimed hyprctl clients counts idle inhibitors, which is false for a layer-surface inhibitor; replace with the behavioral hypridle marker check. F3: README said the check covers both watch states; it exercises the activated report and the absent-file down report. F4: give breakProc an onExited check so a failed breaktimer.sh verb is visible instead of silent. F5: drop StatusTile's unused required st property and its injection. F6: comment the startup-order limit on dndBeforePresentation. --- desktop/modules/status/StatusRow.qml | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'desktop/modules/status/StatusRow.qml') diff --git a/desktop/modules/status/StatusRow.qml b/desktop/modules/status/StatusRow.qml index c342e2b..c9e78c0 100644 --- a/desktop/modules/status/StatusRow.qml +++ b/desktop/modules/status/StatusRow.qml @@ -53,4 +53,9 @@ Item { checked: row.value onToggled: Status.toggleMode(row.mode) } + + // The shared Switch's click handler writes `checked` directly, which drops + // the declarative binding above. Resync on any value change so an external + // write (statusctl, waybar) moves the switch back into agreement. + onValueChanged: sw.checked = row.value } -- cgit v1.2.3