From 77952289f8176703eef7134262c6fd6d0d835dd6 Mon Sep 17 00:00:00 2001 From: "Danilo M." Date: Wed, 21 Oct 2026 10:23:05 +0200 Subject: Switch: never set checked itself, report the new state instead The shared Switch flipped its own checked on click, which replaced the caller's binding with a constant. Every use binds checked, so after a click the switch stopped following its source: Discard on a settings draft reverted the value and left the switch showing the click. Four status rows and the headphones panel each carried a resync workaround for it. toggled now carries the new state and the switch moves only when the caller's binding does. Handlers that read checked as the new value take the argument instead; the workarounds are gone. Co-Authored-By: Claude Opus 5.5 --- desktop/modules/status/BreakRow.qml | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'desktop/modules/status/BreakRow.qml') diff --git a/desktop/modules/status/BreakRow.qml b/desktop/modules/status/BreakRow.qml index 70ad3ea..8b732b1 100644 --- a/desktop/modules/status/BreakRow.qml +++ b/desktop/modules/status/BreakRow.qml @@ -81,14 +81,4 @@ Item { onToggled: Status.runBreaktimer(Status.btPaused ? "resume" : "pause") } } - - // The shared Switch writes `checked` on click and so drops the binding - // above. Resync on any state change, which also covers a change made from - // the waybar module's own bindings or from a terminal. - Connections { - target: Status - function onBtStateChanged() { - sw.checked = Status.btRunning && !Status.btPaused; - } - } } -- cgit v1.2.3